fix(middleware-signing): update systemClockOffset on error (#2686)

Author: trivikr

packages/middleware-signing/src/middleware.spec.ts

@@ -89,4 +89,24 @@ describe(awsAuthMiddleware.name, () => {
       expect(getUpdatedSystemClockOffset).toHaveBeenCalledWith(dateHeader, mockSystemClockOffset);
     });
   });
+
+  it("should update systemClockOffset if error contains ServerTime", async () => {
+    const serverTime = new Date().toString();
+    const options = { ...mockOptions };
+    const signingHandler = awsAuthMiddleware(options)(mockNext, {});
+
+    const mockError = Object.assign(new Error("error"), { ServerTime: serverTime });
+    mockNext.mockRejectedValue(mockError);
+
+    try {
+      await signingHandler(mockSigningHandlerArgs);
+      fail(`should throw ${mockError}`);
+    } catch (error) {
+      expect(error).toStrictEqual(mockError);
+    }
+
+    expect(options.systemClockOffset).toBe(mockUpdatedSystemClockOffset);
+    expect(getUpdatedSystemClockOffset).toHaveBeenCalledTimes(1);
+    expect(getUpdatedSystemClockOffset).toHaveBeenCalledWith(serverTime, mockSystemClockOffset);
+  });
 });

packages/middleware-signing/src/middleware.ts

@@ -28,6 +28,11 @@ export const awsAuthMiddleware =
           signingRegion: context["signing_region"],
           signingService: context["signing_service"],
         }),
+      }).catch((error) => {
+        if (error.ServerTime) {
+          options.systemClockOffset = getUpdatedSystemClockOffset(error.ServerTime, options.systemClockOffset);
+        }
+        throw error;
       });
 
       const { headers } = output.response as any;