chore: add feature flags for RequestChecksumCalculation and ResponseChecksumValidation

Author: trivikr

packages/middleware-flexible-checksums/src/flexibleChecksumsInputMiddleware.spec.ts

@@ -1,9 +1,12 @@
+import { setFeature } from "@aws-sdk/core";
 import { afterEach, describe, expect, test as it, vi } from "vitest";
 
 import { PreviouslyResolved } from "./configuration";
 import { ResponseChecksumValidation } from "./constants";
 import { flexibleChecksumsInputMiddleware } from "./flexibleChecksumsInputMiddleware";
 
+vi.mock("@aws-sdk/core");
+
 describe(flexibleChecksumsInputMiddleware.name, () => {
   const mockNext = vi.fn();
   const mockMiddlewareConfig = {
@@ -49,4 +52,18 @@ describe(flexibleChecksumsInputMiddleware.name, () => {
       expect(mockNext).toHaveBeenCalledWith(mockArgs);
     });
   });
+
+  describe("set feature", () => {
+    it.each([
+      ["FLEXIBLE_CHECKSUMS_RES_WHEN_REQUIRED", "c", ResponseChecksumValidation.WHEN_REQUIRED],
+      ["FLEXIBLE_CHECKSUMS_RES_WHEN_SUPPORTED", "b", ResponseChecksumValidation.WHEN_SUPPORTED],
+    ])("logs %s and %s when ResponseChecksumValidation=%s", async (feature, value, responseChecksumValidation) => {
+      const mockConfig = {
+        responseChecksumValidation: () => Promise.resolve(responseChecksumValidation),
+      } as PreviouslyResolved;
+      const handler = flexibleChecksumsInputMiddleware(mockConfig, mockMiddlewareConfig)(mockNext, {});
+      await handler({ input: {} });
+      expect(setFeature).toHaveBeenCalledWith(expect.anything(), feature, value);
+    });
+  });
 });

packages/middleware-flexible-checksums/src/flexibleChecksumsInputMiddleware.ts

@@ -1,3 +1,4 @@
+import { setFeature } from "@aws-sdk/core";
 import {
   HandlerExecutionContext,
   MetadataBearer,
@@ -49,6 +50,12 @@ export const flexibleChecksumsInputMiddleware =
     const { requestValidationModeMember } = middlewareConfig;
     const responseChecksumValidation = await config.responseChecksumValidation();
 
+    if (responseChecksumValidation === ResponseChecksumValidation.WHEN_REQUIRED) {
+      setFeature(context, "FLEXIBLE_CHECKSUMS_RES_WHEN_REQUIRED", "c");
+    } else {
+      setFeature(context, "FLEXIBLE_CHECKSUMS_RES_WHEN_SUPPORTED", "b");
+    }
+
     if (requestValidationModeMember && responseChecksumValidation === ResponseChecksumValidation.WHEN_SUPPORTED) {
       input[requestValidationModeMember] = "ENABLED";
     }

packages/middleware-flexible-checksums/src/flexibleChecksumsMiddleware.spec.ts

@@ -1,3 +1,4 @@
+import { setFeature } from "@aws-sdk/core";
 import { HttpRequest } from "@smithy/protocol-http";
 import { BuildHandlerArguments } from "@smithy/types";
 import { afterEach, beforeEach, describe, expect, test as it, vi } from "vitest";
@@ -12,6 +13,7 @@ import { isStreaming } from "./isStreaming";
 import { selectChecksumAlgorithmFunction } from "./selectChecksumAlgorithmFunction";
 import { stringHasher } from "./stringHasher";
 
+vi.mock("@aws-sdk/core");
 vi.mock("@smithy/protocol-http");
 vi.mock("./getChecksumAlgorithmForRequest");
 vi.mock("./getChecksumLocationName");
@@ -171,4 +173,18 @@ describe(flexibleChecksumsMiddleware.name, () => {
       expect(mockBase64Encoder).toHaveBeenCalledWith(mockRawChecksum);
     });
   });
+
+  describe("set feature", () => {
+    it.each([
+      ["FLEXIBLE_CHECKSUMS_REQ_WHEN_REQUIRED", "a", RequestChecksumCalculation.WHEN_REQUIRED],
+      ["FLEXIBLE_CHECKSUMS_REQ_WHEN_SUPPORTED", "Z", RequestChecksumCalculation.WHEN_SUPPORTED],
+    ])("logs %s and %s when RequestChecksumCalculation=%s", async (feature, value, requestChecksumCalculation) => {
+      const mockConfig = {
+        requestChecksumCalculation: () => Promise.resolve(requestChecksumCalculation),
+      } as PreviouslyResolved;
+      const handler = flexibleChecksumsMiddleware(mockConfig, mockMiddlewareConfig)(mockNext, {});
+      await handler(mockArgs);
+      expect(setFeature).toHaveBeenCalledWith(expect.anything(), feature, value);
+    });
+  });
 });

packages/middleware-flexible-checksums/src/flexibleChecksumsMiddleware.ts

@@ -11,7 +11,7 @@ import {
 } from "@smithy/types";
 
 import { PreviouslyResolved } from "./configuration";
-import { ChecksumAlgorithm } from "./constants";
+import { ChecksumAlgorithm, RequestChecksumCalculation } from "./constants";
 import { getChecksumAlgorithmForRequest } from "./getChecksumAlgorithmForRequest";
 import { getChecksumLocationName } from "./getChecksumLocationName";
 import { hasHeader } from "./hasHeader";
@@ -63,6 +63,12 @@ export const flexibleChecksumsMiddleware =
     const requestChecksumCalculation = await config.requestChecksumCalculation();
     const { input, requestChecksumRequired, requestAlgorithmMember } = middlewareConfig;
 
+    if (requestChecksumCalculation === RequestChecksumCalculation.WHEN_REQUIRED) {
+      setFeature(context, "FLEXIBLE_CHECKSUMS_REQ_WHEN_REQUIRED", "a");
+    } else {
+      setFeature(context, "FLEXIBLE_CHECKSUMS_REQ_WHEN_SUPPORTED", "Z");
+    }
+
     const checksumAlgorithm = getChecksumAlgorithmForRequest(
       input,
       {