Skip to content

Commit dfd16d6

Browse files
authored
chore(eventstream-handler-node): set autoDestroy in EventSigningStream (#3774)
1 parent f1ce95e commit dfd16d6

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

packages/eventstream-handler-node/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
"devDependencies": {
2727
"@aws-sdk/util-utf8-node": "*",
2828
"@tsconfig/recommended": "1.0.1",
29-
"@types/node": "^10.0.0",
29+
"@types/node": "^12.0.0",
3030
"concurrently": "7.0.0",
3131
"downlevel-dts": "0.7.0",
3232
"rimraf": "3.0.2",

packages/eventstream-handler-node/src/EventSigningStream.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ export class EventSigningStream extends Transform {
1818

1919
constructor(options: EventSigningStreamOptions) {
2020
super({
21+
autoDestroy: true,
2122
readableObjectMode: true,
2223
writableObjectMode: true,
2324
...options,
@@ -26,15 +27,6 @@ export class EventSigningStream extends Transform {
2627
this.priorSignature = options.priorSignature;
2728
this.eventSigner = options.eventSigner;
2829
this.eventStreamCodec = options.eventStreamCodec;
29-
30-
//TODO: use 'autoDestroy' when targeting Node 11
31-
//reference: https://nodejs.org/dist/latest-v13.x/docs/api/stream.html#stream_new_stream_readable_options
32-
this.on("error", () => {
33-
this.destroy();
34-
});
35-
this.on("end", () => {
36-
this.destroy();
37-
});
3830
}
3931

4032
async _transform(chunk: Uint8Array, encoding: string, callback: TransformCallback): Promise<void> {

0 commit comments

Comments
 (0)