test(client-s3): validate response structure

Author: smilkuri

clients/client-s3/test/e2e/S3.browser.e2e.spec.ts

@@ -1,4 +1,4 @@
-import type { S3, SelectObjectContentEventStream, waitUntilObjectExists } from "@aws-sdk/client-s3";
+import type { S3, waitUntilObjectExists } from "@aws-sdk/client-s3";
 import { fromNodeProviderChain } from "@aws-sdk/credential-providers";
 import { FetchHttpHandler } from "@smithy/fetch-http-handler";
 import { Browser } from "happy-dom";

clients/client-s3/test/e2e/S3.e2e.spec.ts

@@ -1,6 +1,6 @@
 import "@aws-sdk/signature-v4-crt";
 
-import { ChecksumAlgorithm, S3, SelectObjectContentEventStream } from "@aws-sdk/client-s3";
+import { ChecksumAlgorithm, S3 } from "@aws-sdk/client-s3";
 import { afterAll, afterEach, beforeAll, describe, expect, test as it } from "vitest";
 
 import { getIntegTestResources } from "../../../../tests/e2e/get-integ-test-resources";

clients/client-s3/test/integ/s3-selectObjectContent.integ.spec.ts

@@ -1,4 +1,5 @@
 import { S3 } from "@aws-sdk/client-s3";
+import { HttpResponse } from "@smithy/protocol-http";
 import { describe, expect, test as it } from "vitest";
 
 import { requireRequestsFrom } from "../../../../private/aws-util-test/src";
@@ -12,24 +13,31 @@ describe("selectObjectContent", () => {
   it("should make correct request", async () => {
     const client = new S3({ region: "us-west-2", credentials });
 
-    requireRequestsFrom(client).toMatch({
-      hostname: /aws-sdk-js-integ-test-bucket\.s3\.us-west-2\.amazonaws\.com/,
-      method: "POST",
-      path: "/test-key",
-      headers: {
-        authorization: /AWS4-HMAC-SHA256 Credential/,
-        "content-type": "application/xml",
-        "x-amz-content-sha256": /./,
-      },
-      body(xmlBody) {
-        expect(xmlBody).toContain(
-          "<Expression>SELECT user_name FROM S3Object WHERE cast(age as int) &gt; 20</Expression>"
-        );
-        expect(xmlBody).toContain("<ExpressionType>SQL</ExpressionType>");
-      },
-    });
+    requireRequestsFrom(client)
+      .toMatch({
+        hostname: /aws-sdk-js-integ-test-bucket\.s3\.us-west-2\.amazonaws\.com/,
+        method: "POST",
+        path: "/test-key",
+        headers: {
+          authorization: /AWS4-HMAC-SHA256 Credential/,
+          "content-type": "application/xml",
+          "x-amz-content-sha256": /./,
+        },
+        body(xmlBody) {
+          expect(xmlBody).toContain(
+            "<Expression>SELECT user_name FROM S3Object WHERE cast(age as int) &gt; 20</Expression>"
+          );
+          expect(xmlBody).toContain("<ExpressionType>SQL</ExpressionType>");
+        },
+      })
+      .respondWith(
+        new HttpResponse({
+          statusCode: 200,
+          body: " ",
+        })
+      );
 
-    await client.selectObjectContent({
+    const response = await client.selectObjectContent({
       Bucket: "aws-sdk-js-integ-test-bucket",
       Key: "test-key",
       ExpressionType: "SQL",
@@ -47,5 +55,9 @@ describe("selectObjectContent", () => {
     });
 
     expect.hasAssertions();
+    expect(response).toHaveProperty("$metadata");
+    expect(response.$metadata.httpStatusCode).toBe(200);
+    expect(response).toHaveProperty("Payload");
+    expect(response.Payload).toBeDefined();
   });
 });