Breaking change in client-bedrock-runtime

[mrickard]

Checkboxes for prior research

• I've gone through Developer Guide and API reference
• I've checked AWS Forums and StackOverflow.
• I've searched for previous similar issues and didn't find any solution.

Describe the bug

New Relic Node Agent team here. This commit from April 28 mentions adding http2 support to client-bedrock-runtime, but instead replaces the NodeHttpHandler with the NodeHttp2Handler.

Has the client-bedrock-runtime library deprecated the NodeHttpHandler, intending to standardize on http2 for future releases? Or is the removal of http support accidental?

Regression Issue

• Select this option if this issue appears to be a regression.

SDK version number

3.798.0

Which JavaScript Runtime is this issue in?

Node.js

Details of the browser/Node.js/ReactNative version

v22.0.0

Reproduction Steps

New Relic's versioned tests of different libraries run at regular intervals. The versioned test for client-bedrock-runtime is here, and began failing with the release of aws-sdk v3.798.0, as http response headers are undefined.

We can see in this commit that NodeHttpHandler was replaced with NodeHttp2Handler. That change causes the error.

Observed Behavior

The root issue is the switch from NodeHttpHandler to NodeHttp2Handler, so our agent's attempt to parse the response headers results in repeated errors like this: error: "Cannot read properties of undefined (reading 'headers')"

Expected Behavior

Expected behavior: client-bedrock-runtime supports http 1.1 chat completion responses, and not only http2.

Possible Solution

client-bedrock-runtime could support both http 1.1 and http2, instead of switching to http2 to the exclusion of http 1.1.

Additional Information/Context

No response

[kuhe]

Expected behavior: client-bedrock-runtime supports http 1.1 chat completion responses, and not only http2.

The service model change should only affect the default handler, and you can still use the previous requestHandler for HTTP1.1.

import { NodeHttpHandler, NodeHttp2Handler } from "@smithy/node-http-handler";

new BedrockRuntime({
  requestHandler: new NodeHttpHandler({}),
  // requestHandler: new NodeHttp2Handler({}),
});

Since headers are an internal detail and not part of the API contract, could you change the header check to be conditional on usage of the HTTP1.1 handler?

[kuhe]

Related issue in node-newrelic newrelic/node-newrelic#3060

[mrickard]

@kuhe Our agent doesn't import the NodeHttpHandlers directly. Our expectation has been that a Bedrock response will have metadata and headers properties, as outlined here. Given that headers aren't part of the API contract, is there a different method we should be using instead?

[kuhe]

The use of http2 doesn't prevent a response from having headers or metadata.

In a call to the SDK operation BedrockRuntime::invokeModel, the response headers are present in the same place as usual. That is, they can be read by middleware during the inbound stage of any middleware.

const client = new BedrockRuntime();

client.middlewareStack.add((next) => async (args) => {
  // outbound stage
  const result = await next(args);
  // inbound stage
  const { response } = result;
  console.log("headers", response?.headers ?? {});
  return result;
});

const output = await client.invokeModel({ /* ... */ });
console.log("metadata", output.$metadata);

So then, what operations are you not seeing headers for, and how are you reading headers?