Skip to content

Conversation

@batzz-00
Copy link
Contributor

@batzz-00 batzz-00 commented Jun 5, 2024

Issue

Issue number, if available, prefixed with "#"

Description

What does this implement/fix? Explain your changes.
The documentation for the credentials option would lead you to think an explicit undefined or omitting the option would use the default credential provider, the current implementation only works for the latter scenario. Explicitly passing undefined uses the default provider in v2.

In the scenario that a user provides credentials: undefined in the config object, because it is spread at the end of the object, the defaulted properties are overwritten

Testing

How was this change tested?

Additional context

Add any other context about the PR here.

Checklist

  • If you wrote E2E tests, are they resilient to concurrent I/O?
  • If adding new public functions, did you add the @public tag and enable doc generation on the package?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@batzz-00 batzz-00 requested a review from a team as a code owner June 5, 2024 18:58
@kuhe kuhe changed the title don't overwrite defaulted config fix(rds-signer): don't overwrite default config with undefined values Jun 27, 2025
@kuhe kuhe merged commit c366275 into aws:main Jun 27, 2025
3 of 4 checks passed
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants