Skip to content

test(middleware-flexible-checksums): update instructions for MD5 fallback #7002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 10, 2025
Merged

test(middleware-flexible-checksums): update instructions for MD5 fallback #7002

merged 3 commits into from
Apr 10, 2025

Conversation

@siddsriv
Copy link
Contributor

@siddsriv siddsriv commented Apr 9, 2025 •
edited
Loading

Description

  • make middleware ordering relative to flexibleChecksumsMiddleware
  • update instructions regarding the DeleteObjects command

Testing

E2E test to confirm removal and addition of relevant headers (uncomment logging in the test file to confirm the headers)

[DeleteObjectsCommand] Headers before MD5 middleware: {
  "content-type": "application/xml",
  "content-length": "145",
  "Expect": "100-continue",
  "x-amz-sdk-checksum-algorithm": "CRC32",
  "x-amz-checksum-crc32": "<signature>"
}
[DeleteObjectsCommand] Removing header: x-amz-sdk-checksum-algorithm
[DeleteObjectsCommand] Removing header: x-amz-checksum-crc32
[DeleteObjectsCommand] Added Content-MD5: <signature>
[DeleteObjectsCommand] Headers after MD5 middleware: {
  "content-type": "application/xml",
  "content-length": "145",
  "Expect": "100-continue",
  "Content-MD5": "<signature>"
}

 ✓ src/middleware-flexible-checksums.e2e.spec.ts (9) 7738ms
 ✓ src/middleware-md5-fallback.e2e.spec.ts (2) 4583ms

 Test Files  2 passed (2)
      Tests  11 passed (11)
   Start at  16:44:45
   Duration  8.44s (transform 259ms, setup 0ms, collect 785ms, tests 12.32s, environment 0ms, prepare 170ms)

Checklist

  • If you wrote E2E tests, are they resilient to concurrent I/O?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@siddsriv siddsriv requested a review from a team as a code owner April 9, 2025 16:55
@kuhe kuhe changed the title chore(middleware-flexible-checksums): update instructions for MD5 fallback test(middleware-flexible-checksums): update instructions for MD5 fallback Apr 9, 2025
@siddsriv siddsriv merged commit d150104 into aws:main Apr 10, 2025
4 checks passed
@siddsriv siddsriv deleted the md5-fallback-update branch April 10, 2025 14:52
@github-actions
Copy link

github-actions bot commented Apr 25, 2025

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kuhe kuhe kuhe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@siddsriv @kuhe