Skip to content

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Oct 6, 2025

Issue

internal JS-6272

Description

see smithy-lang/smithy-typescript#1713

uses rollup instead of esbuild to generate the dist-cjs distribution

Testing

CI should suffice - this change affects cjs build artifacts, which are what run in Node.js, i.e. most of our automated test suite.

Checklist

  • If the PR is a feature, add integration tests (*.integ.spec.ts).
  • If you wrote E2E tests, are they resilient to concurrent I/O?
  • If adding new public functions, did you add the @public tag and enable doc generation on the package?

@kuhe kuhe requested a review from a team as a code owner October 6, 2025 18:49
@kuhe kuhe marked this pull request as draft October 7, 2025 14:32
@kuhe kuhe marked this pull request as ready for review October 7, 2025 14:32
@kuhe kuhe force-pushed the chore/build branch 2 times, most recently from dc1b11c to 1858995 Compare October 7, 2025 18:27
@kuhe kuhe merged commit 7642359 into main Oct 8, 2025
7 checks passed
@kuhe kuhe deleted the chore/build branch October 8, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants