fix: wait for process to complete before reading exit code

0marperez · 0marperez · commit 026b363de790 · 2025-03-04T15:03:02.000-05:00
diff --git a/tests/codegen/smoke-tests/src/test/kotlin/aws/sdk/kotlin/test/codegen/smoketest/SmokeTestE2ETest.kt b/tests/codegen/smoke-tests/src/test/kotlin/aws/sdk/kotlin/test/codegen/smoketest/SmokeTestE2ETest.kt
@@ -79,9 +79,10 @@ private fun runSmokeTests(
 
     val process = processBuilder.start()
     val output = process.inputStream.bufferedReader().use { it.readText() }
+    val exitCode = process.waitFor()
 
     if (expectingFailure) {
-        assertTrue(process.exitValue() != 0)
+        assertTrue(exitCode != 0)
     }
 
     return output

Original file line number	Diff line number	Diff line change
`@@ -79,9 +79,10 @@ private fun runSmokeTests(`
`79`	`79`
`80`	`80`	`val process = processBuilder.start()`
`81`	`81`	`val output = process.inputStream.bufferedReader().use { it.readText() }`
	`82`	`+ val exitCode = process.waitFor()`
`82`	`83`
`83`	`84`	`if (expectingFailure) {`
`84`		`- assertTrue(process.exitValue() != 0)`
	`85`	`+ assertTrue(exitCode != 0)`
`85`	`86`	`}`
`86`	`87`
`87`	`88`	`return output`