Skip to content

Commit 1119282

Browse files
committed
pr feedbacks
1 parent 4d29f8b commit 1119282

File tree

2 files changed

+22
-1
lines changed

2 files changed

+22
-1
lines changed

codegen/aws-sdk-codegen/src/main/kotlin/aws/sdk/kotlin/codegen/customization/EnvironmentBearerTokenCustomization.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ class EnvironmentBearerTokenCustomization : KotlinIntegration {
4545

4646
override fun writeAdditionalFiles(ctx: CodegenContext, delegator: KotlinDelegator) {
4747
val serviceShape = ctx.model.expectShape<ServiceShape>(ctx.settings.service)
48-
val serviceName = ctx.symbolProvider.toSymbol(serviceShape).name.removeSuffix("Client")
48+
val serviceName = clientName(ctx.settings.sdkId)
4949
val packageName = ctx.settings.pkg.name
5050

5151
delegator.useFileWriter(

codegen/aws-sdk-codegen/src/test/kotlin/aws/sdk/kotlin/codegen/customization/EnvironmentBearerTokenCustomizationTest.kt

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,20 @@ class EnvironmentBearerTokenCustomizationTest {
2424
}
2525
""".trimIndent().toSmithyModel()
2626

27+
private val bedrockRuntimeModel = """
28+
namespace com.test
29+
use aws.auth#sigv4
30+
use aws.api#service
31+
use smithy.api#httpBearerAuth
32+
33+
@sigv4(name: "bedrock")
34+
@httpBearerAuth
35+
@service(sdkId: "Bedrock Runtime")
36+
service BedrockRuntime {
37+
version: "1.0.0"
38+
}
39+
""".trimIndent().toSmithyModel()
40+
2741
private val nonBedrockModel = """
2842
namespace com.test
2943
use aws.auth#sigv4
@@ -70,6 +84,13 @@ class EnvironmentBearerTokenCustomizationTest {
7084
}
7185
}
7286

87+
fun `test customization enabled for bedrock sigv4 signing name with different sdkId`() {
88+
assertTrue {
89+
EnvironmentBearerTokenCustomization()
90+
.enabledForService(bedrockRuntimeModel, bedrockRuntimeModel.defaultSettings())
91+
}
92+
}
93+
7394
@Test
7495
fun `test customization not enabled for non-bedrock sigv4 signing name`() {
7596
assertFalse {

0 commit comments

Comments
 (0)