Skip to content

Commit 1c391b8

Browse files
committed
Refactor based on upstream changes, simplify parameter addition, change add to put
1 parent cc6961f commit 1c391b8

File tree

3 files changed

+4
-13
lines changed

3 files changed

+4
-13
lines changed

services/dsql/common/src/aws/sdk/kotlin/services/dsql/DsqlAuthTokenGenerator.kt

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public class DsqlAuthTokenGenerator(
2828
public val signer: AwsSigner = DefaultAwsSigner,
2929
public val clock: Clock = Clock.System,
3030
) {
31-
private val generator = AuthTokenGenerator("dsql", credentialsProvider, credentialsRefreshBuffer, signer, clock)
31+
private val generator = AuthTokenGenerator("dsql", credentialsProvider, signer, clock)
3232

3333
/**
3434
* Generates an auth token for the DbConnect action.
@@ -38,11 +38,7 @@ public class DsqlAuthTokenGenerator(
3838
*/
3939
public suspend fun generateDbConnectAuthToken(endpoint: Url, region: String, expiration: Duration = 900.seconds): String {
4040
val dbConnectEndpoint = endpoint.toBuilder().apply {
41-
parameters.apply {
42-
decodedParameters {
43-
add("Action", "DbConnect")
44-
}
45-
}
41+
parameters.decodedParameters.put("Action", "DbConnect")
4642
}.build()
4743

4844
return generator.generateAuthToken(dbConnectEndpoint, region, expiration)
@@ -56,11 +52,7 @@ public class DsqlAuthTokenGenerator(
5652
*/
5753
public suspend fun generateDbConnectAdminAuthToken(endpoint: Url, region: String, expiration: Duration = 900.seconds): String {
5854
val dbConnectAdminEndpoint = endpoint.toBuilder().apply {
59-
parameters.apply {
60-
decodedParameters {
61-
add("Action", "DbConnectAdmin")
62-
}
63-
}
55+
parameters.decodedParameters.put("Action", "DbConnectAdmin")
6456
}.build()
6557

6658
return generator.generateAuthToken(dbConnectAdminEndpoint, region, expiration)

services/rds/common/src/aws/sdk/kotlin/services/rds/RdsAuthTokenGenerator.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public class RdsAuthTokenGenerator(
2929
public val signer: AwsSigner = DefaultAwsSigner,
3030
public val clock: Clock = Clock.System,
3131
) {
32-
private val generator = AuthTokenGenerator("rds-db", credentialsProvider, credentialsRefreshBuffer, signer, clock)
32+
private val generator = AuthTokenGenerator("rds-db", credentialsProvider, signer, clock)
3333

3434
/**
3535
* Generates an auth token for the `connect` action.

services/rds/common/test/RdsAuthTokenGeneratorTest.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ class RdsAuthTokenGeneratorTest {
2020
@Test
2121
fun testGenerateAuthToken() = runTest {
2222
val clock = ManualClock(Instant.fromEpochSeconds(1724716800))
23-
println(clock.now())
2423

2524
val credentials = Credentials("akid", "secret")
2625
val credentialsProvider = StaticCredentialsProvider(credentials)

0 commit comments

Comments
 (0)