address PR reviews

Author: xinsong-cui

.changes/05ac561b-963f-4953-bb4f-1fc19fc1207c.json

@@ -1,7 +1,7 @@
 {
     "id": "05ac561b-963f-4953-bb4f-1fc19fc1207c",
     "type": "feature",
-    "description": "add regionProvider property to client config",
+    "description": "Add `regionProvider` property to client config",
     "issues": [
         "awslabs/aws-sdk-kotlin#1478"
     ]

codegen/aws-sdk-codegen/src/main/kotlin/aws/sdk/kotlin/codegen/AwsKotlinDependency.kt

@@ -42,7 +42,6 @@ object AwsKotlinDependency {
     val AWS_CONFIG = KotlinDependency(GradleConfiguration.Api, AWS_CLIENT_RT_ROOT_NS, AWS_CLIENT_RT_GROUP, "aws-config", AWS_CLIENT_RT_VERSION)
     val AWS_ENDPOINT = KotlinDependency(GradleConfiguration.Api, "$AWS_CLIENT_RT_ROOT_NS.endpoint", AWS_CLIENT_RT_GROUP, "aws-endpoint", AWS_CLIENT_RT_VERSION)
     val AWS_HTTP = KotlinDependency(GradleConfiguration.Implementation, "$AWS_CLIENT_RT_ROOT_NS.http", AWS_CLIENT_RT_GROUP, "aws-http", AWS_CLIENT_RT_VERSION)
-    val KOTLINX_COROUTINES = KotlinDependency(GradleConfiguration.Implementation, "kotlinx.coroutines", KOTLINX_COROUTINES_GROUP, "kotlinx-coroutines-core", KOTLINX_COROUTINES_VERSION)
 }
 
 // remap aws-sdk-kotlin dependencies to project notation

codegen/aws-sdk-codegen/src/main/kotlin/aws/sdk/kotlin/codegen/AwsRuntimeTypes.kt

@@ -18,10 +18,6 @@ object AwsRuntimeTypes {
         val ClientException = symbol("ClientException")
     }
 
-    object Coroutines : RuntimeTypePackage(AwsKotlinDependency.KOTLINX_COROUTINES) {
-        val runBlocking = symbol("runBlocking")
-    }
-
     object Endpoint : RuntimeTypePackage(AwsKotlinDependency.AWS_ENDPOINT) {
         object Functions : RuntimeTypePackage(AwsKotlinDependency.AWS_ENDPOINT, "functions") {
             val partitionFn = symbol("partition")

codegen/aws-sdk-codegen/src/main/kotlin/aws/sdk/kotlin/codegen/AwsServiceConfigIntegration.kt

@@ -35,10 +35,10 @@ class AwsServiceConfigIntegration : KotlinIntegration {
             propertyType = ConfigPropertyType.Custom(
                 render = { prop, writer ->
                     writer.write(
-                        "override val #1L: #2T? = builder.#1L ?: #3T{ builder.regionProvider?.getRegion() ?: #4T() }",
+                        "override val #1L: #2T? = builder.#1L ?: #3T { builder.regionProvider?.getRegion() ?: #4T() }",
                         prop.propertyName,
                         prop.symbol,
-                        AwsRuntimeTypes.Coroutines.runBlocking,
+                        KotlinTypes.Coroutines.runBlocking,
                         AwsRuntimeTypes.Config.Region.resolveRegion,
                     )
                 },

tests/codegen/event-stream/build.gradle.kts

@@ -94,6 +94,9 @@ tasks.generateSmithyProjections {
         // ensure the generated tests use the same version of the runtime as the aws aws-runtime
         val smithyKotlinRuntimeVersion = libs.versions.smithy.kotlin.runtime.version.get()
         System.setProperty("smithy.kotlin.codegen.clientRuntimeVersion", smithyKotlinRuntimeVersion)
+
+        val smithyKotlinCoroutinesVersion = libs.versions.coroutines.version.get()
+        System.setProperty("smithy.kotlin.codegen.kotlinCoroutinesVersion", smithyKotlinCoroutinesVersion)
     }
 }