refactor: relocate crt engine to smithy-kotlin (#549)

Author: aajtodd

aws-runtime/aws-config/build.gradle.kts

@@ -24,7 +24,7 @@ kotlin {
                 implementation("aws.smithy.kotlin:logging:$smithyKotlinVersion")
                 implementation("aws.smithy.kotlin:http:$smithyKotlinVersion")
                 implementation("aws.smithy.kotlin:utils:$smithyKotlinVersion")
-                implementation(project(":aws-runtime:http-client-engine-crt"))
+                implementation("aws.smithy.kotlin:http-client-engine-crt:$smithyKotlinVersion")
                 implementation(project(":aws-runtime:aws-http"))
 
                 // parsing common JSON credentials responses

aws-runtime/aws-config/common/src/aws/sdk/kotlin/runtime/auth/credentials/DefaultChainCredentialsProvider.kt

@@ -7,8 +7,8 @@ package aws.sdk.kotlin.runtime.auth.credentials
 
 import aws.sdk.kotlin.runtime.config.AwsSdkSetting
 import aws.sdk.kotlin.runtime.config.imds.ImdsClient
-import aws.sdk.kotlin.runtime.http.engine.crt.CrtHttpEngine
 import aws.smithy.kotlin.runtime.http.engine.HttpClientEngine
+import aws.smithy.kotlin.runtime.http.engine.crt.CrtHttpEngine
 import aws.smithy.kotlin.runtime.io.Closeable
 import aws.smithy.kotlin.runtime.util.Platform
 import aws.smithy.kotlin.runtime.util.PlatformProvider

aws-runtime/aws-config/common/src/aws/sdk/kotlin/runtime/auth/credentials/EcsCredentialsProvider.kt

@@ -8,11 +8,11 @@ package aws.sdk.kotlin.runtime.auth.credentials
 import aws.sdk.kotlin.runtime.config.AwsSdkSetting
 import aws.sdk.kotlin.runtime.config.AwsSdkSetting.AwsContainerCredentialsRelativeUri
 import aws.sdk.kotlin.runtime.config.resolve
-import aws.sdk.kotlin.runtime.http.engine.crt.CrtHttpEngine
 import aws.smithy.kotlin.runtime.ServiceException
 import aws.smithy.kotlin.runtime.client.ExecutionContext
 import aws.smithy.kotlin.runtime.http.*
 import aws.smithy.kotlin.runtime.http.engine.HttpClientEngine
+import aws.smithy.kotlin.runtime.http.engine.crt.CrtHttpEngine
 import aws.smithy.kotlin.runtime.http.middleware.ResolveEndpoint
 import aws.smithy.kotlin.runtime.http.middleware.Retry
 import aws.smithy.kotlin.runtime.http.operation.*

aws-runtime/aws-config/common/src/aws/sdk/kotlin/runtime/config/imds/ImdsClient.kt

@@ -8,13 +8,13 @@ package aws.sdk.kotlin.runtime.config.imds
 import aws.sdk.kotlin.runtime.AwsServiceException
 import aws.sdk.kotlin.runtime.http.ApiMetadata
 import aws.sdk.kotlin.runtime.http.AwsUserAgentMetadata
-import aws.sdk.kotlin.runtime.http.engine.crt.CrtHttpEngine
 import aws.sdk.kotlin.runtime.http.middleware.UserAgent
 import aws.smithy.kotlin.runtime.client.ExecutionContext
 import aws.smithy.kotlin.runtime.client.SdkClientOption
 import aws.smithy.kotlin.runtime.client.SdkLogMode
 import aws.smithy.kotlin.runtime.http.*
 import aws.smithy.kotlin.runtime.http.engine.HttpClientEngine
+import aws.smithy.kotlin.runtime.http.engine.crt.CrtHttpEngine
 import aws.smithy.kotlin.runtime.http.middleware.ResolveEndpoint
 import aws.smithy.kotlin.runtime.http.middleware.Retry
 import aws.smithy.kotlin.runtime.http.operation.*

aws-runtime/aws-signing/build.gradle.kts

@@ -18,14 +18,15 @@ kotlin {
         commonMain {
             dependencies {
                 val crtKotlinVersion: String by project
+                api(project(":aws-runtime:aws-core"))
                 // signing config uses CredentialsProvider/Credentials
                 api(project(":aws-runtime:aws-types"))
                 // presigner config exposes endpoint resolver
                 api(project(":aws-runtime:aws-endpoint"))
                 // sign() API takes HttpRequest
                 api("aws.smithy.kotlin:http:$smithyKotlinVersion")
 
-                implementation(project(":aws-runtime:crt-util"))
+                implementation("aws.smithy.kotlin:crt-util:$smithyKotlinVersion")
                 implementation("aws.sdk.kotlin.crt:aws-crt-kotlin:$crtKotlinVersion")
                 implementation("aws.smithy.kotlin:logging:$smithyKotlinVersion")
             }

aws-runtime/aws-signing/common/src/aws/sdk/kotlin/runtime/auth/signing/AwsSigV4SigningMiddleware.kt

@@ -9,10 +9,10 @@ import aws.sdk.kotlin.crt.auth.signing.AwsSignedBodyValue
 import aws.sdk.kotlin.crt.auth.signing.AwsSigner
 import aws.sdk.kotlin.runtime.InternalSdkApi
 import aws.sdk.kotlin.runtime.auth.credentials.CredentialsProvider
-import aws.sdk.kotlin.runtime.crt.toSignableCrtRequest
-import aws.sdk.kotlin.runtime.crt.update
 import aws.sdk.kotlin.runtime.execution.AuthAttributes
 import aws.smithy.kotlin.runtime.client.ExecutionContext
+import aws.smithy.kotlin.runtime.crt.toSignableCrtRequest
+import aws.smithy.kotlin.runtime.crt.update
 import aws.smithy.kotlin.runtime.http.*
 import aws.smithy.kotlin.runtime.http.operation.*
 import aws.smithy.kotlin.runtime.util.get

aws-runtime/aws-signing/common/src/aws/sdk/kotlin/runtime/auth/signing/AwsSigning.kt

@@ -7,8 +7,8 @@ package aws.sdk.kotlin.runtime.auth.signing
 
 import aws.sdk.kotlin.crt.auth.signing.AwsSigner
 import aws.sdk.kotlin.runtime.InternalSdkApi
-import aws.sdk.kotlin.runtime.crt.toSignableCrtRequest
-import aws.sdk.kotlin.runtime.crt.update
+import aws.smithy.kotlin.runtime.crt.toSignableCrtRequest
+import aws.smithy.kotlin.runtime.crt.update
 import aws.smithy.kotlin.runtime.http.request.HttpRequest
 import aws.smithy.kotlin.runtime.http.request.toBuilder
 

aws-runtime/aws-signing/common/src/aws/sdk/kotlin/runtime/auth/signing/Presigner.kt

@@ -12,11 +12,11 @@ import aws.sdk.kotlin.crt.auth.signing.AwsSigner
 import aws.sdk.kotlin.crt.auth.signing.AwsSigningConfig
 import aws.sdk.kotlin.runtime.InternalSdkApi
 import aws.sdk.kotlin.runtime.auth.credentials.CredentialsProvider
-import aws.sdk.kotlin.runtime.crt.path
-import aws.sdk.kotlin.runtime.crt.queryParameters
-import aws.sdk.kotlin.runtime.crt.toCrtHeaders
-import aws.sdk.kotlin.runtime.crt.toSdkHeaders
 import aws.sdk.kotlin.runtime.endpoint.AwsEndpointResolver
+import aws.smithy.kotlin.runtime.crt.path
+import aws.smithy.kotlin.runtime.crt.queryParameters
+import aws.smithy.kotlin.runtime.crt.toCrtHeaders
+import aws.smithy.kotlin.runtime.crt.toSdkHeaders
 import aws.smithy.kotlin.runtime.http.Headers
 import aws.smithy.kotlin.runtime.http.HttpBody
 import aws.smithy.kotlin.runtime.http.HttpMethod

aws-runtime/build.gradle.kts

@@ -86,12 +86,6 @@ subprojects {
     }
 }
 
-// FIXME - resolves build deadlock with aws-core when using composite builds
-val topLevelModule = "crt-util"
-subprojects.filter { it.name != topLevelModule }.forEach { proj ->
-    proj.tasks.findByName("generatePomFileForJvmPublication")?.dependsOn(":aws-runtime:$topLevelModule:generatePomFileForJvmPublication")
-}
-
 task<org.jetbrains.kotlin.gradle.testing.internal.KotlinTestReport>("rootAllTest"){
     destinationDir = File(project.buildDir, "reports/tests/rootAllTest")
     val rootAllTest = this