Skip to content

Commit 3946d12

Browse files
committed
address pr review
1 parent a18975c commit 3946d12

File tree

5 files changed

+3
-112
lines changed

5 files changed

+3
-112
lines changed

aws-runtime/aws-config/api/aws-config.api

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -533,7 +533,7 @@ public final class aws/sdk/kotlin/runtime/config/useragent/ResolveUserAgentKt {
533533
public static synthetic fun resolveUserAgentAppId$default (Laws/smithy/kotlin/runtime/util/PlatformProvider;Laws/smithy/kotlin/runtime/util/LazyAsyncValue;Lkotlin/coroutines/Continuation;ILjava/lang/Object;)Ljava/lang/Object;
534534
}
535535

536-
public final class aws/sdk/kotlin/runtime/region/DefaultRegionProviderChain : aws/sdk/kotlin/runtime/region/RegionProviderChain, aws/smithy/kotlin/runtime/client/region/RegionProvider, java/io/Closeable {
536+
public final class aws/sdk/kotlin/runtime/region/DefaultRegionProviderChain : aws/smithy/kotlin/runtime/client/region/RegionProviderChain, aws/smithy/kotlin/runtime/client/region/RegionProvider, java/io/Closeable {
537537
public fun <init> ()V
538538
public fun <init> (Laws/smithy/kotlin/runtime/util/PlatformProvider;Lkotlin/Lazy;Laws/smithy/kotlin/runtime/util/LazyAsyncValue;)V
539539
public synthetic fun <init> (Laws/smithy/kotlin/runtime/util/PlatformProvider;Lkotlin/Lazy;Laws/smithy/kotlin/runtime/util/LazyAsyncValue;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
@@ -570,14 +570,6 @@ public final class aws/sdk/kotlin/runtime/region/ProfileRegionProvider : aws/smi
570570
public fun getRegion (Lkotlin/coroutines/Continuation;)Ljava/lang/Object;
571571
}
572572

573-
public class aws/sdk/kotlin/runtime/region/RegionProviderChain : aws/smithy/kotlin/runtime/client/region/RegionProvider {
574-
public fun <init> (Ljava/util/List;)V
575-
public fun <init> ([Laws/smithy/kotlin/runtime/client/region/RegionProvider;)V
576-
protected final fun getProviders ()[Laws/smithy/kotlin/runtime/client/region/RegionProvider;
577-
public fun getRegion (Lkotlin/coroutines/Continuation;)Ljava/lang/Object;
578-
public fun toString ()Ljava/lang/String;
579-
}
580-
581573
public final class aws/sdk/kotlin/runtime/region/ResolveRegionKt {
582574
public static final fun resolveRegion (Laws/smithy/kotlin/runtime/util/PlatformProvider;Laws/smithy/kotlin/runtime/util/LazyAsyncValue;Lkotlin/coroutines/Continuation;)Ljava/lang/Object;
583575
public static synthetic fun resolveRegion$default (Laws/smithy/kotlin/runtime/util/PlatformProvider;Laws/smithy/kotlin/runtime/util/LazyAsyncValue;Lkotlin/coroutines/Continuation;ILjava/lang/Object;)Ljava/lang/Object;

aws-runtime/aws-config/common/src/aws/sdk/kotlin/runtime/region/RegionProviderChain.kt

Lines changed: 0 additions & 53 deletions
This file was deleted.

aws-runtime/aws-config/common/test/aws/sdk/kotlin/runtime/region/AwsRegionProviderChainTest.kt

Lines changed: 0 additions & 48 deletions
This file was deleted.

aws-runtime/aws-config/jvm/src/aws/sdk/kotlin/runtime/region/DefaultRegionProviderChainJVM.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ package aws.sdk.kotlin.runtime.region
88
import aws.sdk.kotlin.runtime.config.imds.InstanceMetadataProvider
99
import aws.sdk.kotlin.runtime.config.profile.AwsProfile
1010
import aws.smithy.kotlin.runtime.client.region.RegionProvider
11+
import aws.smithy.kotlin.runtime.client.region.RegionProviderChain
1112
import aws.smithy.kotlin.runtime.io.Closeable
1213
import aws.smithy.kotlin.runtime.util.LazyAsyncValue
1314
import aws.smithy.kotlin.runtime.util.PlatformProvider

codegen/aws-sdk-codegen/src/main/kotlin/aws/sdk/kotlin/codegen/AwsServiceConfigIntegration.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ class AwsServiceConfigIntegration : KotlinIntegration {
4848
)
4949
},
5050
)
51-
5251
order = -100
5352
}
5453

@@ -77,7 +76,7 @@ class AwsServiceConfigIntegration : KotlinIntegration {
7776
)
7877
},
7978
)
80-
order = -100
79+
order = -99 // After RegionProp
8180
}
8281

8382
val UserAgentAppId: ConfigProperty = ConfigProperty {

0 commit comments

Comments
 (0)