fix(rt): plumb client configuration properties (#730)

Author: lauzadis

.changes/c307c127-15ec-4c36-b559-5bbf17465197.json

@@ -0,0 +1,6 @@
+{
+  "id": "c307c127-15ec-4c36-b559-5bbf17465197",
+  "type": "bugfix",
+  "description": "Pass client configuration's httpClientEngine to the CredentialsProvider and region to ProfileCredentialsProvider",
+  "issues": ["#711"]
+}

aws-runtime/aws-config/common/src/aws/sdk/kotlin/runtime/auth/credentials/DefaultChainCredentialsProvider.kt

@@ -35,20 +35,22 @@ import aws.smithy.kotlin.runtime.util.PlatformProvider
  * @param platformProvider The platform API provider
  * @param httpClientEngine the [HttpClientEngine] instance to use to make requests. NOTE: This engine's resources and lifetime
  * are NOT managed by the provider. Caller is responsible for closing.
+ * @param region the region to make credentials requests to.
  * @return the newly-constructed credentials provider
  */
 public class DefaultChainCredentialsProvider constructor(
     private val profileName: String? = null,
     private val platformProvider: PlatformProvider = Platform,
     httpClientEngine: HttpClientEngine? = null,
+    region: String? = null,
 ) : CredentialsProvider, Closeable {
 
     private val manageEngine = httpClientEngine == null
     private val httpClientEngine = httpClientEngine ?: DefaultHttpEngine()
 
     private val chain = CredentialsProviderChain(
         EnvironmentCredentialsProvider(platformProvider::getenv),
-        ProfileCredentialsProvider(profileName = profileName, platformProvider = platformProvider, httpClientEngine = httpClientEngine),
+        ProfileCredentialsProvider(profileName = profileName, platformProvider = platformProvider, httpClientEngine = httpClientEngine, region = region),
         // STS web identity provider can be constructed from either the profile OR 100% from the environment
         StsWebIdentityProvider(platformProvider = platformProvider, httpClientEngine = httpClientEngine),
         EcsCredentialsProvider(platformProvider, httpClientEngine),

codegen/smithy-aws-kotlin-codegen/src/main/kotlin/aws/sdk/kotlin/codegen/AwsServiceConfigIntegration.kt

@@ -25,6 +25,7 @@ class AwsServiceConfigIntegration : KotlinIntegration {
                     AWS region to make requests to
             """.trimIndent()
             propertyType = ClientConfigPropertyType.Required()
+            order = -100
         }
 
         val CredentialsProviderProp: ClientConfigProperty = ClientConfigProperty {
@@ -38,7 +39,7 @@ class AwsServiceConfigIntegration : KotlinIntegration {
 
             propertyType = ClientConfigPropertyType.Custom(render = { prop, writer ->
                 writer.write(
-                    "public val #1L: #2T = builder.#1L?.borrow() ?: #3T()",
+                    "public val #1L: #2T = builder.#1L?.borrow() ?: #3T(httpClientEngine = httpClientEngine, region = region)",
                     prop.propertyName,
                     prop.symbol,
                     AwsRuntimeTypes.Config.Credentials.DefaultChainCredentialsProvider,

codegen/smithy-aws-kotlin-codegen/src/test/kotlin/aws/sdk/kotlin/codegen/AwsServiceConfigIntegrationTest.kt

@@ -43,13 +43,17 @@ class AwsServiceConfigIntegrationTest {
         val contents = writer.toString()
 
         val expectedProps = """
-    public val credentialsProvider: CredentialsProvider = builder.credentialsProvider?.borrow() ?: DefaultChainCredentialsProvider()
-    public val endpointResolver: AwsEndpointResolver = builder.endpointResolver ?: DefaultEndpointResolver()
     public val region: String = requireNotNull(builder.region) { "region is a required configuration property" }
+    public val credentialsProvider: CredentialsProvider = builder.credentialsProvider?.borrow() ?: DefaultChainCredentialsProvider(httpClientEngine = httpClientEngine, region = region)
+    public val endpointResolver: AwsEndpointResolver = builder.endpointResolver ?: DefaultEndpointResolver()
 """
         contents.shouldContainOnlyOnceWithDiff(expectedProps)
 
         val expectedImpl = """
+        /**
+         * AWS region to make requests to
+         */
+        public var region: String? = null
         /**
          * The AWS credentials provider to use for authenticating requests. If not provided a
          * [aws.sdk.kotlin.runtime.auth.credentials.DefaultChainCredentialsProvider] instance will be used.
@@ -62,10 +66,6 @@ class AwsServiceConfigIntegrationTest {
          * resolver is configured automatically. This is an advanced client option.
          */
         public var endpointResolver: AwsEndpointResolver? = null
-        /**
-         * AWS region to make requests to
-         */
-        public var region: String? = null
 """
         contents.shouldContainOnlyOnceWithDiff(expectedImpl)
     }