stop send duration metric if workflow failed

Author: xinsong-cui

.github/actions/workflow-metrics/action.yml

@@ -15,19 +15,19 @@ runs:
       run: |
         # Check if WORKFLOW_START_TIME is set
         if [ -z "$WORKFLOW_START_TIME" ]; then
-        echo "Warning: WORKFLOW_START_TIME not set, skipping metrics upload"
-        exit 0
+          echo "Warning: WORKFLOW_START_TIME not set, skipping metrics upload"
+          exit 0
         fi
         
         duration=$(($(date +%s) - $WORKFLOW_START_TIME))
         
         # Build job name with matrix values
         job_name="${{ github.job }}"
         if [ ! -z "${{ matrix.java-version || '' }}" ]; then
-        job_name="${job_name}(${{ matrix.java-version }})"
+          job_name="${job_name}(${{ matrix.java-version }})"
         fi
         if [ ! -z "${{ matrix.os || '' }}" ]; then
-        job_name="${job_name}(${{ matrix.os }})"
+          job_name="${job_name}(${{ matrix.os }})"
         fi
         
         # Determine success/failure (1 for success, 0 for failure)
@@ -40,25 +40,6 @@ runs:
         aws cloudwatch put-metric-data \
           --namespace "GitHub/Workflows" \
           --metric-data '[{
-            "MetricName": "Duration",
-            "Value": '$duration',
-            "Unit": "Seconds",
-            "Dimensions": [
-              {
-                "Name": "WorkflowName",
-                "Value": "${{ github.workflow }}"
-              },
-              {
-                "Name": "JobName",
-                "Value": "'$job_name'"
-              },
-              {
-                "Name": "Repository", 
-                "Value": "${{ github.repository }}"
-              }
-            ]
-          },
-          {
             "MetricName": "Success",
             "Value": '$success_value',
             "Unit": "Count",
@@ -72,9 +53,33 @@ runs:
                 "Value": "'$job_name'"
               },
               {
-                "Name": "Repository", 
+                "Name": "Repository",
                 "Value": "${{ github.repository }}"
               }
             ]
-          }
-        ]'
+          }]'
+        
+        # Send Duration metric only if workflow successful
+        if [ "$success_value" -eq 1 ]; then
+          aws cloudwatch put-metric-data \
+            --namespace "GitHub/Workflows" \
+            --metric-data '[{
+              "MetricName": "Duration",
+              "Value": '$duration',
+              "Unit": "Seconds",
+              "Dimensions": [
+                {
+                  "Name": "WorkflowName",
+                  "Value": "${{ github.workflow }}"
+                },
+                {
+                  "Name": "JobName",
+                  "Value": "'$job_name'"
+                },
+                {
+                  "Name": "Repository",
+                  "Value": "${{ github.repository }}"
+                }
+              ]
+          }]'
+        fi

.github/workflows/codebuild-ci.yml

@@ -73,6 +73,7 @@ jobs:
             aws codebuild stop-build --id $BUILD_ID
           fi
       - name: Upload metrics
+        if: always()
         uses: ./.github/actions/workflow-metrics
 
   service-check-batch-and-artifact-size-metrics:
@@ -164,6 +165,7 @@ jobs:
             exit 1
           }
       - name: Upload metrics
+        if: always()
         uses: ./.github/actions/workflow-metrics
 
   release-artifact-size-metrics:

.github/workflows/continuous-integration.yml

@@ -51,6 +51,7 @@ jobs:
           ls -lsa
           ./gradlew -Ptest.java.version=${{ matrix.java-version }} jvmTest --stacktrace
       - name: Upload metrics
+        if: always()
         uses: ./aws-sdk-kotlin/.github/actions/workflow-metrics
       - name: Save Test Reports
         if: failure()
@@ -109,6 +110,7 @@ jobs:
           ./gradlew test jvmTest
           ./gradlew testAllProtocols
       - name: Upload metrics
+        if: always()
         uses: ./aws-sdk-kotlin/.github/actions/workflow-metrics
       - name: Save Test Reports
         if: failure()