feedback

Author: 0marperez

build.gradle.kts

@@ -107,9 +107,14 @@ val lintPaths = listOf(
 )
 
 configureLinting(lintPaths)
-configureMinorVersionStrategyRules(lintPaths)
 
-// Set SDK version from gradle.properties as a system property for 'deprecatedApiRule' to use
-tasks.withType<JavaExec> {
-    systemProperty("sdkVersion", findProperty("sdkVersion") ?: throw Exception("sdkVersion not set"))
-}
+/*
+Set SDK version from gradle.properties as a system property for minor versiom strategy ktlint rules
+See: https://github.com/aws/aws-kotlin-repo-tools/pull/132
+ */
+tasks.withType<JavaExec>()
+    .matching { it.name == "verifyMinorVersionBump" }
+    .configureEach {
+        systemProperty("sdkVersion", findProperty("sdkVersion") ?: throw Exception("sdkVersion not set"))
+    }
+configureMinorVersionStrategyRules(lintPaths)

gradle/libs.versions.toml

@@ -4,7 +4,7 @@ ksp-version = "2.2.0-2.0.2" # Keep in sync with kotlin-version
 
 dokka-version = "2.0.0"
 
-aws-kotlin-repo-tools-version = "0.4.49"
+aws-kotlin-repo-tools-version = "8.8.8"
 
 # libs
 coroutines-version = "1.10.2"
@@ -30,7 +30,6 @@ jsoup-version = "1.20.1"
 
 [libraries]
 aws-kotlin-repo-tools-build-support = { module="aws.sdk.kotlin.gradle:build-support", version.ref = "aws-kotlin-repo-tools-version" }
-aws-kotlin-repo-tools-ktlint-rules = { module = "aws.sdk.kotlin.gradle:ktlint-rules", version.ref = "aws-kotlin-repo-tools-version" }
 
 kotlin-gradle-plugin = { module = "org.jetbrains.kotlin:kotlin-gradle-plugin", version.ref = "kotlin-version" }
 kotlin-stdlib = { module = "org.jetbrains.kotlin:kotlin-stdlib", version.ref = "kotlin-version" }

ktlint-rules/minor-version-strategy/build.gradle.kts

@@ -58,7 +58,6 @@ include(":hll")
 include(":hll:hll-codegen")
 include(":hll:hll-mapping-core")
 include(":services")
-include("ktlint-rules:minor-version-strategy")
 
 include(":tests")
 include(":tests:codegen")

ktlint-rules/minor-version-strategy/src/main/kotlin/aws/sdk/kotlin/ktlintrules/minorversionstrategy/MinorVersionStrategyRuleSetProvider.kt

@@ -13,6 +13,13 @@ import aws.smithy.kotlin.runtime.client.config.RequestHttpChecksumConfig
 import aws.smithy.kotlin.runtime.client.config.ResponseHttpChecksumConfig
 import kotlin.test.Test
 
+// TODO: REMOVE THIS WHEN DONE TESTING
+public annotation class DeprecatedUntilVersion(
+    val major: Int,
+    val minor: Int,
+)
+
+@DeprecatedUntilVersion(1, 6)
 class ChecksumBusinessMetricsTest {
     @Test
     fun defaultConfigBusinessMetrics() = runChecksumTest(