fix: changelog and last bit of feedback

Author: 0marperez

.changes/3339e5cc-978c-4941-a975-6c0c82d6426f.json

@@ -0,0 +1,5 @@
+{
+    "id": "3339e5cc-978c-4941-a975-6c0c82d6426f",
+    "type": "feature",
+    "description": "S3 client behavior is updated to always calculate a checksum by default for operations that support it (such as PutObject or UploadPart), or require it (such as DeleteObjects). The checksum algorithm used by default varies by SDK (CRC32 or CRC64, CRC32 for the Kotlin SDK). Checksum calculation behavior can be configured using `when_supported` and `when_required` options - in code using requestChecksumCalculation, in shared config using request_checksum_calculation, or as env variable using AWS_REQUEST_CHECKSUM_CALCULATION. The S3 client attempts to validate response checksums for all S3 API operations that support checksums. However, if the SDK has not implemented the specified checksum algorithm then this validation is skipped. Checksum validation behavior can be configured using `when_supported` and `when_required` options - in code using responseChecksumValidation, in shared config using response_checksum_validation, or as env variable using AWS_RESPONSE_CHECKSUM_VALIDATION."
+}

aws-runtime/aws-config/common/src/aws/sdk/kotlin/runtime/config/profile/AwsProfile.kt

@@ -174,14 +174,30 @@ public val AwsProfile.sigV4aSigningRegionSet: String?
  */
 @InternalSdkApi
 public val AwsProfile.requestChecksumCalculation: RequestHttpChecksumConfig?
-    get() = getOrNull("request_checksum_calculation")?.parseRequestHttpChecksumConfig()
+    get() = getOrNull("request_checksum_calculation")?.run {
+        RequestHttpChecksumConfig
+            .values()
+            .firstOrNull { it.name.equals(this, ignoreCase = true) }
+            ?: throw ConfigurationException(
+                "request_checksum_calculation $this is not supported, should be one of: " +
+                    RequestHttpChecksumConfig.values().joinToString(", ") { it.name.lowercase() },
+            )
+    }
 
 /**
  * Configures response checksum validation
  */
 @InternalSdkApi
 public val AwsProfile.responseChecksumValidation: ResponseHttpChecksumConfig?
-    get() = getOrNull("response_checksum_validation")?.parseResponseHttpChecksumConfig()
+    get() = getOrNull("response_checksum_validation")?.run {
+        ResponseHttpChecksumConfig
+            .values()
+            .firstOrNull { it.name.equals(this, ignoreCase = true) }
+            ?: throw ConfigurationException(
+                "response_checksum_validation $this is not supported, should be one of: " +
+                    ResponseHttpChecksumConfig.values().joinToString(", ") { it.name.lowercase() },
+            )
+    }
 
 /**
  * Parse a config value as a boolean, ignoring case.
@@ -216,32 +232,6 @@ public fun AwsProfile.getLongOrNull(key: String, subKey: String? = null): Long?
         )
     }
 
-/**
- * Parse a string value as [ResponseHttpChecksumConfig]
- */
-private fun String?.parseResponseHttpChecksumConfig(): ResponseHttpChecksumConfig? =
-    when (this?.uppercase()) {
-        null -> null
-        "WHEN_SUPPORTED" -> ResponseHttpChecksumConfig.WHEN_SUPPORTED
-        "WHEN_REQUIRED" -> ResponseHttpChecksumConfig.WHEN_REQUIRED
-        else -> throw ConfigurationException(
-            "'$this' is not a valid value for 'response_checksum_validation'. Valid values are: ${ResponseHttpChecksumConfig.entries}",
-        )
-    }
-
-/**
- * Parse a string value as [RequestHttpChecksumConfig]
- */
-private fun String?.parseRequestHttpChecksumConfig(): RequestHttpChecksumConfig? =
-    when (this?.uppercase()) {
-        null -> null
-        "WHEN_SUPPORTED" -> RequestHttpChecksumConfig.WHEN_SUPPORTED
-        "WHEN_REQUIRED" -> RequestHttpChecksumConfig.WHEN_REQUIRED
-        else -> throw ConfigurationException(
-            "'$this' is not a valid value for 'request_checksum_calculation'. Valid values are: ${RequestHttpChecksumConfig.entries}",
-        )
-    }
-
 internal fun AwsProfile.getUrlOrNull(key: String, subKey: String? = null): Url? =
     getOrNull(key, subKey)?.let {
         try {

aws-runtime/aws-http/api/aws-http.api

@@ -198,7 +198,7 @@ public final class aws/sdk/kotlin/runtime/http/interceptors/BusinessMetricsInter
 
 public final class aws/sdk/kotlin/runtime/http/interceptors/IgnoreCompositeFlexibleChecksumResponseInterceptor : aws/smithy/kotlin/runtime/http/interceptors/FlexibleChecksumsResponseInterceptor {
 	public fun <init> (ZLaws/smithy/kotlin/runtime/client/config/ResponseHttpChecksumConfig;)V
-	public fun ignoreChecksum (Ljava/lang/String;Laws/smithy/kotlin/runtime/telemetry/logging/Logger;)Z
+	public fun ignoreChecksum (Ljava/lang/String;Laws/smithy/kotlin/runtime/client/ProtocolResponseInterceptorContext;)Z
 }
 
 public final class aws/sdk/kotlin/runtime/http/interceptors/UnsupportedSigningAlgorithmInterceptor : aws/smithy/kotlin/runtime/client/Interceptor {

aws-runtime/aws-http/common/src/aws/sdk/kotlin/runtime/http/interceptors/IgnoreCompositeFlexibleChecksumResponseInterceptor.kt

@@ -1,8 +1,11 @@
 package aws.sdk.kotlin.runtime.http.interceptors
 
+import aws.smithy.kotlin.runtime.client.ProtocolResponseInterceptorContext
 import aws.smithy.kotlin.runtime.client.config.ResponseHttpChecksumConfig
 import aws.smithy.kotlin.runtime.http.interceptors.FlexibleChecksumsResponseInterceptor
-import aws.smithy.kotlin.runtime.telemetry.logging.Logger
+import aws.smithy.kotlin.runtime.http.request.HttpRequest
+import aws.smithy.kotlin.runtime.http.response.HttpResponse
+import aws.smithy.kotlin.runtime.telemetry.logging.info
 
 /**
  * Variant of the [FlexibleChecksumsResponseInterceptor] where composite checksums are not validated
@@ -14,9 +17,16 @@ public class IgnoreCompositeFlexibleChecksumResponseInterceptor(
     responseValidationRequired,
     responseChecksumValidation,
 ) {
-    override fun ignoreChecksum(checksum: String, logger: Logger): Boolean =
+    override fun ignoreChecksum(
+        checksum: String,
+        context: ProtocolResponseInterceptorContext<Any, HttpRequest, HttpResponse>,
+    ): Boolean =
         checksum.isCompositeChecksum().also { compositeChecksum ->
-            if (compositeChecksum) logger.info { "Checksum validation was skipped because it was a composite checksum" }
+            if (compositeChecksum) {
+                context.executionContext.coroutineContext.info<IgnoreCompositeFlexibleChecksumResponseInterceptor> {
+                    "Checksum validation was skipped because it was a composite checksum"
+                }
+            }
         }
 }