Skip to content

Commit 70ed729

Browse files
committed
address pr feedbacks
1 parent dc370a6 commit 70ed729

File tree

2 files changed

+34
-40
lines changed

2 files changed

+34
-40
lines changed

services/sqs/e2eTest/src/SqsMd5ChecksumValidationTest.kt

Lines changed: 32 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -117,40 +117,36 @@ class SqsMd5ChecksumValidationTest {
117117

118118
@Test
119119
fun testSendMessage(): Unit = runBlocking {
120-
assertDoesNotThrow {
121-
correctChecksumClient.sendMessage(
122-
SendMessageRequest {
123-
queueUrl = correctChecksumTestQueueUrl
124-
messageBody = TEST_MESSAGE_BODY
125-
messageAttributes = hashMapOf(
126-
TEST_MESSAGE_ATTRIBUTES_NAME to MessageAttributeValue {
127-
dataType = "String"
128-
stringValue = TEST_MESSAGE_ATTRIBUTES_VALUE
129-
},
130-
)
131-
messageSystemAttributes = hashMapOf(
132-
MessageSystemAttributeNameForSends.AwsTraceHeader to MessageSystemAttributeValue {
133-
dataType = "String"
134-
stringValue = TEST_MESSAGE_SYSTEM_ATTRIBUTES_VALUE
135-
},
136-
)
137-
},
138-
)
139-
}
120+
correctChecksumClient.sendMessage(
121+
SendMessageRequest {
122+
queueUrl = correctChecksumTestQueueUrl
123+
messageBody = TEST_MESSAGE_BODY
124+
messageAttributes = hashMapOf(
125+
TEST_MESSAGE_ATTRIBUTES_NAME to MessageAttributeValue {
126+
dataType = "String"
127+
stringValue = TEST_MESSAGE_ATTRIBUTES_VALUE
128+
},
129+
)
130+
messageSystemAttributes = hashMapOf(
131+
MessageSystemAttributeNameForSends.AwsTraceHeader to MessageSystemAttributeValue {
132+
dataType = "String"
133+
stringValue = TEST_MESSAGE_SYSTEM_ATTRIBUTES_VALUE
134+
},
135+
)
136+
},
137+
)
140138
}
141139

142140
@Test
143141
fun testReceiveMessage(): Unit = runBlocking {
144-
assertDoesNotThrow {
145-
correctChecksumClient.receiveMessage(
146-
ReceiveMessageRequest {
147-
queueUrl = correctChecksumTestQueueUrl
148-
maxNumberOfMessages = 1
149-
messageAttributeNames = listOf(TEST_MESSAGE_ATTRIBUTES_NAME)
150-
messageSystemAttributeNames = listOf(MessageSystemAttributeName.AwsTraceHeader)
151-
},
152-
)
153-
}
142+
correctChecksumClient.receiveMessage(
143+
ReceiveMessageRequest {
144+
queueUrl = correctChecksumTestQueueUrl
145+
maxNumberOfMessages = 1
146+
messageAttributeNames = listOf(TEST_MESSAGE_ATTRIBUTES_NAME)
147+
messageSystemAttributeNames = listOf(MessageSystemAttributeName.AwsTraceHeader)
148+
},
149+
)
154150
}
155151

156152
@Test
@@ -159,14 +155,12 @@ class SqsMd5ChecksumValidationTest {
159155
buildSendMessageBatchRequestEntry(batchId)
160156
}
161157

162-
assertDoesNotThrow {
163-
correctChecksumClient.sendMessageBatch(
164-
SendMessageBatchRequest {
165-
queueUrl = correctChecksumTestQueueUrl
166-
this.entries = entries
167-
},
168-
)
169-
}
158+
correctChecksumClient.sendMessageBatch(
159+
SendMessageBatchRequest {
160+
queueUrl = correctChecksumTestQueueUrl
161+
this.entries = entries
162+
},
163+
)
170164
}
171165

172166
@Test

services/sqs/e2eTest/src/SqsTestUtils.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ import kotlin.time.Duration.Companion.seconds
1818
object SqsTestUtils {
1919
const val DEFAULT_REGION = "us-west-2"
2020

21-
const val TEST_QUEUE_WRONG_CHECKSUM_PREFIX = "sqs-test-queue-wrong-checksum"
22-
const val TEST_QUEUE_CORRECT_CHECKSUM_PREFIX = "sqs-test-queue-correct-checksum"
21+
const val TEST_QUEUE_WRONG_CHECKSUM_PREFIX = "sqs-test-queue-wrong-checksum-"
22+
const val TEST_QUEUE_CORRECT_CHECKSUM_PREFIX = "sqs-test-queue-correct-checksum-"
2323

2424
const val TEST_MESSAGE_BODY = "Hello World"
2525
const val TEST_MESSAGE_ATTRIBUTES_NAME = "TestAttribute"

0 commit comments

Comments
 (0)