Skip to content

Commit 81afe4d

Browse files
authored
fix: move DSL overloads to be extension methods on generated clients (#653)
1 parent f55d02d commit 81afe4d

File tree

8 files changed

+24
-2
lines changed

8 files changed

+24
-2
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"id": "79d84a4d-ec4c-4442-b65e-57141e46b069",
3+
"type": "bugfix",
4+
"description": "**Breaking**: Move DSL overloads on generated clients to extension methods"
5+
}

aws-runtime/aws-config/common/src/aws/sdk/kotlin/runtime/auth/credentials/SsoCredentialsProvider.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ package aws.sdk.kotlin.runtime.auth.credentials
77

88
import aws.sdk.kotlin.runtime.ConfigurationException
99
import aws.sdk.kotlin.runtime.auth.credentials.internal.sso.SsoClient
10+
import aws.sdk.kotlin.runtime.auth.credentials.internal.sso.getRoleCredentials
1011
import aws.sdk.kotlin.runtime.config.profile.normalizePath
1112
import aws.smithy.kotlin.runtime.auth.awscredentials.Credentials
1213
import aws.smithy.kotlin.runtime.auth.awscredentials.CredentialsProvider

aws-runtime/aws-config/common/src/aws/sdk/kotlin/runtime/auth/credentials/StsAssumeRoleCredentialsProvider.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
package aws.sdk.kotlin.runtime.auth.credentials
77

88
import aws.sdk.kotlin.runtime.auth.credentials.internal.sts.StsClient
9+
import aws.sdk.kotlin.runtime.auth.credentials.internal.sts.assumeRole
910
import aws.sdk.kotlin.runtime.auth.credentials.internal.sts.model.RegionDisabledException
1011
import aws.sdk.kotlin.runtime.config.AwsSdkSetting
1112
import aws.sdk.kotlin.runtime.config.resolve

aws-runtime/aws-config/common/src/aws/sdk/kotlin/runtime/auth/credentials/StsWebIdentityCredentialsProvider.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
package aws.sdk.kotlin.runtime.auth.credentials
77

88
import aws.sdk.kotlin.runtime.auth.credentials.internal.sts.StsClient
9+
import aws.sdk.kotlin.runtime.auth.credentials.internal.sts.assumeRoleWithWebIdentity
910
import aws.sdk.kotlin.runtime.config.AwsSdkSetting
1011
import aws.sdk.kotlin.runtime.config.resolve
1112
import aws.smithy.kotlin.runtime.auth.awscredentials.Credentials

examples/s3-media-ingestion/src/main/kotlin/aws/sdk/kotlin/example/Main.kt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,12 @@
55
package aws.sdk.kotlin.example
66

77
import aws.sdk.kotlin.services.s3.S3Client
8+
import aws.sdk.kotlin.services.s3.createBucket
9+
import aws.sdk.kotlin.services.s3.headBucket
10+
import aws.sdk.kotlin.services.s3.headObject
11+
import aws.sdk.kotlin.services.s3.listObjects
812
import aws.sdk.kotlin.services.s3.model.*
13+
import aws.sdk.kotlin.services.s3.putObject
914
import aws.smithy.kotlin.runtime.content.ByteStream
1015
import aws.smithy.kotlin.runtime.content.fromFile
1116
import aws.smithy.kotlin.runtime.content.writeToFile

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ kotlin.native.ignoreDisabledTargets=true
66
org.gradle.jvmargs=-Xmx6g -XX:MaxMetaspaceSize=2G
77

88
# sdk
9-
sdkVersion=0.16.8-SNAPSHOT
9+
sdkVersion=0.17.0-SNAPSHOT
1010

1111
# codegen
1212
smithyVersion=1.22.0

services/s3/e2eTest/S3IntegrationTest.kt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,13 @@
55
package aws.sdk.kotlin.e2etest
66

77
import aws.sdk.kotlin.services.s3.S3Client
8+
import aws.sdk.kotlin.services.s3.completeMultipartUpload
9+
import aws.sdk.kotlin.services.s3.createMultipartUpload
10+
import aws.sdk.kotlin.services.s3.listObjects
811
import aws.sdk.kotlin.services.s3.model.CompletedPart
912
import aws.sdk.kotlin.services.s3.model.GetObjectRequest
13+
import aws.sdk.kotlin.services.s3.putObject
14+
import aws.sdk.kotlin.services.s3.uploadPart
1015
import aws.sdk.kotlin.testing.PRINTABLE_CHARS
1116
import aws.sdk.kotlin.testing.withAllEngines
1217
import aws.smithy.kotlin.runtime.content.ByteStream

services/s3/e2eTest/S3TestUtils.kt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,15 @@
55
package aws.sdk.kotlin.e2etest
66

77
import aws.sdk.kotlin.services.s3.S3Client
8+
import aws.sdk.kotlin.services.s3.createBucket
9+
import aws.sdk.kotlin.services.s3.deleteBucket
10+
import aws.sdk.kotlin.services.s3.deleteObject
811
import aws.sdk.kotlin.services.s3.model.BucketLocationConstraint
912
import aws.sdk.kotlin.services.s3.model.ExpirationStatus
1013
import aws.sdk.kotlin.services.s3.model.LifecycleRule
1114
import aws.sdk.kotlin.services.s3.model.LifecycleRuleFilter
1215
import aws.sdk.kotlin.services.s3.paginators.listObjectsV2Paginated
16+
import aws.sdk.kotlin.services.s3.putBucketLifecycleConfiguration
1317
import aws.sdk.kotlin.services.s3.waiters.waitUntilBucketExists
1418
import aws.smithy.kotlin.runtime.http.request.HttpRequest
1519
import kotlinx.coroutines.*
@@ -27,7 +31,7 @@ object S3TestUtils {
2731
suspend fun getTestBucket(client: S3Client): String = getBucketWithPrefix(client, TEST_BUCKET_PREFIX)
2832

2933
private suspend fun getBucketWithPrefix(client: S3Client, prefix: String): String = withTimeout(60.seconds) {
30-
var testBucket = client.listBuckets {}
34+
var testBucket = client.listBuckets()
3135
.buckets
3236
?.mapNotNull { it.name }
3337
?.firstOrNull { it.startsWith(prefix) }

0 commit comments

Comments
 (0)