Self review

Author: 0marperez

aws-runtime/aws-config/common/src/aws/sdk/kotlin/runtime/auth/credentials/DefaultChainCredentialsProvider.kt

@@ -46,13 +46,15 @@ public class DefaultChainCredentialsProvider constructor(
     httpClient: HttpClientEngine? = null,
     public val region: String? = null,
 ) : CloseableCredentialsProvider {
+
     private val manageEngine = httpClient == null
     private val engine = httpClient ?: DefaultHttpEngine()
 
     private val chain = CredentialsProviderChain(
         SystemPropertyCredentialsProvider(platformProvider::getProperty),
         EnvironmentCredentialsProvider(platformProvider::getenv),
         LazilyInitializedCredentialsProvider("EnvironmentStsWebIdentityCredentialsProvider") {
+            // STS web identity provider can be constructed from either the profile OR 100% from the environment
             StsWebIdentityCredentialsProvider.fromEnvironment(
                 platformProvider = platformProvider,
                 httpClient = httpClient,

aws-runtime/aws-config/jvm/test/aws/sdk/kotlin/runtime/auth/credentials/DefaultChainCredentialsProviderTest.kt

@@ -184,7 +184,7 @@ class DefaultChainCredentialsProviderTest {
                 assertEquals(expected.creds, creds)
 
                 if (expected.businessMetrics.isNotEmpty()) {
-                    assertEquals(expected.businessMetrics, attributes[BusinessMetrics]) // TODO: FILL OUT TESTS
+                    assertEquals(expected.businessMetrics, attributes[BusinessMetrics])
                 }
 
                 // assert http traffic to the extent we can. These tests do not have specific timestamps they