Fix runtime warnings

Author: lauzadis

aws-runtime/aws-config/common/src/aws/sdk/kotlin/runtime/auth/credentials/ImdsCredentialsProvider.kt

@@ -132,7 +132,7 @@ public class ImdsCredentialsProvider(
     private suspend fun loadProfile() = try {
         client.value.get(CREDENTIALS_BASE_PATH)
     } catch (ex: EC2MetadataError) {
-        if (ex.statusCode == HttpStatusCode.NotFound.value) {
+        if (ex.status == HttpStatusCode.NotFound) {
             coroutineContext.info<ImdsCredentialsProvider> {
                 "Received 404 from IMDS when loading profile information. Hint: This instance may not have an " +
                     "IAM role associated."
@@ -142,7 +142,7 @@ public class ImdsCredentialsProvider(
     }
 
     private suspend fun useCachedCredentials(ex: Exception): Credentials? = when {
-        ex is IOException || ex is EC2MetadataError && ex.statusCode == HttpStatusCode.InternalServerError.value -> {
+        ex is IOException || ex is EC2MetadataError && ex.status == HttpStatusCode.InternalServerError -> {
             mu.withLock {
                 previousCredentials?.apply { nextRefresh = clock.now() + DEFAULT_CREDENTIALS_REFRESH_SECONDS.seconds }
             }

aws-runtime/aws-config/common/src/aws/sdk/kotlin/runtime/config/endpoints/AccountIdEndpointMode.kt

@@ -35,5 +35,4 @@ public fun AccountIdEndpointMode.toBusinessMetric(): BusinessMetric = when (this
     AccountIdEndpointMode.PREFERRED -> SmithyBusinessMetric.ACCOUNT_ID_MODE_PREFERRED
     AccountIdEndpointMode.DISABLED -> SmithyBusinessMetric.ACCOUNT_ID_MODE_DISABLED
     AccountIdEndpointMode.REQUIRED -> SmithyBusinessMetric.ACCOUNT_ID_MODE_REQUIRED
-    else -> throw IllegalStateException("Unexpected AccountIdEndpointMode value: ${this::class.simpleName}")
 }

aws-runtime/aws-config/common/src/aws/sdk/kotlin/runtime/config/imds/TokenMiddleware.kt

@@ -66,8 +66,8 @@ internal class TokenMiddleware(
         return try {
             when (call.response.status) {
                 HttpStatusCode.OK -> {
-                    val ttl = call.response.headers[X_AWS_EC2_METADATA_TOKEN_TTL_SECONDS]?.toLong() ?: throw EC2MetadataError(200, "No TTL provided in IMDS response")
-                    val token = call.response.body.readAll() ?: throw EC2MetadataError(200, "No token provided in IMDS response")
+                    val ttl = call.response.headers[X_AWS_EC2_METADATA_TOKEN_TTL_SECONDS]?.toLong() ?: throw EC2MetadataError(call.response.status, "No TTL provided in IMDS response")
+                    val token = call.response.body.readAll() ?: throw EC2MetadataError(call.response.status, "No token provided in IMDS response")
                     val expires = clock.now() + ttl.seconds
                     Token(token, expires)
                 }
@@ -76,7 +76,7 @@ internal class TokenMiddleware(
                         HttpStatusCode.Forbidden -> "Request forbidden: IMDS is disabled or the caller has insufficient permissions."
                         else -> "Failed to retrieve IMDS token"
                     }
-                    throw EC2MetadataError(call.response.status.value, message)
+                    throw EC2MetadataError(call.response.status, message)
                 }
             }
         } finally {

aws-runtime/aws-config/common/test/aws/sdk/kotlin/runtime/config/imds/ImdsClientTest.kt

@@ -200,7 +200,7 @@ class ImdsClientTest {
             client.get("/latest/metadata")
         }
 
-        assertEquals(HttpStatusCode.Forbidden.value, ex.statusCode)
+        assertEquals(HttpStatusCode.Forbidden, ex.status)
         connection.assertRequests()
     }
 

build.gradle.kts

@@ -5,6 +5,7 @@
 import aws.sdk.kotlin.gradle.dsl.configureLinting
 import aws.sdk.kotlin.gradle.dsl.configureNexus
 import aws.sdk.kotlin.gradle.util.typedProp
+import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
 
 buildscript {
     // NOTE: buildscript classpath for the root project is the parent classloader for the subprojects, we
@@ -38,6 +39,12 @@ val testJavaVersion = typedProp<String>("test.java.version")?.let {
 }
 
 allprojects {
+    tasks.withType<KotlinCompile> {
+        compilerOptions {
+            allWarningsAsErrors = true
+        }
+    }
+
     if (testJavaVersion != null) {
         tasks.withType<Test> {
             val toolchains = project.extensions.getByType<JavaToolchainService>()

codegen/aws-sdk-codegen/src/main/kotlin/aws/sdk/kotlin/codegen/ServiceClientCompanionObjectWriter.kt

@@ -73,6 +73,6 @@ internal fun String.toEndpointUrlConfigNames(): EndpointUrlConfigNames = Endpoin
 // for our client names
 // e.g. sdkId "Elasticsearch Service" -> client name "ElasticsearchClient", prop "aws.endpointUrlElasticsearch"
 private object JvmSystemPropertySuffix : StringTransformer {
-    override fun transform(id: String): String =
-        id.toPascalCase().removeSuffix("Service")
+    override fun transform(input: String): String =
+        input.toPascalCase().removeSuffix("Service")
 }

hll/build.gradle.kts

@@ -70,6 +70,12 @@ subprojects {
                 optinAnnotations.forEach(languageSettings::optIn)
             }
 
+            named("commonMain") {
+                dependencies {
+                    api(project(":aws-runtime:aws-core")) // for InternalSdkApi annotation
+                }
+            }
+
             named("commonTest") {
                 dependencies {
                     implementation(libraries.kotest.assertions.core)

services/build.gradle.kts

@@ -129,6 +129,7 @@ subprojects {
 
     tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> {
         compilerOptions {
+            allWarningsAsErrors.set(false) // FIXME Tons of errors occur in generated code. Can we work around errors from deprecated service fields / APIs?
             jvmTarget.set(JvmTarget.JVM_1_8) // fixes outgoing variant metadata: https://github.com/smithy-lang/smithy-kotlin/issues/258
             freeCompilerArgs.add("-Xjdk-release=1.8")
         }