Properly memscope execution

lauzadis · lauzadis · commit 9ccc2082730b · 2025-05-08T13:10:57.000-04:00
diff --git a/aws-runtime/aws-config/native/src/aws/sdk/kotlin/runtime/auth/credentials/executeCommandNative.kt b/aws-runtime/aws-config/native/src/aws/sdk/kotlin/runtime/auth/credentials/executeCommandNative.kt
@@ -57,8 +57,10 @@ internal actual suspend fun executeCommand(
             else -> "-c"
         }
 
-        val argv = memScoped { (arrayOf(shell, shellArg, command).map { it.cstr.ptr } + null).toCValues() }
-        execvp(shell, argv)
+        memScoped {
+            val argv = (arrayOf(shell, shellArg, command).map { it.cstr.ptr } + null).toCValues()
+            execvp(shell, argv)
+        }
         _exit(127) // If exec fails
     }
 

Original file line number	Diff line number	Diff line change
`@@ -57,8 +57,10 @@ internal actual suspend fun executeCommand(`
`57`	`57`	`else -> "-c"`
`58`	`58`	`}`
`59`	`59`
`60`		`- val argv = memScoped { (arrayOf(shell, shellArg, command).map { it.cstr.ptr } + null).toCValues() }`
`61`		`- execvp(shell, argv)`
	`60`	`+ memScoped {`
	`61`	`+ val argv = (arrayOf(shell, shellArg, command).map { it.cstr.ptr } + null).toCValues()`
	`62`	`+ execvp(shell, argv)`
	`63`	`+ }`
`62`	`64`	`_exit(127) // If exec fails`
`63`	`65`	`}`
`64`	`66`