fix(codegen): presigner cleanup (#452)

Author: kggilmer

codegen/smithy-aws-kotlin-codegen/src/main/kotlin/aws/sdk/kotlin/codegen/PresignerGenerator.kt

@@ -248,6 +248,7 @@ class PresignerGenerator : KotlinIntegration {
         ccg.render()
     }
 
+    // Captures protocol-specific state needed for presigning requests
     interface PresignConfigFnVisitor {
         fun renderHttpMethod(writer: KotlinWriter)
         fun renderQueryParameters(writer: KotlinWriter)
@@ -308,7 +309,7 @@ class PresignerGenerator : KotlinIntegration {
                     presignConfigFnVisitor.renderQueryParameters(writer)
                     write("durationSeconds.toLong(),")
                     write("${presignableOp.signBody},")
-                    write("SigningLocation.HEADER")
+                    write("SigningLocation.QUERY_STRING")
                 }
             }
         }

codegen/smithy-aws-kotlin-codegen/src/test/kotlin/aws/sdk/kotlin/codegen/PresignerGeneratorTest.kt

@@ -139,7 +139,7 @@ class PresignerGeneratorTest {
                     httpRequestBuilder.url.parameters.build(),
                     durationSeconds.toLong(),
                     false,
-                    SigningLocation.HEADER
+                    SigningLocation.QUERY_STRING
                 )
             }
             
@@ -177,7 +177,7 @@ class PresignerGeneratorTest {
                     httpRequestBuilder.url.parameters.build(),
                     durationSeconds.toLong(),
                     false,
-                    SigningLocation.HEADER
+                    SigningLocation.QUERY_STRING
                 )
             }
             
@@ -215,7 +215,7 @@ class PresignerGeneratorTest {
                     httpRequestBuilder.url.parameters.build(),
                     durationSeconds.toLong(),
                     false,
-                    SigningLocation.HEADER
+                    SigningLocation.QUERY_STRING
                 )
             }