chore: fix warnings (#342)

Author: ianbotsf

.github/workflows/continuous-integration.yml

@@ -57,4 +57,5 @@ jobs:
       run: |
         python3 -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder.pyz')"
         chmod a+x builder.pyz
+        echo "kotlinWarningsAsErrors=true" >> $GITHUB_WORKSPACE/local.properties
         GIT_ASKPASS="$(pwd)/.github/scripts/git-ci-askpass.sh" ./builder.pyz build -p ${{ env.PACKAGE_NAME }}

aws-runtime/aws-config/build.gradle.kts

@@ -45,5 +45,10 @@ kotlin {
                 implementation("io.kotest:kotest-runner-junit5:$kotestVersion")
             }
         }
+
+        all {
+            languageSettings.optIn("aws.smithy.kotlin.runtime.util.InternalApi")
+            languageSettings.optIn("aws.sdk.kotlin.runtime.InternalSdkApi")
+        }
     }
 }

aws-runtime/aws-config/common/test/aws/sdk/kotlin/runtime/config/profile/AwsConfigLoaderTest.kt

@@ -27,7 +27,7 @@ class AwsConfigLoaderTest {
         testCases
             .map { TestCase.fromJson(it.jsonObject) }
             // .filter { testCase -> testCase.name == "The default config location can be overridden by the user on non-windows platforms." }
-            .forEachIndexed { index, testCase ->
+            .forEach { testCase ->
                 val testPlatform = mockPlatform(testCase)
 
                 val actual = resolveConfigSource(testPlatform)

aws-runtime/aws-config/common/test/aws/sdk/kotlin/runtime/config/profile/AwsConfigParserTest.kt

@@ -154,9 +154,9 @@ class AwsProfileParserTest {
 
                 return if (!isErrorCase) {
                     when {
-                        configIn != null && credentialIn != null -> MatchConfigAndCredentialOutputCase(name, configIn!!, credentialIn!!, expected!!)
-                        configIn != null -> MatchConfigOutputCase(name, configIn!!, expected!!)
-                        credentialIn != null -> MatchCredentialOutputCase(name, credentialIn!!, expected!!)
+                        configIn != null && credentialIn != null -> MatchConfigAndCredentialOutputCase(name, configIn, credentialIn, expected!!)
+                        configIn != null -> MatchConfigOutputCase(name, configIn, expected!!)
+                        credentialIn != null -> MatchCredentialOutputCase(name, credentialIn, expected!!)
                         else -> error("Unexpected branch from $json")
                     }
                 } else {

aws-runtime/aws-config/common/test/aws/sdk/kotlin/runtime/config/profile/ContinuationMergerTest.kt

@@ -23,7 +23,7 @@ class ContinuationMergerTest {
             "[profile foo]\ns3 =\n name = value" to "[[profile foo], s3 =\nname = value]",
         )
 
-        positiveTestCases.forEachIndexed { index, testCase ->
+        positiveTestCases.forEach { testCase ->
             val actual = mergeContinuations(testCase.first).map { it.content }
             assertEquals(testCase.second, actual.toString())
         }

aws-runtime/aws-config/jvm/test/aws/sdk/kotlin/runtime/config/profile/AWSConfigLoaderFilesystemTest.kt

@@ -32,8 +32,9 @@ class AWSConfigLoaderFilesystemTest {
 
     @Test
     fun itLoadsConfigFileFromFilesystem() = runSuspendTest {
-        val configFile = tempDir!!.resolve("config")
-        val credentialsFile = tempDir!!.resolve("credentials")
+        requireNotNull(tempDir)
+        val configFile = tempDir.resolve("config")
+        val credentialsFile = tempDir.resolve("credentials")
 
         configFile.writeText("[profile foo]\nname = value")
 
@@ -58,8 +59,9 @@ class AWSConfigLoaderFilesystemTest {
 
     @Test
     fun itLoadsConfigAndCredsFileFromFilesystem() = runSuspendTest {
-        val configFile = tempDir!!.resolve("config")
-        val credentialsFile = tempDir!!.resolve("credentials")
+        requireNotNull(tempDir)
+        val configFile = tempDir.resolve("config")
+        val credentialsFile = tempDir.resolve("credentials")
 
         configFile.writeText("[profile default]\nname = value\n[default]\nname2 = value2\n[profile default]\nname3 = value3")
         credentialsFile.writeText("[default]\nsecret=foo")

aws-runtime/aws-core/build.gradle.kts

@@ -23,5 +23,9 @@ kotlin {
                 implementation(project(":aws-runtime:testing"))
             }
         }
+
+        all {
+            languageSettings.optIn("aws.smithy.kotlin.runtime.util.InternalApi")
+        }
     }
 }

aws-runtime/aws-endpoint/build.gradle.kts

@@ -17,5 +17,9 @@ kotlin {
                 implementation(project(":aws-runtime:aws-core"))
             }
         }
+
+        all {
+            languageSettings.optIn("aws.sdk.kotlin.runtime.InternalSdkApi")
+        }
     }
 }

aws-runtime/aws-http/build.gradle.kts

@@ -24,6 +24,10 @@ kotlin {
                 implementation(project(":aws-runtime:testing"))
             }
         }
+
+        all {
+            languageSettings.optIn("aws.smithy.kotlin.runtime.util.InternalApi")
+            languageSettings.optIn("aws.sdk.kotlin.runtime.InternalSdkApi")
+        }
     }
 }
-

aws-runtime/aws-signing/build.gradle.kts

@@ -32,5 +32,10 @@ kotlin {
                 implementation(project(":aws-runtime:testing"))
             }
         }
+
+        all {
+            languageSettings.optIn("aws.smithy.kotlin.runtime.util.InternalApi")
+            languageSettings.optIn("aws.sdk.kotlin.runtime.InternalSdkApi")
+        }
     }
 }