refactor: remove suspend from deserialization (#417)

Author: aajtodd

codegen/smithy-aws-kotlin-codegen/src/main/kotlin/aws/sdk/kotlin/codegen/customization/glacier/GlacierAccountIdDefault.kt

@@ -47,7 +47,7 @@ private class GlacierAccountIdMiddleware : ProtocolMiddleware {
         val accountId = ctx.model.expectShape<StructureShape>(op.input.get()).members().first { it.memberName.lowercase() == "accountid" }
         writer.addImport(RuntimeTypes.Http.Operation.OperationRequest)
 
-        writer.withBlock("execution.initialize.intercept { req, next -> ", "}") {
+        writer.withBlock("op.execution.initialize.intercept { req, next -> ", "}") {
             openBlock("if (req.subject.#L.isNullOrEmpty()) {", accountId.defaultName())
                 .write("val updated = req.subject.copy { #L = #S }", accountId.defaultName(), "-")
                 .write("next.call(#T(req.context, updated))", RuntimeTypes.Http.Operation.OperationRequest)

codegen/smithy-aws-kotlin-codegen/src/main/kotlin/aws/sdk/kotlin/codegen/protocols/RestXml.kt

@@ -174,7 +174,7 @@ open class RestXml : AwsHttpBindingProtocolGenerator() {
         // in two different contexts
         val boundMemberName = boundMember.capitalizedDefaultName()
         val deserializeLambdaIdent = "deserialize$boundMemberName"
-        writer.withBlock("val $deserializeLambdaIdent = suspend {", "}") {
+        writer.withBlock("val $deserializeLambdaIdent = {", "}") {
             write("val builder = #T.builder()", memberSymbol)
             renderDeserializerBody(ctx, copyWithMemberTraits, targetShape.members().toList(), writer)
             write("builder.build()")

gradle.properties

@@ -12,7 +12,7 @@ sdkVersion=0.9.3-SNAPSHOT
 smithyVersion=1.13.1
 smithyGradleVersion=0.5.3
 # smithy-kotlin codegen and runtime are versioned together
-smithyKotlinVersion=0.7.1-alpha
+smithyKotlinVersion=0.7.2-SNAPSHOT
 
 # kotlin
 kotlinVersion=1.5.31

services/s3/common/src/aws/sdk/kotlin/services/s3/internal/GetBucketLocationOperationDeserializer.kt

@@ -28,7 +28,7 @@ internal class GetBucketLocationOperationDeserializer : HttpDeserialize<GetBucke
     }
 }
 
-private suspend fun deserializeGetBucketLocationOperationBody(builder: GetBucketLocationResponse.DslBuilder, payload: ByteArray) {
+private fun deserializeGetBucketLocationOperationBody(builder: GetBucketLocationResponse.DslBuilder, payload: ByteArray) {
     val dom = parseDom(xmlStreamReader(payload))
     check(dom.name.local == "LocationConstraint") { "Expected top-level tag of 'LocationConstraint' but found ${dom.name}." }
     val rawLocationConstraint = checkNotNull(dom.text) { "Did not receive a value for 'LocationConstraint' in response." }

services/s3/common/src/aws/sdk/kotlin/services/s3/internal/S3ErrorMetadata.kt

@@ -41,7 +41,7 @@ internal fun setS3ErrorMetadata(exception: Any, response: HttpResponse, errorDet
     }
 }
 
-internal suspend fun parseS3ErrorResponse(payload: ByteArray): S3ErrorDetails {
+internal fun parseS3ErrorResponse(payload: ByteArray): S3ErrorDetails {
     val MESSAGE_DESCRIPTOR = SdkFieldDescriptor(SerialKind.String, XmlSerialName("Message"))
     val CODE_DESCRIPTOR = SdkFieldDescriptor(SerialKind.String, XmlSerialName("Code"))
     val REQUESTID_DESCRIPTOR = SdkFieldDescriptor(SerialKind.String, XmlSerialName("RequestId"))

services/s3/common/test/aws/sdk/kotlin/services/s3/internal/S3ErrorMetadataTest.kt

@@ -4,13 +4,12 @@
  */
 package aws.sdk.kotlin.services.s3.internal
 
-import aws.sdk.kotlin.runtime.testing.runSuspendTest
 import kotlin.test.*
 
 class S3ErrorDeserializerTest {
 
     @Test
-    fun `it deserializes s3 errors`() = runSuspendTest {
+    fun `it deserializes s3 errors`() {
         val payload = """
             <Error>
                 <Type>Sender</Type>
@@ -31,7 +30,7 @@ class S3ErrorDeserializerTest {
     }
 
     @Test
-    fun `it partially deserializes s3 errors`() = runSuspendTest {
+    fun `it partially deserializes s3 errors`() {
         val tests = listOf(
             """
                 <Error>