RequestChecksum required client config tests

Author: 0marperez

tests/codegen/checksums/src/commonTest/kotlin/ClientConfigTests.kt

@@ -10,48 +10,101 @@ import kotlin.test.Test
 import kotlin.test.assertFalse
 import kotlin.test.assertTrue
 import aws.smithy.kotlin.runtime.httptest.TestEngine
+import org.junit.jupiter.api.Nested
+import kotlin.test.Ignore
 
 class ClientConfigTests {
-    @Test
-    fun requestChecksumCalculationWhenSupported(): Unit = runBlocking {
-        val testInterceptor = TestInterceptor()
+    @Nested
+    inner class RequestChecksumNotRequired {
+        @Test
+        @Ignore // todo: un-ignore
+        fun requestChecksumCalculationWhenSupported(): Unit = runBlocking {
+            val testInterceptor = TestInterceptor()
 
-        ClientConfigTestClient {
-            requestChecksumCalculation = RequestChecksumCalculation.WHEN_SUPPORTED
-            interceptors = mutableListOf(testInterceptor)
-            httpClient = TestEngine()
-            credentialsProvider = StaticCredentialsProvider(
-                Credentials("accessKeyID", "secretAccessKey"),
-            )
-            region = "us-east-1"
-        }.use { client ->
-            client.checksumsNotRequiredOperation {
-                body = "Hello World!"
+            ClientConfigTestClient {
+                requestChecksumCalculation = RequestChecksumCalculation.WHEN_SUPPORTED
+                interceptors = mutableListOf(testInterceptor)
+                httpClient = TestEngine()
+                credentialsProvider = StaticCredentialsProvider(
+                    Credentials("accessKeyID", "secretAccessKey"),
+                )
+                region = "us-east-1"
+            }.use { client ->
+                client.checksumsNotRequiredOperation {
+                    body = "Hello World!"
+                }
             }
+
+            assertTrue(testInterceptor.containsChecksum)
         }
 
-        assertTrue(testInterceptor.containsChecksum)
+        @Test
+        fun requestChecksumCalculationWhenRequired(): Unit = runBlocking {
+            val testInterceptor = TestInterceptor()
+
+            ClientConfigTestClient {
+                requestChecksumCalculation = RequestChecksumCalculation.WHEN_REQUIRED
+                interceptors = mutableListOf(testInterceptor)
+                httpClient = TestEngine()
+                credentialsProvider = StaticCredentialsProvider(
+                    Credentials("accessKeyID", "secretAccessKey"),
+                )
+                region = "us-east-1"
+            }.use { client ->
+                client.checksumsNotRequiredOperation {
+                    body = "Hello World!"
+                }
+            }
+
+            assertFalse(testInterceptor.containsChecksum)
+        }
     }
 
-    @Test
-    fun requestChecksumCalculationWhenRequired(): Unit = runBlocking {
-        val testInterceptor = TestInterceptor()
+    @Nested
+    inner class RequestChecksumRequired {
+        @Test
+        @Ignore // todo: un-ignore
+        fun requestChecksumCalculationWhenSupported(): Unit = runBlocking {
+            val testInterceptor = TestInterceptor()
 
-        ClientConfigTestClient {
-            requestChecksumCalculation = RequestChecksumCalculation.WHEN_REQUIRED
-            interceptors = mutableListOf(testInterceptor)
-            httpClient = TestEngine()
-            credentialsProvider = StaticCredentialsProvider(
-                Credentials("accessKeyID", "secretAccessKey"),
-            )
-            region = "us-east-1"
-        }.use { client ->
-            client.checksumsNotRequiredOperation {
-                body = "Hello World!"
+            ClientConfigTestClient {
+                requestChecksumCalculation = RequestChecksumCalculation.WHEN_SUPPORTED
+                interceptors = mutableListOf(testInterceptor)
+                httpClient = TestEngine()
+                credentialsProvider = StaticCredentialsProvider(
+                    Credentials("accessKeyID", "secretAccessKey"),
+                )
+                region = "us-east-1"
+            }.use { client ->
+                client.checksumsRequiredOperation {
+                    body = "Hello World!"
+                }
             }
+
+            assertTrue(testInterceptor.containsChecksum)
         }
 
-        assertFalse(testInterceptor.containsChecksum)
+        @Test
+        @Ignore // todo: un-ignore
+        fun requestChecksumCalculationWhenRequired(): Unit = runBlocking {
+            val testInterceptor = TestInterceptor()
+
+            ClientConfigTestClient {
+                requestChecksumCalculation = RequestChecksumCalculation.WHEN_REQUIRED
+                interceptors = mutableListOf(testInterceptor)
+                httpClient = TestEngine()
+                credentialsProvider = StaticCredentialsProvider(
+                    Credentials("accessKeyID", "secretAccessKey"),
+                )
+                region = "us-east-1"
+            }.use { client ->
+                client.checksumsRequiredOperation {
+                    body = "Hello World!"
+                }
+            }
+
+            assertTrue(testInterceptor.containsChecksum)
+        }
     }
 }
 

tests/codegen/checksums/src/commonTest/resources/client-config.smithy

@@ -20,7 +20,7 @@ use smithy.rules#endpointRuleSet
 })
 service ClientConfigTestService {
     version: "2023-01-01",
-    operations: [ChecksumsNotRequiredOperation]
+    operations: [ChecksumsNotRequiredOperation, ChecksumsRequiredOperation]
 }
 
 @httpChecksum(
@@ -33,6 +33,16 @@ operation ChecksumsNotRequiredOperation {
     output: SomeOutput
 }
 
+@httpChecksum(
+    requestChecksumRequired: true,
+    requestAlgorithmMember: "checksumAlgorithm",
+)
+@http(method: "POST", uri: "/test-checksums-2", code: 200)
+operation ChecksumsRequiredOperation {
+    input: AnotherInput,
+    output: AnotherOutput
+}
+
 @input
 structure SomeInput {
     @httpHeader("x-amz-request-algorithm")
@@ -46,6 +56,19 @@ structure SomeInput {
 @output
 structure SomeOutput {}
 
+@input
+structure AnotherInput {
+    @httpHeader("x-amz-request-algorithm")
+    checksumAlgorithm: ChecksumAlgorithm
+
+    @httpPayload
+    @required
+    body: String
+}
+
+@output
+structure AnotherOutput {}
+
 enum ChecksumAlgorithm {
     CRC32
     CRC32C