Remove dangerous gradle task, move sdk denylist check to codegen instead of runtime

Author: 0marperez

codegen/aws-sdk-codegen/src/main/kotlin/aws/sdk/kotlin/codegen/GradleGenerator.kt

@@ -11,7 +11,6 @@ import software.amazon.smithy.kotlin.codegen.model.hasTrait
 import software.amazon.smithy.kotlin.codegen.model.traits.FailedResponseTrait
 import software.amazon.smithy.kotlin.codegen.model.traits.SuccessResponseTrait
 import software.amazon.smithy.kotlin.codegen.rendering.GradleWriter
-import software.amazon.smithy.kotlin.codegen.utils.dq
 import software.amazon.smithy.kotlin.codegen.utils.operations
 import software.amazon.smithy.model.shapes.ServiceShape
 import software.amazon.smithy.smoketests.traits.SmokeTestsTrait
@@ -83,10 +82,9 @@ class GradleGenerator : KotlinIntegration {
     }
 
     private fun generateSmokeTestConfig(writer: GradleWriter, sdkId: String, ctx: CodegenContext) {
-        val formattedDenyList = smokeTestDenyList.joinToString(",", "setOf(", ")") { it.dq() }
-        writer.withBlock("if (#S !in #L) {", "}", sdkId, formattedDenyList) {
+        if (sdkId !in smokeTestDenyList) {
             generateSmokeTestJarTask(writer, ctx)
-            emptyLine()
+            writer.emptyLine()
             generateSmokeTestTask(writer, ctx)
         }
     }

tests/codegen/smoke-tests/build.gradle.kts

@@ -7,15 +7,15 @@ import aws.sdk.kotlin.gradle.codegen.dsl.generateSmithyProjections
 import aws.sdk.kotlin.gradle.codegen.dsl.smithyKotlinPlugin
 import aws.sdk.kotlin.gradle.codegen.smithyKotlinProjectionPath
 
-description = "Tests for smoke tests runner"
+description = "Tests for smoke tests runners"
 plugins {
     alias(libs.plugins.aws.kotlin.repo.tools.smithybuild)
     alias(libs.plugins.kotlin.jvm)
 }
 
 val projections = listOf(
-    ProjectionMetadata("successService", "smoke-tests-success.smithy", "com.test#SuccessService"),
-    ProjectionMetadata("failureService", "smoke-tests-failure.smithy", "com.test#FailureService"),
+    ProjectionMetadata("successService", "smoke-tests-success.smithy", "smithy.kotlin.traits#SuccessService"),
+    ProjectionMetadata("failureService", "smoke-tests-failure.smithy", "smithy.kotlin.traits#FailureService"),
 )
 
 configureProject()
@@ -93,14 +93,6 @@ fun configureTasks() {
     tasks.build {
         dependsOn(tasks.getByName("stageServices"))
     }
-
-    tasks.register<Exec>("unstageServices") {
-        commandLine("git", "clean", "-fdx", "services")
-    }
-
-    tasks.clean {
-        dependsOn(tasks.getByName("unstageServices"))
-    }
 }
 
 /**

tests/codegen/smoke-tests/src/test/resources/smoke-tests-failure.smithy

@@ -1,5 +1,5 @@
 $version: "2"
-namespace com.test
+namespace smithy.kotlin.traits
 
 use aws.protocols#awsJson1_0
 use aws.api#service

tests/codegen/smoke-tests/src/test/resources/smoke-tests-success.smithy

@@ -1,5 +1,5 @@
 $version: "2"
-namespace com.test
+namespace smithy.kotlin.traits
 
 use aws.protocols#awsJson1_0
 use aws.api#service