HeadObjectOperationDeserializer throwHeadObjectError throws wrong S3Exception("Failed to parse response as restXml error") when payload was not null but empty

[mumbi]

Describe the bug

private fun throwHeadObjectError(context: ExecutionContext, call: HttpCall, payload: ByteArray?): kotlin.Nothing {
    val wrappedResponse = call.response.withPayload(payload)
    val wrappedCall = call.copy(response = wrappedResponse)

    val errorDetails = try {
        if (payload == null) {
            if (call.response.status == HttpStatusCode.NotFound) {
                S3ErrorDetails(code = "NotFound")

            } else {
                S3ErrorDetails(code = call.response.status.toString())

            }
        } else {
            parseS3ErrorResponse(payload)

        }
    } catch (ex: Exception) {
        throw S3Exception("Failed to parse response as restXml error").also {
            setS3ErrorMetadata(it, wrappedCall.response, null)
        }
    }
    val ex = when(errorDetails.code) {
        "NotFound" -> NotFoundDeserializer().deserialize(context, wrappedCall, payload)
        else -> S3Exception(errorDetails.message)
    }

    setS3ErrorMetadata(ex, wrappedResponse, errorDetails)
    throw ex
}

Regression Issue

• Select this option if this issue appears to be a regression.

Expected behavior

must throws NotFound exception when receive status 404

Current behavior

when receive status 404, sometimes payload is not null but empty.

when payload is not null, try to parse payload then throw S3Exception("Failed to parse response as restXml error")

Steps to Reproduce

head object from removed object

Possible Solution

No response

Context

No response

AWS SDK for Kotlin version

aws.sdk.kotlin:s3:1.3.70

Platform (JVM/JS/Native)

JVM

Operating system and version

Windows 11

[0marperez]

Hello, I'm unable to reproduce the behavior you mention. Calling headObject for a removed object results in NotFound().

    S3Client {
        region = "us-west-2"
    }.use { s3 ->
        s3.headObject {
            bucket = "..."
            key = "should-not-exist"
        }
    }

Could you verify as well?

[github-actions]

It looks like this issue has not been active for more than 5 days. In the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please add a comment to prevent automatic closure, or if the issue is already closed please feel free to reopen it.