Skip to content

Commit 34fa4e2

Browse files
aws-sdk-dotnet-automationaws-sdk-dotnet-automation
committed
Adjust Vietnam PaymentVoucherNumber regex and minor API change.
1 parent 656f155 commit 34fa4e2

File tree

9 files changed

+114
-43
lines changed

9 files changed

+114
-43
lines changed

‎generator/ServiceModels/taxsettings/taxsettings-2018-05-10.api.json

Lines changed: 30 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -295,9 +295,7 @@
295295
},
296296
"AccountIds":{
297297
"type":"list",
298-
"member":{"shape":"AccountId"},
299-
"max":5,
300-
"min":1
298+
"member":{"shape":"AccountId"}
301299
},
302300
"AccountMetaData":{
303301
"type":"structure",
@@ -454,9 +452,15 @@
454452
"type":"structure",
455453
"required":["accountIds"],
456454
"members":{
457-
"accountIds":{"shape":"AccountIds"}
455+
"accountIds":{"shape":"BatchDeleteTaxRegistrationRequestAccountIdsList"}
458456
}
459457
},
458+
"BatchDeleteTaxRegistrationRequestAccountIdsList":{
459+
"type":"list",
460+
"member":{"shape":"AccountId"},
461+
"max":5,
462+
"min":1
463+
},
460464
"BatchDeleteTaxRegistrationResponse":{
461465
"type":"structure",
462466
"required":["errors"],
@@ -468,9 +472,15 @@
468472
"type":"structure",
469473
"required":["accountIds"],
470474
"members":{
471-
"accountIds":{"shape":"AccountIds"}
475+
"accountIds":{"shape":"BatchGetTaxExemptionsRequestAccountIdsList"}
472476
}
473477
},
478+
"BatchGetTaxExemptionsRequestAccountIdsList":{
479+
"type":"list",
480+
"member":{"shape":"AccountId"},
481+
"max":5,
482+
"min":1
483+
},
474484
"BatchGetTaxExemptionsResponse":{
475485
"type":"structure",
476486
"members":{
@@ -501,10 +511,16 @@
501511
"taxRegistrationEntry"
502512
],
503513
"members":{
504-
"accountIds":{"shape":"AccountIds"},
514+
"accountIds":{"shape":"BatchPutTaxRegistrationRequestAccountIdsList"},
505515
"taxRegistrationEntry":{"shape":"TaxRegistrationEntry"}
506516
}
507517
},
518+
"BatchPutTaxRegistrationRequestAccountIdsList":{
519+
"type":"list",
520+
"member":{"shape":"AccountId"},
521+
"max":550,
522+
"min":1
523+
},
508524
"BatchPutTaxRegistrationResponse":{
509525
"type":"structure",
510526
"required":["errors"],
@@ -1027,7 +1043,7 @@
10271043
},
10281044
"PaymentVoucherNumber":{
10291045
"type":"string",
1030-
"pattern":"^\\d{17}$"
1046+
"pattern":"^(\\d{17}|[A-Za-z]{3}\\d{13})$"
10311047
},
10321048
"PersonType":{
10331049
"type":"string",
@@ -1077,12 +1093,18 @@
10771093
"exemptionType"
10781094
],
10791095
"members":{
1080-
"accountIds":{"shape":"AccountIds"},
1096+
"accountIds":{"shape":"PutTaxExemptionRequestAccountIdsList"},
10811097
"authority":{"shape":"Authority"},
10821098
"exemptionCertificate":{"shape":"ExemptionCertificate"},
10831099
"exemptionType":{"shape":"GenericString"}
10841100
}
10851101
},
1102+
"PutTaxExemptionRequestAccountIdsList":{
1103+
"type":"list",
1104+
"member":{"shape":"AccountId"},
1105+
"max":550,
1106+
"min":1
1107+
},
10861108
"PutTaxExemptionResponse":{
10871109
"type":"structure",
10881110
"members":{

‎generator/ServiceModels/taxsettings/taxsettings-2018-05-10.docs.json

Lines changed: 35 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,13 @@
4343
"AccountDetails$accountId": "<p>List of unique account identifiers. </p>",
4444
"AccountIds$member": null,
4545
"BatchDeleteTaxRegistrationError$accountId": "<p> The unique account identifier for the account whose tax registration couldn't be deleted during the <code>BatchDeleteTaxRegistration</code> operation. </p>",
46+
"BatchDeleteTaxRegistrationRequestAccountIdsList$member": null,
47+
"BatchGetTaxExemptionsRequestAccountIdsList$member": null,
4648
"BatchPutTaxRegistrationError$accountId": "<p> The unique account identifier for the account that the tax registration couldn't be added, or updated during the <code>BatchPutTaxRegistration</code> operation. </p>",
49+
"BatchPutTaxRegistrationRequestAccountIdsList$member": null,
4750
"DeleteTaxRegistrationRequest$accountId": "<p>Unique account identifier for the TRN information that needs to be deleted. If this isn't passed, the account ID corresponding to the credentials of the API caller will be used for this parameter.</p>",
4851
"GetTaxRegistrationRequest$accountId": "<p>Your unique account identifier.</p>",
52+
"PutTaxExemptionRequestAccountIdsList$member": null,
4953
"PutTaxRegistrationRequest$accountId": "<p>Your unique account identifier. </p>",
5054
"TaxExemptionDetailsMap$key": null,
5155
"TaxInheritanceDetails$parentEntityId": "<p> Tax inheritance parent account information associated with the account. </p>"
@@ -54,11 +58,7 @@
5458
"AccountIds": {
5559
"base": null,
5660
"refs": {
57-
"BatchDeleteTaxRegistrationRequest$accountIds": "<p>List of unique account identifiers. </p>",
58-
"BatchGetTaxExemptionsRequest$accountIds": "<p> List of unique account identifiers. </p>",
59-
"BatchGetTaxExemptionsResponse$failedAccounts": "<p>The list of accounts that failed to get tax exemptions. </p>",
60-
"BatchPutTaxRegistrationRequest$accountIds": "<p> List of unique account identifiers.</p>",
61-
"PutTaxExemptionRequest$accountIds": "<p> The list of unique account identifiers. </p>"
61+
"BatchGetTaxExemptionsResponse$failedAccounts": "<p>The list of accounts that failed to get tax exemptions. </p>"
6262
}
6363
},
6464
"AccountMetaData": {
@@ -163,6 +163,12 @@
163163
"refs": {
164164
}
165165
},
166+
"BatchDeleteTaxRegistrationRequestAccountIdsList": {
167+
"base": null,
168+
"refs": {
169+
"BatchDeleteTaxRegistrationRequest$accountIds": "<p>List of unique account identifiers. </p>"
170+
}
171+
},
166172
"BatchDeleteTaxRegistrationResponse": {
167173
"base": null,
168174
"refs": {
@@ -173,6 +179,12 @@
173179
"refs": {
174180
}
175181
},
182+
"BatchGetTaxExemptionsRequestAccountIdsList": {
183+
"base": null,
184+
"refs": {
185+
"BatchGetTaxExemptionsRequest$accountIds": "<p> List of unique account identifiers. </p>"
186+
}
187+
},
176188
"BatchGetTaxExemptionsResponse": {
177189
"base": null,
178190
"refs": {
@@ -195,6 +207,12 @@
195207
"refs": {
196208
}
197209
},
210+
"BatchPutTaxRegistrationRequestAccountIdsList": {
211+
"base": null,
212+
"refs": {
213+
"BatchPutTaxRegistrationRequest$accountIds": "<p> List of unique account identifiers.</p>"
214+
}
215+
},
198216
"BatchPutTaxRegistrationResponse": {
199217
"base": null,
200218
"refs": {
@@ -317,7 +335,7 @@
317335
"base": null,
318336
"refs": {
319337
"EgyptAdditionalInfo$uniqueIdentificationNumberExpirationDate": "<p>The expiration date of the unique identification number provided by the Egypt Tax Authority.</p>",
320-
"VietnamAdditionalInfo$paymentVoucherNumberDate": "<p>The date on the tax return payment document.</p>"
338+
"VietnamAdditionalInfo$paymentVoucherNumberDate": "<p>The date on the tax return payment document. This field must be provided for successful API operation.</p>"
321339
}
322340
},
323341
"DeleteSupplementalTaxRegistrationRequest": {
@@ -374,13 +392,13 @@
374392
"ElectronicTransactionCodeNumber": {
375393
"base": null,
376394
"refs": {
377-
"VietnamAdditionalInfo$electronicTransactionCodeNumber": "<p>The electronic transaction code number on the tax return document.</p>"
395+
"VietnamAdditionalInfo$electronicTransactionCodeNumber": "<p>The electronic transaction code number on the tax return document. This field must be provided for successful API operation.</p>"
378396
}
379397
},
380398
"EnterpriseIdentificationNumber": {
381399
"base": null,
382400
"refs": {
383-
"VietnamAdditionalInfo$enterpriseIdentificationNumber": "<p>The enterprise identification number for tax registration.</p>"
401+
"VietnamAdditionalInfo$enterpriseIdentificationNumber": "<p>The enterprise identification number for tax registration. This field must be provided for successful API operation.</p>"
384402
}
385403
},
386404
"EntityExemptionAccountStatus": {
@@ -455,7 +473,7 @@
455473
"refs": {
456474
"DeleteSupplementalTaxRegistrationRequest$authorityId": "<p> The unique authority Id for the supplemental TRN information that needs to be deleted. </p>",
457475
"PutSupplementalTaxRegistrationResponse$authorityId": "<p> Unique authority ID for the supplemental TRN information that was stored. </p>",
458-
"PutTaxExemptionRequest$exemptionType": "<p>The exemption type. </p>",
476+
"PutTaxExemptionRequest$exemptionType": "<p>The exemption type. Use the supported tax exemption type description. </p>",
459477
"PutTaxExemptionResponse$caseId": "<p>The customer support case ID. </p>",
460478
"SupplementalTaxRegistration$authorityId": "<p> Unique authority ID for the supplemental TRN. </p>",
461479
"TaxExemptionDetails$heritageObtainedParentEntity": "<p>The consolidated billing family management account the tax exemption inherited from. </p>",
@@ -704,7 +722,7 @@
704722
"PaymentVoucherNumber": {
705723
"base": null,
706724
"refs": {
707-
"VietnamAdditionalInfo$paymentVoucherNumber": "<p>The payment voucher number on the tax return payment document.</p>"
725+
"VietnamAdditionalInfo$paymentVoucherNumber": "<p>The payment voucher number on the tax return payment document. This field must be provided for successful API operation.</p>"
708726
}
709727
},
710728
"PersonType": {
@@ -742,6 +760,12 @@
742760
"refs": {
743761
}
744762
},
763+
"PutTaxExemptionRequestAccountIdsList": {
764+
"base": null,
765+
"refs": {
766+
"PutTaxExemptionRequest$accountIds": "<p> The list of unique account identifiers. </p>"
767+
}
768+
},
745769
"PutTaxExemptionResponse": {
746770
"base": null,
747771
"refs": {
@@ -1052,7 +1076,7 @@
10521076
"TaxRegistrationType": {
10531077
"base": null,
10541078
"refs": {
1055-
"TaxRegistration$registrationType": "<p>Type of your tax registration. This can be either <code>VAT</code> or <code>GST</code>. </p>",
1079+
"TaxRegistration$registrationType": "<p>Type of your tax registration. </p>",
10561080
"TaxRegistrationEntry$registrationType": "<p> Your tax registration type. This can be either <code>VAT</code> or <code>GST</code>. </p>",
10571081
"TaxRegistrationWithJurisdiction$registrationType": "<p> The type of your tax registration. This can be either <code>VAT</code> or <code>GST</code>. </p>"
10581082
}

‎generator/ServiceModels/taxsettings/taxsettings-2018-05-10.normal.json

Lines changed: 36 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -325,9 +325,7 @@
325325
},
326326
"AccountIds":{
327327
"type":"list",
328-
"member":{"shape":"AccountId"},
329-
"max":5,
330-
"min":1
328+
"member":{"shape":"AccountId"}
331329
},
332330
"AccountMetaData":{
333331
"type":"structure",
@@ -651,11 +649,17 @@
651649
"required":["accountIds"],
652650
"members":{
653651
"accountIds":{
654-
"shape":"AccountIds",
652+
"shape":"BatchDeleteTaxRegistrationRequestAccountIdsList",
655653
"documentation":"<p>List of unique account identifiers. </p>"
656654
}
657655
}
658656
},
657+
"BatchDeleteTaxRegistrationRequestAccountIdsList":{
658+
"type":"list",
659+
"member":{"shape":"AccountId"},
660+
"max":5,
661+
"min":1
662+
},
659663
"BatchDeleteTaxRegistrationResponse":{
660664
"type":"structure",
661665
"required":["errors"],
@@ -671,11 +675,17 @@
671675
"required":["accountIds"],
672676
"members":{
673677
"accountIds":{
674-
"shape":"AccountIds",
678+
"shape":"BatchGetTaxExemptionsRequestAccountIdsList",
675679
"documentation":"<p> List of unique account identifiers. </p>"
676680
}
677681
}
678682
},
683+
"BatchGetTaxExemptionsRequestAccountIdsList":{
684+
"type":"list",
685+
"member":{"shape":"AccountId"},
686+
"max":5,
687+
"min":1
688+
},
679689
"BatchGetTaxExemptionsResponse":{
680690
"type":"structure",
681691
"members":{
@@ -723,7 +733,7 @@
723733
],
724734
"members":{
725735
"accountIds":{
726-
"shape":"AccountIds",
736+
"shape":"BatchPutTaxRegistrationRequestAccountIdsList",
727737
"documentation":"<p> List of unique account identifiers.</p>"
728738
},
729739
"taxRegistrationEntry":{
@@ -732,6 +742,12 @@
732742
}
733743
}
734744
},
745+
"BatchPutTaxRegistrationRequestAccountIdsList":{
746+
"type":"list",
747+
"member":{"shape":"AccountId"},
748+
"max":550,
749+
"min":1
750+
},
735751
"BatchPutTaxRegistrationResponse":{
736752
"type":"structure",
737753
"required":["errors"],
@@ -1433,7 +1449,7 @@
14331449
},
14341450
"PaymentVoucherNumber":{
14351451
"type":"string",
1436-
"pattern":"^\\d{17}$"
1452+
"pattern":"^(\\d{17}|[A-Za-z]{3}\\d{13})$"
14371453
},
14381454
"PersonType":{
14391455
"type":"string",
@@ -1500,17 +1516,23 @@
15001516
],
15011517
"members":{
15021518
"accountIds":{
1503-
"shape":"AccountIds",
1519+
"shape":"PutTaxExemptionRequestAccountIdsList",
15041520
"documentation":"<p> The list of unique account identifiers. </p>"
15051521
},
15061522
"authority":{"shape":"Authority"},
15071523
"exemptionCertificate":{"shape":"ExemptionCertificate"},
15081524
"exemptionType":{
15091525
"shape":"GenericString",
1510-
"documentation":"<p>The exemption type. </p>"
1526+
"documentation":"<p>The exemption type. Use the supported tax exemption type description. </p>"
15111527
}
15121528
}
15131529
},
1530+
"PutTaxExemptionRequestAccountIdsList":{
1531+
"type":"list",
1532+
"member":{"shape":"AccountId"},
1533+
"max":550,
1534+
"min":1
1535+
},
15141536
"PutTaxExemptionResponse":{
15151537
"type":"structure",
15161538
"members":{
@@ -1968,7 +1990,7 @@
19681990
},
19691991
"registrationType":{
19701992
"shape":"TaxRegistrationType",
1971-
"documentation":"<p>Type of your tax registration. This can be either <code>VAT</code> or <code>GST</code>. </p>"
1993+
"documentation":"<p>Type of your tax registration. </p>"
19721994
},
19731995
"sector":{
19741996
"shape":"Sector",
@@ -2264,19 +2286,19 @@
22642286
"members":{
22652287
"electronicTransactionCodeNumber":{
22662288
"shape":"ElectronicTransactionCodeNumber",
2267-
"documentation":"<p>The electronic transaction code number on the tax return document.</p>"
2289+
"documentation":"<p>The electronic transaction code number on the tax return document. This field must be provided for successful API operation.</p>"
22682290
},
22692291
"enterpriseIdentificationNumber":{
22702292
"shape":"EnterpriseIdentificationNumber",
2271-
"documentation":"<p>The enterprise identification number for tax registration.</p>"
2293+
"documentation":"<p>The enterprise identification number for tax registration. This field must be provided for successful API operation.</p>"
22722294
},
22732295
"paymentVoucherNumber":{
22742296
"shape":"PaymentVoucherNumber",
2275-
"documentation":"<p>The payment voucher number on the tax return payment document.</p>"
2297+
"documentation":"<p>The payment voucher number on the tax return payment document. This field must be provided for successful API operation.</p>"
22762298
},
22772299
"paymentVoucherNumberDate":{
22782300
"shape":"DateString",
2279-
"documentation":"<p>The date on the tax return payment document.</p>"
2301+
"documentation":"<p>The date on the tax return payment document. This field must be provided for successful API operation.</p>"
22802302
}
22812303
},
22822304
"documentation":"<p>Additional tax information to specify for a TRN in Vietnam.</p>"

‎sdk/code-analysis/ServiceAnalysis/TaxSettings/Generated/PropertyValueRules.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -533,7 +533,7 @@
533533
</property-value-rule>
534534
<property-value-rule>
535535
<property>Amazon.TaxSettings.Model.VietnamAdditionalInfo.PaymentVoucherNumber</property>
536-
<pattern>^\d{17}$</pattern>
536+
<pattern>^(\d{17}|[A-Za-z]{3}\d{13})$</pattern>
537537
</property-value-rule>
538538
<property-value-rule>
539539
<property>Amazon.TaxSettings.Model.VietnamAdditionalInfo.PaymentVoucherNumberDate</property>

‎sdk/src/Services/TaxSettings/Generated/Model/BatchGetTaxExemptionsResponse.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ public partial class BatchGetTaxExemptionsResponse : AmazonWebServiceResponse
4343
/// The list of accounts that failed to get tax exemptions.
4444
/// </para>
4545
/// </summary>
46-
[AWSProperty(Min=1, Max=5)]
4746
public List<string> FailedAccounts
4847
{
4948
get { return this._failedAccounts; }

‎sdk/src/Services/TaxSettings/Generated/Model/BatchPutTaxRegistrationRequest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ public partial class BatchPutTaxRegistrationRequest : AmazonTaxSettingsRequest
269269
/// List of unique account identifiers.
270270
/// </para>
271271
/// </summary>
272-
[AWSProperty(Required=true, Min=1, Max=5)]
272+
[AWSProperty(Required=true, Min=1, Max=550)]
273273
public List<string> AccountIds
274274
{
275275
get { return this._accountIds; }

0 commit comments

Comments
 (0)