Skip to content

Commit 454aa3c

Browse files
Add input validations for multiple Glue APIs
1 parent 6e69620 commit 454aa3c

File tree

8 files changed

+67
-11
lines changed

8 files changed

+67
-11
lines changed

generator/ServiceModels/glue/glue-2017-03-31.api.json

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5867,7 +5867,8 @@
58675867
},
58685868
"ConditionList":{
58695869
"type":"list",
5870-
"member":{"shape":"Condition"}
5870+
"member":{"shape":"Condition"},
5871+
"max":500
58715872
},
58725873
"ConfigValueString":{
58735874
"type":"string",
@@ -6045,6 +6046,15 @@
60456046
"FAILED"
60466047
]
60476048
},
6049+
"ConnectionString":{
6050+
"type":"string",
6051+
"max":255
6052+
},
6053+
"ConnectionStringList":{
6054+
"type":"list",
6055+
"member":{"shape":"ConnectionString"},
6056+
"max":1000
6057+
},
60486058
"ConnectionType":{
60496059
"type":"string",
60506060
"enum":[
@@ -6094,7 +6104,7 @@
60946104
"ConnectionsList":{
60956105
"type":"structure",
60966106
"members":{
6097-
"Connections":{"shape":"OrchestrationStringList"}
6107+
"Connections":{"shape":"ConnectionStringList"}
60986108
}
60996109
},
61006110
"ConnectorDataSource":{
@@ -7007,7 +7017,7 @@
70077017
"required":["Name"],
70087018
"members":{
70097019
"Name":{"shape":"NameString"},
7010-
"Description":{"shape":"GenericString"},
7020+
"Description":{"shape":"WorkflowDescriptionString"},
70117021
"DefaultRunProperties":{"shape":"WorkflowRunProperties"},
70127022
"Tags":{"shape":"TagsMap"},
70137023
"MaxConcurrentRuns":{"shape":"NullableInteger"}
@@ -16225,7 +16235,7 @@
1622516235
"required":["Name"],
1622616236
"members":{
1622716237
"Name":{"shape":"NameString"},
16228-
"Description":{"shape":"GenericString"},
16238+
"Description":{"shape":"WorkflowDescriptionString"},
1622916239
"DefaultRunProperties":{"shape":"WorkflowRunProperties"},
1623016240
"MaxConcurrentRuns":{"shape":"NullableInteger"}
1623116241
}
@@ -16476,6 +16486,10 @@
1647616486
"BlueprintDetails":{"shape":"BlueprintDetails"}
1647716487
}
1647816488
},
16489+
"WorkflowDescriptionString":{
16490+
"type":"string",
16491+
"max":120000
16492+
},
1647916493
"WorkflowGraph":{
1648016494
"type":"structure",
1648116495
"members":{

generator/ServiceModels/glue/glue-2017-03-31.docs.json

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1956,6 +1956,18 @@
19561956
"CreateConnectionResponse$CreateConnectionStatus": "<p>The status of the connection creation request. The request can take some time for certain authentication types, for example when creating an OAuth connection with token exchange over VPC.</p>"
19571957
}
19581958
},
1959+
"ConnectionString": {
1960+
"base": null,
1961+
"refs": {
1962+
"ConnectionStringList$member": null
1963+
}
1964+
},
1965+
"ConnectionStringList": {
1966+
"base": null,
1967+
"refs": {
1968+
"ConnectionsList$Connections": "<p>A list of connections used by the job.</p>"
1969+
}
1970+
},
19591971
"ConnectionType": {
19601972
"base": null,
19611973
"refs": {
@@ -4362,7 +4374,6 @@
43624374
"CreateDevEndpointResponse$ExtraJarsS3Path": "<p>Path to one or more Java <code>.jar</code> files in an S3 bucket that will be loaded in your <code>DevEndpoint</code>.</p>",
43634375
"CreateDevEndpointResponse$FailureReason": "<p>The reason for a current failure in this <code>DevEndpoint</code>.</p>",
43644376
"CreateTriggerRequest$Schedule": "<p>A <code>cron</code> expression used to specify the schedule (see <a href=\"https://docs.aws.amazon.com/glue/latest/dg/monitor-data-warehouse-schedule.html\">Time-Based Schedules for Jobs and Crawlers</a>. For example, to run something every day at 12:15 UTC, you would specify: <code>cron(15 12 * * ? *)</code>.</p> <p>This field is required when the trigger type is SCHEDULED.</p>",
4365-
"CreateWorkflowRequest$Description": "<p>A description of the workflow.</p>",
43664377
"DQAdditionalOptions$value": null,
43674378
"DataQualityResult$EvaluationContext": "<p>In the context of a job in Glue Studio, each node in the canvas is typically assigned some sort of name and data quality nodes will have names. In the case of multiple nodes, the <code>evaluationContext</code> can differentiate the nodes.</p>",
43684379
"DeleteDevEndpointRequest$EndpointName": "<p>The name of the <code>DevEndpoint</code>.</p>",
@@ -4442,7 +4453,6 @@
44424453
"TriggerUpdate$Schedule": "<p>A <code>cron</code> expression used to specify the schedule (see <a href=\"https://docs.aws.amazon.com/glue/latest/dg/monitor-data-warehouse-schedule.html\">Time-Based Schedules for Jobs and Crawlers</a>. For example, to run something every day at 12:15 UTC, you would specify: <code>cron(15 12 * * ? *)</code>.</p>",
44434454
"UpdateDevEndpointRequest$EndpointName": "<p>The name of the <code>DevEndpoint</code> to be updated.</p>",
44444455
"UpdateDevEndpointRequest$PublicKey": "<p>The public key for the <code>DevEndpoint</code> to use.</p>",
4445-
"UpdateWorkflowRequest$Description": "<p>The description of the workflow.</p>",
44464456
"Workflow$Description": "<p>A description of the workflow.</p>",
44474457
"WorkflowRunProperties$value": null
44484458
}
@@ -7898,7 +7908,6 @@
78987908
"OrchestrationStringList": {
78997909
"base": null,
79007910
"refs": {
7901-
"ConnectionsList$Connections": "<p>A list of connections used by the job.</p>",
79027911
"StatementOutput$Traceback": "<p>The traceback of the output.</p>"
79037912
}
79047913
},
@@ -11409,6 +11418,13 @@
1140911418
"Workflows$member": null
1141011419
}
1141111420
},
11421+
"WorkflowDescriptionString": {
11422+
"base": null,
11423+
"refs": {
11424+
"CreateWorkflowRequest$Description": "<p>A description of the workflow.</p>",
11425+
"UpdateWorkflowRequest$Description": "<p>The description of the workflow.</p>"
11426+
}
11427+
},
1141211428
"WorkflowGraph": {
1141311429
"base": "<p>A workflow graph represents the complete workflow containing all the Glue components present in the workflow and all the directed connections between them.</p>",
1141411430
"refs": {

generator/ServiceModels/glue/glue-2017-03-31.normal.json

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7557,7 +7557,8 @@
75577557
},
75587558
"ConditionList":{
75597559
"type":"list",
7560-
"member":{"shape":"Condition"}
7560+
"member":{"shape":"Condition"},
7561+
"max":500
75617562
},
75627563
"ConfigValueString":{
75637564
"type":"string",
@@ -7864,6 +7865,15 @@
78647865
"FAILED"
78657866
]
78667867
},
7868+
"ConnectionString":{
7869+
"type":"string",
7870+
"max":255
7871+
},
7872+
"ConnectionStringList":{
7873+
"type":"list",
7874+
"member":{"shape":"ConnectionString"},
7875+
"max":1000
7876+
},
78677877
"ConnectionType":{
78687878
"type":"string",
78697879
"enum":[
@@ -7924,7 +7934,7 @@
79247934
"type":"structure",
79257935
"members":{
79267936
"Connections":{
7927-
"shape":"OrchestrationStringList",
7937+
"shape":"ConnectionStringList",
79287938
"documentation":"<p>A list of connections used by the job.</p>"
79297939
}
79307940
},
@@ -9860,7 +9870,7 @@
98609870
"documentation":"<p>The name to be assigned to the workflow. It should be unique within your account.</p>"
98619871
},
98629872
"Description":{
9863-
"shape":"GenericString",
9873+
"shape":"WorkflowDescriptionString",
98649874
"documentation":"<p>A description of the workflow.</p>"
98659875
},
98669876
"DefaultRunProperties":{
@@ -26652,7 +26662,7 @@
2665226662
"documentation":"<p>Name of the workflow to be updated.</p>"
2665326663
},
2665426664
"Description":{
26655-
"shape":"GenericString",
26665+
"shape":"WorkflowDescriptionString",
2665626666
"documentation":"<p>The description of the workflow.</p>"
2665726667
},
2665826668
"DefaultRunProperties":{
@@ -27104,6 +27114,10 @@
2710427114
},
2710527115
"documentation":"<p>A workflow is a collection of multiple dependent Glue jobs and crawlers that are run to complete a complex ETL task. A workflow manages the execution and monitoring of all its jobs and crawlers.</p>"
2710627116
},
27117+
"WorkflowDescriptionString":{
27118+
"type":"string",
27119+
"max":120000
27120+
},
2710727121
"WorkflowGraph":{
2710827122
"type":"structure",
2710927123
"members":{

sdk/code-analysis/ServiceAnalysis/Glue/Generated/PropertyValueRules.xml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -721,6 +721,10 @@
721721
<min>1</min>
722722
<max>255</max>
723723
</property-value-rule>
724+
<property-value-rule>
725+
<property>Amazon.Glue.Model.CreateWorkflowRequest.Description</property>
726+
<max>120000</max>
727+
</property-value-rule>
724728
<property-value-rule>
725729
<property>Amazon.Glue.Model.CreateWorkflowRequest.Name</property>
726730
<min>1</min>
@@ -3457,6 +3461,10 @@
34573461
<min>1</min>
34583462
<max>255</max>
34593463
</property-value-rule>
3464+
<property-value-rule>
3465+
<property>Amazon.Glue.Model.UpdateWorkflowRequest.Description</property>
3466+
<max>120000</max>
3467+
</property-value-rule>
34603468
<property-value-rule>
34613469
<property>Amazon.Glue.Model.UpdateWorkflowRequest.Name</property>
34623470
<min>1</min>

sdk/src/Services/Glue/Generated/Model/ConnectionsList.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ public partial class ConnectionsList
4242
/// A list of connections used by the job.
4343
/// </para>
4444
/// </summary>
45+
[AWSProperty(Max=1000)]
4546
public List<string> Connections
4647
{
4748
get { return this._connections; }

sdk/src/Services/Glue/Generated/Model/CreateWorkflowRequest.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ internal bool IsSetDefaultRunProperties()
7171
/// A description of the workflow.
7272
/// </para>
7373
/// </summary>
74+
[AWSProperty(Max=120000)]
7475
public string Description
7576
{
7677
get { return this._description; }

sdk/src/Services/Glue/Generated/Model/Predicate.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ public partial class Predicate
4343
/// A list of the conditions that determine when the trigger will fire.
4444
/// </para>
4545
/// </summary>
46+
[AWSProperty(Max=500)]
4647
public List<Condition> Conditions
4748
{
4849
get { return this._conditions; }

sdk/src/Services/Glue/Generated/Model/UpdateWorkflowRequest.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ internal bool IsSetDefaultRunProperties()
7070
/// The description of the workflow.
7171
/// </para>
7272
/// </summary>
73+
[AWSProperty(Max=120000)]
7374
public string Description
7475
{
7576
get { return this._description; }

0 commit comments

Comments
 (0)