Add query-compatible protocol tests (#3896)

* Protocol test project updates

* Generator updates. New protocol test C2J files and updates to tt files

* Add generated protocol tests and generate protocol test services

* Generated service changes and updates to solution files

* Fix type on devconfig

Author: peterrsongg

generator/.DevConfigs/08424ec7-251c-4c0e-afbe-dda1f0ae7757.json

@@ -0,0 +1,9 @@
+{
+  "core": {
+    "updateMinimum": true,
+    "type": "patch",
+    "changeLogMessages": [
+      "Add new protocol tests. Update JSON response unmarshallers to return safely if the service returns an empty string as a response instead of an empty json body"
+    ]
+  }
+}

generator/ProtocolTestsGenerator/settings.gradle.kts

@@ -12,7 +12,7 @@ pluginManagement {
 dependencyResolutionManagement {
     versionCatalogs {
         create("codegen") {
-            version("smithy", "1.54.0")
+            version("smithy", "1.60.3")
             library("protocol-tests", "software.amazon.smithy", "smithy-aws-protocol-tests").versionRef("smithy")
             library("codegen-core", "software.amazon.smithy", "smithy-codegen-core").versionRef("smithy")
             library("protocol-tests-traits", "software.amazon.smithy", "smithy-protocol-test-traits").versionRef("smithy")

generator/ProtocolTestsGenerator/smithy-dotnet-codegen/src/main/java/software/amazon/smithy/dotnet/codegen/HttpProtocolTestGenerator.java

@@ -94,7 +94,9 @@ private void generateErrorResponseTests(OperationShape operation, OperationIndex
         for (StructureShape error : index.getErrors(operation, service)) {
             error.getTrait(HttpResponseTestsTrait.class).ifPresent(trait -> {
                 for (HttpResponseTestCase httpResponseTestCase : trait.getTestCasesFor(AppliesTo.CLIENT)) {
-                    generateErrorResponseTest(operation, error, httpResponseTestCase);
+                    if (!ProtocolTestCustomizations.TestsToSkip.contains(httpResponseTestCase.getId())){
+                        generateErrorResponseTest(operation, error, httpResponseTestCase);
+                    }
                 }
             });
         }

generator/ProtocolTestsGenerator/smithy-dotnet-codegen/src/main/java/software/amazon/smithy/dotnet/codegen/customizations/ProtocolTestCustomizations.java

@@ -96,7 +96,12 @@ private ProtocolTestCustomizations() {
             // to use exceptions and control flow.
             "QueryEmptyInputAndEmptyOutput",
             "QueryNoInputAndNoOutput",
-            "QueryNoInputAndOutput"
+            "QueryNoInputAndOutput",
+            // this test is skipped because in the C2J Ruby added a hook which adds the "code" json key which can NEVER exist in a
+            // non-query protocol. this causes our code generation to check on this code instead of what is modeled and our protocol
+            // test passes. As this can never happen in a real service, we can skip this to avoid unnecessary customizations in the generator
+            // for a scenario that will never happen.
+            "QueryCompatibleAwsJson10CustomCodeError"
     );
     public static final List<String> VNextTests = Arrays.asList(
             //These are the tests that are failing in v4 after updating to 1.54.0 and artifacts 1.0.3004.0. Each one needs to be investigated.

generator/ProtocolTestsGenerator/smithy-dotnet-protocol-test/smithy-build.json

@@ -127,6 +127,24 @@
           "packageVersion": "0.0.1"
         }
       }
+    },
+    "QueryCompatibleJSONRPC10": {
+      "transforms": [
+        {
+          "name": "includeServices",
+          "args": {
+            "services": [
+              "aws.protocoltests.json10#QueryCompatibleJsonRpc10"
+            ]
+          }
+        }
+      ],
+      "plugins": {
+        "dotnet-protocol-test-codegen": {
+          "service": "aws.protocoltests.json10#QueryCompatibleJsonRpc10",
+          "packageVersion": "0.0.1"
+        }
+      }
     }
   }
 }

generator/ServiceClientGeneratorLib/Generators/Marshallers/JsonRPCResponseUnmarshaller.cs

@@ -91,6 +91,7 @@ namespace <#=this.Config.Namespace #>.Model.Internal.MarshallTransformations
         {
 #>
             StreamingUtf8JsonReader reader = new StreamingUtf8JsonReader(context.Stream);
+            if (reader.Reader.IsFinalBlock) return response;
             var unmarshaller = <#= payload.DetermineTypeUnmarshallerInstantiate() #>;
             response.<#=payload.PropertyName#> = unmarshaller.Unmarshall(context, ref reader);
 <#

generator/ServiceClientGeneratorLib/Generators/Marshallers/JsonRPCResponseUnmarshaller.tt

@@ -114,6 +114,14 @@
       "input":{"shape":"PutWithContentEncodingInput"},
       "requestcompression":{"encodings":["gzip"]}
     },
+    "QueryIncompatibleOperation":{
+      "name":"QueryIncompatibleOperation",
+      "http":{
+        "method":"POST",
+        "requestUri":"/"
+      },
+      "idempotent":true
+    },
     "SimpleScalarProperties":{
       "name":"SimpleScalarProperties",
       "http":{
@@ -153,22 +161,19 @@
     },
     "ContentTypeParametersOutput":{
       "type":"structure",
-      "members":{
-      }
+      "members":{}
     },
     "Double":{
       "type":"double",
       "box":true
     },
     "EmptyInputAndEmptyOutputInput":{
       "type":"structure",
-      "members":{
-      }
+      "members":{}
     },
     "EmptyInputAndEmptyOutputOutput":{
       "type":"structure",
-      "members":{
-      }
+      "members":{}
     },
     "EndpointWithHostLabelOperationInput":{
       "type":"structure",
@@ -196,8 +201,7 @@
     },
     "FooError":{
       "type":"structure",
-      "members":{
-      },
+      "members":{},
       "documentation":"<p>This error has test cases that test some of the dark corners of Amazon service framework history. It should only be implemented by clients.</p>",
       "exception":true,
       "fault":true
@@ -267,8 +271,7 @@
     },
     "NoInputAndOutputOutput":{
       "type":"structure",
-      "members":{
-      }
+      "members":{}
     },
     "PutWithContentEncodingInput":{
       "type":"structure",

generator/TestServiceModels/json10-tests-client/json-rpc-10-2020-07-14.normal.json

@@ -211,8 +211,7 @@
     },
     "ContentTypeParametersOutput":{
       "type":"structure",
-      "members":{
-      }
+      "members":{}
     },
     "DateTime":{
       "type":"timestamp",
@@ -226,8 +225,7 @@
     },
     "Document":{
       "type":"structure",
-      "members":{
-      },
+      "members":{},
       "document":true
     },
     "Double":{
@@ -236,8 +234,7 @@
     },
     "EmptyStruct":{
       "type":"structure",
-      "members":{
-      }
+      "members":{}
     },
     "ErrorWithMembers":{
       "type":"structure",
@@ -257,8 +254,7 @@
     },
     "ErrorWithoutMembers":{
       "type":"structure",
-      "members":{
-      },
+      "members":{},
       "exception":true,
       "fault":true
     },
@@ -291,8 +287,7 @@
     },
     "FooError":{
       "type":"structure",
-      "members":{
-      },
+      "members":{},
       "documentation":"<p>This error has test cases that test some of the dark corners of Amazon service framework history. It should only be implemented by clients.</p>",
       "exception":true,
       "fault":true

generator/TestServiceModels/json11-tests-client/json-protocol-2018-01-01.normal.json

@@ -0,0 +1,5 @@
+{
+  "active": true,
+  "test-service": true,
+  "synopsis": "query-compatible test service"
+}