Skip to content

Commit 8a114a3

Browse files
This release removes hookDetails for the Amazon ECS native blue/green deployments.
1 parent 5b6b37d commit 8a114a3

19 files changed

+165
-158
lines changed

generator/ServiceModels/ecs/ecs-2014-11-13.api.json

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1824,8 +1824,7 @@
18241824
"members":{
18251825
"hookTargetArn":{"shape":"String"},
18261826
"roleArn":{"shape":"IAMRoleArn"},
1827-
"lifecycleStages":{"shape":"DeploymentLifecycleHookStageList"},
1828-
"hookDetails":{"shape":"HookDetails"}
1827+
"lifecycleStages":{"shape":"DeploymentLifecycleHookStageList"}
18291828
}
18301829
},
18311830
"DeploymentLifecycleHookList":{
@@ -2335,11 +2334,6 @@
23352334
"UNKNOWN"
23362335
]
23372336
},
2338-
"HookDetails":{
2339-
"type":"structure",
2340-
"members":{},
2341-
"document":true
2342-
},
23432337
"HostEntry":{
23442338
"type":"structure",
23452339
"required":[

generator/ServiceModels/ecs/ecs-2014-11-13.docs.json

Lines changed: 13 additions & 19 deletions
Large diffs are not rendered by default.

generator/ServiceModels/ecs/ecs-2014-11-13.normal.json

Lines changed: 13 additions & 22 deletions
Large diffs are not rendered by default.

sdk/src/Services/ECS/Generated/Model/AdvancedConfiguration.cs

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public partial class AdvancedConfiguration
4747
/// Gets and sets the property AlternateTargetGroupArn.
4848
/// <para>
4949
/// The Amazon Resource Name (ARN) of the alternate target group for Amazon ECS blue/green
50-
/// deployments.
50+
/// deployments.
5151
/// </para>
5252
/// </summary>
5353
public string AlternateTargetGroupArn
@@ -65,8 +65,9 @@ internal bool IsSetAlternateTargetGroupArn()
6565
/// <summary>
6666
/// Gets and sets the property ProductionListenerRule.
6767
/// <para>
68-
/// The Amazon Resource Name (ARN) that identifies the production listener rule for routing
69-
/// production traffic.
68+
/// The Amazon Resource Name (ARN) that that identifies the production listener rule (in
69+
/// the case of an Application Load Balancer) or listener (in the case for an Network
70+
/// Load Balancer) for routing production traffic.
7071
/// </para>
7172
/// </summary>
7273
public string ProductionListenerRule
@@ -103,8 +104,9 @@ internal bool IsSetRoleArn()
103104
/// <summary>
104105
/// Gets and sets the property TestListenerRule.
105106
/// <para>
106-
/// The Amazon Resource Name (ARN) that identifies the test listener rule or listener
107-
/// for routing test traffic.
107+
/// The Amazon Resource Name (ARN) that identifies ) that identifies the test listener
108+
/// rule (in the case of an Application Load Balancer) or listener (in the case for an
109+
/// Network Load Balancer) for routing test traffic.
108110
/// </para>
109111
/// </summary>
110112
public string TestListenerRule

sdk/src/Services/ECS/Generated/Model/CreateServiceRequest.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,9 @@ namespace Amazon.ECS.Model
102102
/// </para>
103103
///
104104
/// <para>
105-
/// When you create a service which uses the <c>ECS</c> deployment controller, you can
106-
/// choose between the following deployment strategies:
105+
/// When you create a service which uses the <c>ECS</c> deployment controller, you can
106+
/// choose between the following deployment strategies (which you can set in the “<c>strategy</c>”
107+
/// field in “<c>deploymentConfiguration</c>”): :
107108
/// </para>
108109
/// <ul> <li>
109110
/// <para>

sdk/src/Services/ECS/Generated/Model/DeploymentAlarms.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ namespace Amazon.ECS.Model
4242
///
4343
/// <para>
4444
/// You can only use the <c>DeploymentAlarms</c> method to detect failures when the <c>DeploymentController</c>
45-
/// is set to <c>ECS</c> (rolling update).
45+
/// is set to <c>ECS</c>.
4646
/// </para>
4747
///
4848
/// <para>

sdk/src/Services/ECS/Generated/Model/DeploymentConfiguration.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ internal bool IsSetAlarms()
6464
/// <summary>
6565
/// Gets and sets the property BakeTimeInMinutes.
6666
/// <para>
67-
/// The duration when both blue and green service revisions are running simultaneously
67+
/// The time period when both blue and green service revisions are running simultaneously
6868
/// after the production traffic has shifted.
6969
/// </para>
7070
///
@@ -117,8 +117,7 @@ internal bool IsSetDeploymentCircuitBreaker()
117117
/// Gets and sets the property LifecycleHooks.
118118
/// <para>
119119
/// An array of deployment lifecycle hook objects to run custom logic at specific stages
120-
/// of the deployment lifecycle. These hooks allow you to run custom logic at key points
121-
/// during the deployment process.
120+
/// of the deployment lifecycle.
122121
/// </para>
123122
/// </summary>
124123
public List<DeploymentLifecycleHook> LifecycleHooks

sdk/src/Services/ECS/Generated/Model/DeploymentLifecycleHook.cs

Lines changed: 12 additions & 63 deletions
Original file line numberDiff line numberDiff line change
@@ -32,33 +32,20 @@ namespace Amazon.ECS.Model
3232
/// <summary>
3333
/// A deployment lifecycle hook runs custom logic at specific stages of the deployment
3434
/// process. Currently, you can use Lambda functions as hook targets.
35+
///
36+
///
37+
/// <para>
38+
/// For more information, see <a href="https://docs.aws.amazon.com/AmazonECS/latest/developerguide/deployment-lifecycle-hooks.html">Lifecycle
39+
/// hooks for Amazon ECS service deployments</a> in the <i> Amazon Elastic Container Service
40+
/// Developer Guide</i>.
41+
/// </para>
3542
/// </summary>
3643
public partial class DeploymentLifecycleHook
3744
{
38-
private Amazon.Runtime.Documents.Document _hookDetails;
3945
private string _hookTargetArn;
4046
private List<string> _lifecycleStages = AWSConfigs.InitializeCollections ? new List<string>() : null;
4147
private string _roleArn;
4248

43-
/// <summary>
44-
/// Gets and sets the property HookDetails.
45-
/// <para>
46-
/// Optionally provide details about the hook. Use this field to pass custom parameters
47-
/// to your hook target (such as a Lambda function).
48-
/// </para>
49-
/// </summary>
50-
public Amazon.Runtime.Documents.Document HookDetails
51-
{
52-
get { return this._hookDetails; }
53-
set { this._hookDetails = value; }
54-
}
55-
56-
// Check to see if HookDetails property is set
57-
internal bool IsSetHookDetails()
58-
{
59-
return !this._hookDetails.IsNull();
60-
}
61-
6249
/// <summary>
6350
/// Gets and sets the property HookTargetArn.
6451
/// <para>
@@ -93,8 +80,8 @@ internal bool IsSetHookTargetArn()
9380
/// </para>
9481
///
9582
/// <para>
96-
/// This stage only happens when you start a new service deployment with more than 1 service
97-
/// revision in an ACTIVE state.
83+
/// The reconciliation stage that only happens when you start a new service deployment
84+
/// with more than 1 service revision in an ACTIVE state.
9885
/// </para>
9986
///
10087
/// <para>
@@ -115,19 +102,6 @@ internal bool IsSetHookTargetArn()
115102
/// </para>
116103
/// </li> <li>
117104
/// <para>
118-
/// SCALE_UP
119-
/// </para>
120-
///
121-
/// <para>
122-
/// The time when the green service revision scales up to 100% and launches new tasks.
123-
/// The green service revision is not serving any traffic at this point.
124-
/// </para>
125-
///
126-
/// <para>
127-
/// You can't use a lifecycle hook for this stage.
128-
/// </para>
129-
/// </li> <li>
130-
/// <para>
131105
/// POST_SCALE_UP
132106
/// </para>
133107
///
@@ -189,32 +163,7 @@ internal bool IsSetHookTargetArn()
189163
/// </para>
190164
///
191165
/// <para>
192-
/// Yes
193-
/// </para>
194-
/// </li> <li>
195-
/// <para>
196-
/// BAKE_TIME
197-
/// </para>
198-
///
199-
/// <para>
200-
/// The duration when both blue and green service revisions are running simultaneously.
201-
/// </para>
202-
///
203-
/// <para>
204-
/// You can't use a lifecycle hook for this stage.
205-
/// </para>
206-
/// </li> <li>
207-
/// <para>
208-
/// CLEAN_UP
209-
/// </para>
210-
///
211-
/// <para>
212-
/// The blue service revision has completely scaled down to 0 running tasks. The green
213-
/// service revision is now the production service revision after this stage.
214-
/// </para>
215-
///
216-
/// <para>
217-
/// You can't use a lifecycle hook for this stage.
166+
/// You can use a lifecycle hook for this stage.
218167
/// </para>
219168
/// </li> </ul>
220169
/// <para>
@@ -242,8 +191,8 @@ internal bool IsSetLifecycleStages()
242191
///
243192
/// <para>
244193
/// For more information, see <a href="https://docs.aws.amazon.com/AmazonECS/latest/developerguide/blue-green-permissions.html">Permissions
245-
/// required for Lambda functions in Amazon ECS blue/green deployments</a> in the<i> Amazon
246-
/// Elastic Container Service Developer Guide</i>.
194+
/// required for Lambda functions in Amazon ECS blue/green deployments</a> in the <i>
195+
/// Amazon Elastic Container Service Developer Guide</i>.
247196
/// </para>
248197
/// </summary>
249198
public string RoleArn

sdk/src/Services/ECS/Generated/Model/Internal/MarshallTransformations/DeploymentLifecycleHookMarshaller.cs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,6 @@ public void Marshall(DeploymentLifecycleHook requestObject, JsonMarshallerContex
4848
{
4949
if(requestObject == null)
5050
return;
51-
if(requestObject.IsSetHookDetails())
52-
{
53-
context.Writer.WritePropertyName("hookDetails");
54-
Amazon.Runtime.Documents.Internal.Transform.DocumentMarshaller.Instance.Write(context.Writer, requestObject.HookDetails);
55-
}
56-
5751
if(requestObject.IsSetHookTargetArn())
5852
{
5953
context.Writer.WritePropertyName("hookTargetArn");

sdk/src/Services/ECS/Generated/Model/Internal/MarshallTransformations/DeploymentLifecycleHookUnmarshaller.cs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -66,12 +66,6 @@ public DeploymentLifecycleHook Unmarshall(JsonUnmarshallerContext context)
6666
int targetDepth = context.CurrentDepth;
6767
while (context.ReadAtDepth(targetDepth))
6868
{
69-
if (context.TestExpression("hookDetails", targetDepth))
70-
{
71-
var unmarshaller = Amazon.Runtime.Documents.Internal.Transform.DocumentUnmarshaller.Instance;
72-
unmarshalledObject.HookDetails = unmarshaller.Unmarshall(context);
73-
continue;
74-
}
7569
if (context.TestExpression("hookTargetArn", targetDepth))
7670
{
7771
var unmarshaller = StringUnmarshaller.Instance;

0 commit comments

Comments
 (0)