Fixed an issue where NullReferenceException was thrown when calling AddPartETags() on CompleteMultipartUploadRequest object.

Author: ashishdhingra

generator/.DevConfigs/f957e2d8-fa28-425e-878a-fc657dfb625d.json

@@ -0,0 +1,9 @@
+{
+  "services": [
+    {
+      "serviceName": "S3",
+      "type": "patch",
+      "changeLogMessages": [ "Fixed an issue where NullReferenceException was thrown when calling AddPartETags() on CompleteMultipartUploadRequest object." ]
+    }
+  ]
+}

sdk/src/Services/S3/Custom/Model/CompleteMultipartUploadRequest.cs

@@ -529,6 +529,11 @@ public List<PartETag> PartETags
         /// <param name="partETags">PartETags that will added to this request.</param>
         public void AddPartETags(params PartETag[] partETags)
         {
+            if (PartETags == null)
+            {
+                PartETags = new List<PartETag>();
+            }
+
             if (partETags != null)
             {
                 foreach (PartETag part in partETags)
@@ -544,13 +549,17 @@ public void AddPartETags(params PartETag[] partETags)
         /// <param name="partETags">PartETags that will added to this request.</param>
         public void AddPartETags(IEnumerable<PartETag> partETags)
         {
-            if (partETags == null)
+            if (PartETags == null)
             {
-                partETags = new List<PartETag>();
+                PartETags = new List<PartETag>();
             }
-            foreach (PartETag part in partETags)
+
+            if (partETags != null)
             {
-                this.PartETags.Add(part);
+                foreach (PartETag part in partETags)
+                {
+                    this.PartETags.Add(part);
+                }
             }
         }
 
@@ -568,9 +577,12 @@ public void AddPartETags(params UploadPartResponse[] responses)
                 PartETags = new List<PartETag>();
             }
 
-            foreach (UploadPartResponse response in responses)
+            if (responses != null)
             {
-                this.PartETags.Add(new PartETag(response, copyChecksums: false));
+                foreach (UploadPartResponse response in responses)
+                {
+                    this.PartETags.Add(new PartETag(response, copyChecksums: false));
+                }
             }
         }
 
@@ -588,9 +600,12 @@ public void AddPartETags(IEnumerable<UploadPartResponse> responses)
                 PartETags = new List<PartETag>();
             }
 
-            foreach (UploadPartResponse response in responses)
+            if (responses != null)
             {
-                this.PartETags.Add(new PartETag(response, copyChecksums: false));
+                foreach (UploadPartResponse response in responses)
+                {
+                    this.PartETags.Add(new PartETag(response, copyChecksums: false));
+                }
             }
         }
 
@@ -605,9 +620,12 @@ public void AddPartETagsAndChecksums(params UploadPartResponse[] responses)
                 PartETags = new List<PartETag>();
             }
 
-            foreach (UploadPartResponse response in responses)
+            if (responses != null)
             {
-                this.PartETags.Add(new PartETag(response, copyChecksums: true));
+                foreach (UploadPartResponse response in responses)
+                {
+                    this.PartETags.Add(new PartETag(response, copyChecksums: true));
+                }
             }
         }
 
@@ -622,9 +640,12 @@ public void AddPartETagsAndChecksums(IEnumerable<UploadPartResponse> responses)
                 PartETags = new List<PartETag>();
             }
 
-            foreach (UploadPartResponse response in responses)
+            if (responses != null)
             {
-                this.PartETags.Add(new PartETag(response, copyChecksums: true));
+                foreach (UploadPartResponse response in responses)
+                {
+                    this.PartETags.Add(new PartETag(response, copyChecksums: true));
+                }
             }
         }
 
@@ -642,9 +663,12 @@ public void AddPartETags(params CopyPartResponse[] responses)
                 PartETags = new List<PartETag>();
             }
 
-            foreach (CopyPartResponse response in responses)
+            if (responses != null)
             {
-                this.PartETags.Add(new PartETag(response, copyChecksums: false));
+                foreach (CopyPartResponse response in responses)
+                {
+                    this.PartETags.Add(new PartETag(response, copyChecksums: false));
+                }
             }
         }
 
@@ -662,9 +686,12 @@ public void AddPartETags(IEnumerable<CopyPartResponse> responses)
                 PartETags = new List<PartETag>();
             }
 
-            foreach (CopyPartResponse response in responses)
+            if (responses != null)
             {
-                this.PartETags.Add(new PartETag(response, copyChecksums: false));
+                foreach (CopyPartResponse response in responses)
+                {
+                    this.PartETags.Add(new PartETag(response, copyChecksums: false));
+                }
             }
         }
 
@@ -679,9 +706,12 @@ public void AddPartETagsAndChecksums(params CopyPartResponse[] responses)
                 PartETags = new List<PartETag>();
             }
 
-            foreach (CopyPartResponse response in responses)
+            if (responses != null)
             {
-                this.PartETags.Add(new PartETag(response, copyChecksums: true));
+                foreach (CopyPartResponse response in responses)
+                {
+                    this.PartETags.Add(new PartETag(response, copyChecksums: true));
+                }
             }
         }
 
@@ -696,9 +726,12 @@ public void AddPartETagsAndChecksums(IEnumerable<CopyPartResponse> responses)
                 PartETags = new List<PartETag>();
             }
 
-            foreach (CopyPartResponse response in responses)
+            if (responses != null)
             {
-                this.PartETags.Add(new PartETag(response, copyChecksums: true));
+                foreach (CopyPartResponse response in responses)
+                {
+                    this.PartETags.Add(new PartETag(response, copyChecksums: true));
+                }
             }
         }