Skip to content

Commit b784c10

Browse files
authored
Add tests for services that have AwsQueryCompatible trait. Add x-amzn-query-mode header (#3861)
* first commit * non generated changes to support x-amzn-query-mode and x-amzn-query-error test cases * generated changes * Add query compatible tests, remove generated change in acm csproj and remove implicit usings
1 parent 38cd389 commit b784c10

File tree

37 files changed

+316
-53
lines changed

37 files changed

+316
-53
lines changed
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"core": {
3+
"changeLogMessages": [
4+
"Add x-amzn-query-mode header and query compatible tests. The sdk will send a new header x-amzn-query-mode, if the service has the awsQueryCompatibleTrait applied to it. This is to inform the service that the client is running in query compatible mode."
5+
],
6+
"type": "patch",
7+
"updateMinimum": true
8+
}
9+
}

generator/ServiceClientGeneratorLib/Generators/Marshallers/JsonRPCRequestMarshaller.cs

Lines changed: 59 additions & 48 deletions
Large diffs are not rendered by default.

generator/ServiceClientGeneratorLib/Generators/Marshallers/JsonRPCRequestMarshaller.tt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,12 @@ namespace <#=this.Config.Namespace #>.Model.Internal.MarshallTransformations
102102
request.HttpMethod = "<#=this.Operation.HttpMethod #>";
103103

104104
<#
105+
if (this.Config.ServiceModel.IsAwsQueryCompatible)
106+
{
107+
#>
108+
request.Headers[Amazon.Util.HeaderKeys.XAmzQueryMode] = "true";
109+
<#
110+
}
105111
var requestStructure = this.Operation.RequestStructure;
106112

107113
// Generates code to add members of the request to the request being created by the marshaller

sdk/AWSSDK.CoreAndCustomUnitTests.NetFramework.sln

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "AWSSDK.SSO.NetFramework", "
5050
EndProject
5151
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "AWSSDK.KeyManagementService.NetFramework", "src\Services\KeyManagementService\AWSSDK.KeyManagementService.NetFramework.csproj", "{F0397317-53D7-4B42-8D15-9E02083BF5D3}"
5252
EndProject
53+
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "AWSSDK.SQS.NetFramework", "src\Services\SQS\AWSSDK.SQS.NetFramework.csproj", "{0329EB93-BFEA-2ED1-DFB4-2EEA803B8902}"
54+
EndProject
5355
Global
5456
GlobalSection(SolutionConfigurationPlatforms) = preSolution
5557
Debug|Any CPU = Debug|Any CPU
@@ -140,6 +142,10 @@ Global
140142
{F0397317-53D7-4B42-8D15-9E02083BF5D3}.Debug|Any CPU.Build.0 = Debug|Any CPU
141143
{F0397317-53D7-4B42-8D15-9E02083BF5D3}.Release|Any CPU.ActiveCfg = Release|Any CPU
142144
{F0397317-53D7-4B42-8D15-9E02083BF5D3}.Release|Any CPU.Build.0 = Release|Any CPU
145+
{0329EB93-BFEA-2ED1-DFB4-2EEA803B8902}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
146+
{0329EB93-BFEA-2ED1-DFB4-2EEA803B8902}.Debug|Any CPU.Build.0 = Debug|Any CPU
147+
{0329EB93-BFEA-2ED1-DFB4-2EEA803B8902}.Release|Any CPU.ActiveCfg = Release|Any CPU
148+
{0329EB93-BFEA-2ED1-DFB4-2EEA803B8902}.Release|Any CPU.Build.0 = Release|Any CPU
143149
EndGlobalSection
144150
GlobalSection(SolutionProperties) = preSolution
145151
HideSolutionNode = FALSE
@@ -166,6 +172,7 @@ Global
166172
{4608625B-B089-49B0-A3C3-F18DC5FFCEA5} = {4CD78D56-2ABB-4F58-A0CB-08CED1B06370}
167173
{685155AC-D4AE-41ED-A76E-388D0F66D6F8} = {4CD78D56-2ABB-4F58-A0CB-08CED1B06370}
168174
{F0397317-53D7-4B42-8D15-9E02083BF5D3} = {4CD78D56-2ABB-4F58-A0CB-08CED1B06370}
175+
{0329EB93-BFEA-2ED1-DFB4-2EEA803B8902} = {4CD78D56-2ABB-4F58-A0CB-08CED1B06370}
169176
EndGlobalSection
170177
GlobalSection(ExtensibilityGlobals) = postSolution
171178
SolutionGuid = {BBAD3467-3B24-41C1-898E-1B34BB9931DE}

sdk/src/Core/Amazon.Util/HeaderKeys.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,5 +112,6 @@ public abstract class HeaderKeys
112112
public const string AmzSdkRequest = "amz-sdk-request";
113113
public const string XAmzQueryError = "x-amzn-query-error";
114114
public const string XAmzS3ExpressSessionTokenQueryParam = "X-Amz-S3session-Token";
115+
public const string XAmzQueryMode = "x-amzn-query-mode";
115116
}
116117
}

sdk/src/Services/SQS/Generated/Model/Internal/MarshallTransformations/AddPermissionRequestMarshaller.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ public IRequest Marshall(AddPermissionRequest publicRequest)
6565
request.Headers[Amazon.Util.HeaderKeys.XAmzApiVersion] = "2012-11-05";
6666
request.HttpMethod = "POST";
6767

68+
request.Headers[Amazon.Util.HeaderKeys.XAmzQueryMode] = "true";
6869
request.ResourcePath = "/";
6970
#if !NETFRAMEWORK
7071
using ArrayPoolBufferWriter<byte> arrayPoolBufferWriter = new ArrayPoolBufferWriter<byte>();

sdk/src/Services/SQS/Generated/Model/Internal/MarshallTransformations/CancelMessageMoveTaskRequestMarshaller.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ public IRequest Marshall(CancelMessageMoveTaskRequest publicRequest)
6565
request.Headers[Amazon.Util.HeaderKeys.XAmzApiVersion] = "2012-11-05";
6666
request.HttpMethod = "POST";
6767

68+
request.Headers[Amazon.Util.HeaderKeys.XAmzQueryMode] = "true";
6869
request.ResourcePath = "/";
6970
#if !NETFRAMEWORK
7071
using ArrayPoolBufferWriter<byte> arrayPoolBufferWriter = new ArrayPoolBufferWriter<byte>();

sdk/src/Services/SQS/Generated/Model/Internal/MarshallTransformations/ChangeMessageVisibilityBatchRequestMarshaller.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ public IRequest Marshall(ChangeMessageVisibilityBatchRequest publicRequest)
6565
request.Headers[Amazon.Util.HeaderKeys.XAmzApiVersion] = "2012-11-05";
6666
request.HttpMethod = "POST";
6767

68+
request.Headers[Amazon.Util.HeaderKeys.XAmzQueryMode] = "true";
6869
request.ResourcePath = "/";
6970
#if !NETFRAMEWORK
7071
using ArrayPoolBufferWriter<byte> arrayPoolBufferWriter = new ArrayPoolBufferWriter<byte>();

sdk/src/Services/SQS/Generated/Model/Internal/MarshallTransformations/ChangeMessageVisibilityRequestMarshaller.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ public IRequest Marshall(ChangeMessageVisibilityRequest publicRequest)
6565
request.Headers[Amazon.Util.HeaderKeys.XAmzApiVersion] = "2012-11-05";
6666
request.HttpMethod = "POST";
6767

68+
request.Headers[Amazon.Util.HeaderKeys.XAmzQueryMode] = "true";
6869
request.ResourcePath = "/";
6970
#if !NETFRAMEWORK
7071
using ArrayPoolBufferWriter<byte> arrayPoolBufferWriter = new ArrayPoolBufferWriter<byte>();

sdk/src/Services/SQS/Generated/Model/Internal/MarshallTransformations/CreateQueueRequestMarshaller.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ public IRequest Marshall(CreateQueueRequest publicRequest)
6565
request.Headers[Amazon.Util.HeaderKeys.XAmzApiVersion] = "2012-11-05";
6666
request.HttpMethod = "POST";
6767

68+
request.Headers[Amazon.Util.HeaderKeys.XAmzQueryMode] = "true";
6869
request.ResourcePath = "/";
6970
#if !NETFRAMEWORK
7071
using ArrayPoolBufferWriter<byte> arrayPoolBufferWriter = new ArrayPoolBufferWriter<byte>();

0 commit comments

Comments
 (0)