Skip to content

Commit 0563164

Browse files
committed
Fix connection attributes quoting. #481
1 parent d294610 commit 0563164

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

awswrangler/_databases.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import logging
44
from typing import Any, Dict, Iterator, List, NamedTuple, Optional, Tuple, Union, cast
5-
from urllib.parse import quote_plus
65

76
import boto3
87
import pandas as pd
@@ -40,8 +39,8 @@ def _get_connection_attributes_from_catalog(
4039
port, database = details["JDBC_CONNECTION_URL"].split(":")[3].split("/")
4140
return ConnectionAttributes(
4241
kind=details["JDBC_CONNECTION_URL"].split(":")[1].lower(),
43-
user=quote_plus(details["USERNAME"]),
44-
password=quote_plus(details["PASSWORD"]),
42+
user=details["USERNAME"],
43+
password=details["PASSWORD"],
4544
host=details["JDBC_CONNECTION_URL"].split(":")[2].replace("/", ""),
4645
port=int(port),
4746
database=dbname if dbname is not None else database,
@@ -63,8 +62,8 @@ def _get_connection_attributes_from_secrets_manager(
6362
_dbname = _get_dbname(cluster_id=secret_value["dbClusterIdentifier"], boto3_session=boto3_session)
6463
return ConnectionAttributes(
6564
kind=kind,
66-
user=quote_plus(secret_value["username"]),
67-
password=quote_plus(secret_value["password"]),
65+
user=secret_value["username"],
66+
password=secret_value["password"],
6867
host=secret_value["host"],
6968
port=secret_value["port"],
7069
database=_dbname,

0 commit comments

Comments
 (0)