Skip to content

Commit be0bbe4

Browse files
support for test infrastructure in private subnets (#1698)
* support for test infrastructure in private subnets * fix cfn-nag workflow issues poetry installation through pip bugged out, using the preferred method for install instead poetry 1.2+ doesn't like ubuntu's way of naming python packages (which is not PEP-440 compliant), work in a virtual env instead Co-authored-by: Lucas Hanson <[email protected]>
1 parent ed8d506 commit be0bbe4

File tree

6 files changed

+109
-83
lines changed

6 files changed

+109
-83
lines changed

.github/workflows/cfn-nag.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,12 +62,15 @@ jobs:
6262
}
6363
EOT
6464
python -m pip install --upgrade pip
65-
python -m pip install poetry==1.2.2
66-
poetry config virtualenvs.create false --local
65+
curl -sSL https://install.python-poetry.org | python - --version 1.2.2
66+
poetry env use python
67+
poetry env info
68+
source $(poetry env info --path)/bin/activate
6769
poetry install -vvv
6870
- name: CDK Synth
6971
run: |
7072
cd test_infra
73+
source $(poetry env info --path)/bin/activate
7174
cdk synth
7275
- uses: stelligent/cfn_nag@master
7376
with:

test_infra/cdk.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
"sqlserver": false,
3535
"oracle": false,
3636
"neptune": false
37-
}
37+
},
38+
"network": "public"
3839
}
3940
}

test_infra/poetry.lock

Lines changed: 54 additions & 54 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test_infra/pyproject.toml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ license = "Apache License 2.0"
77

88
[tool.poetry.dependencies]
99
python = ">=3.7.1, <3.11"
10-
"aws-cdk-lib" = "^2.35.0"
11-
"constructs" = "^10.1.67"
12-
"aws-cdk.aws-glue-alpha" = "^2.35.0a0"
13-
"aws-cdk.aws-redshift-alpha" = "^2.35.0a0"
14-
"aws-cdk.aws-neptune-alpha" = "^2.35.0a0"
10+
"aws-cdk-lib" = "^2.45.0"
11+
"constructs" = "^10.1.123"
12+
"aws-cdk.aws-glue-alpha" = "^2.45.0a0"
13+
"aws-cdk.aws-redshift-alpha" = "^2.45.0a0"
14+
"aws-cdk.aws-neptune-alpha" = "^2.45.0a0"

0 commit comments

Comments
 (0)