Skip to content

Commit c8ea710

Browse files
committed
_utils: Make sure boto3's default session is used
* Currently `awswrangler` ensures that at least some boto3 Session is used when it calls AWS resources. However, since it creates a `boto3.Session()` when non-null boto3 Session is passed as a parameter, it completely sidesteps the ability of the user to set parameters to the boto3 session that gets used by default (via the `boto3.setup_default_session` function). * This commit ensures that the `ensure_session` function uses boto3's default session (reachable via `boto3._get_default_session()`) which then also allows `awswrangler` users to set default parameters of the boto3 Session it uses by default via `boto3.setup_default_session()`. Signed-off-by: mr.Shu <[email protected]>
1 parent 4f962d5 commit c8ea710

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

awswrangler/_utils.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@ def ensure_session(session: Optional[boto3.Session] = None) -> boto3.Session:
1818
"""Ensure that a valid boto3.Session will be returned."""
1919
if session is not None:
2020
return session
21-
return boto3.Session()
21+
# Ensure the boto3's default session is used so that its parameters can be
22+
# set via boto3.setup_default_session()
23+
return boto3._get_default_session() # pylint: disable=protected-access
2224

2325

2426
def client(service_name: str, session: Optional[boto3.Session] = None) -> boto3.client:

0 commit comments

Comments
 (0)