breaking change: Deprecate updated_name param in update_ruleset (#2122)

Author: jaidisido

awswrangler/data_quality/_create.py

@@ -121,7 +121,6 @@ def create_ruleset(
 @apply_configs
 def update_ruleset(
     name: str,
-    updated_name: Optional[str] = None,
     mode: str = "overwrite",
     df_rules: Optional[pd.DataFrame] = None,
     dqdl_rules: Optional[str] = None,
@@ -134,8 +133,6 @@ def update_ruleset(
     ----------
     name : str
         Ruleset name.
-    updated_name : str
-        New ruleset name if renaming an existing ruleset.
     mode : str
         overwrite (default) or upsert.
     df_rules : str, optional
@@ -152,7 +149,6 @@ def update_ruleset(
     Overwrite rules in the existing ruleset.
     >>> wr.data_quality.update_ruleset(
     >>>     name="ruleset",
-    >>>     new_name="my_ruleset",
     >>>     dqdl_rules="Rules = [ RowCount between 1 and 3 ]",
     >>>)
 
@@ -183,8 +179,6 @@ def update_ruleset(
         "Description": description,
         "Ruleset": dqdl_rules,
     }
-    if updated_name:
-        args["UpdatedName"] = updated_name
 
     client_glue: boto3.client = _utils.client(service_name="glue", session=boto3_session)
     try:

tests/test_data_quality.py

@@ -180,14 +180,9 @@ def test_update_ruleset(df: pd.DataFrame, glue_database: str, glue_table: str, g
         {"rule_type": "ColumnValues", "parameter": '"c2"', "expression": "in [0, 1, 2]"}, ignore_index=True
     )
 
-    new_glue_ruleset_name = f"{glue_ruleset} 2.0"
-    wr.data_quality.update_ruleset(
-        name=glue_ruleset,
-        updated_name=new_glue_ruleset_name,
-        df_rules=df_rules,
-    )
+    wr.data_quality.update_ruleset(name=glue_ruleset, df_rules=df_rules)
 
-    df_ruleset = wr.data_quality.get_ruleset(name=new_glue_ruleset_name)
+    df_ruleset = wr.data_quality.get_ruleset(name=glue_ruleset)
 
     assert df_rules.equals(df_ruleset)
 
@@ -202,11 +197,7 @@ def test_update_ruleset_exceptions(df: pd.DataFrame, glue_ruleset: str) -> None:
     )
 
     with pytest.raises(wr.exceptions.ResourceDoesNotExist):
-        wr.data_quality.update_ruleset(
-            name=glue_ruleset,
-            updated_name=f"{glue_ruleset} 2.0",
-            df_rules=df_rules,
-        )
+        wr.data_quality.update_ruleset(name=glue_ruleset, df_rules=df_rules)
 
     with pytest.raises(wr.exceptions.InvalidArgumentValue):
         wr.data_quality.update_ruleset(name=glue_ruleset, df_rules=df_rules, mode="append")