Fix broken smoke tests with customizations (#3195)

Author: mullermp

build_tools/customizations.rb

@@ -61,11 +61,9 @@ def dynamodb_example_deep_transform(subsegment, keys)
           subsegment
         end
       end
-
     end
 
     api('CloudFront') do |api|
-
       api['shapes'].each do |_, shape|
         if shape['members'] && shape['members']['MaxItems'] && shape['members']['MaxItems']['shape'] == 'string'
           shape['members']['MaxItems']['shape'] = 'integer'
@@ -76,7 +74,6 @@ def dynamodb_example_deep_transform(subsegment, keys)
         symbolized = name.sub(/\d{4}_\d{2}_\d{2}$/, '')
         api['operations'][symbolized] = api['operations'].delete(name)
       end
-
     end
 
     api('EC2') do |api|
@@ -118,10 +115,6 @@ def dynamodb_example_deep_transform(subsegment, keys)
       api['shapes']['Timestamp']['type'] = 'timestamp'
     end
 
-    smoke('MTurk') do |smoke|
-      smoke['testCases'] = []
-    end
-
     # Cross Region Copying
     %w[RDS Neptune DocDB].each do |service|
       operations = %w[
@@ -229,10 +222,6 @@ def dynamodb_example_deep_transform(subsegment, keys)
       end
     end
 
-    smoke('SMS') do |smoke|
-      smoke['testCases'] = []
-    end
-
     api('SQS') do |api|
       api['metadata']['errorPrefix'] = 'AWS.SimpleQueueService.'
       api['shapes']['StringList']['flattened'] = true
@@ -247,5 +236,35 @@ def dynamodb_example_deep_transform(subsegment, keys)
         api['operations'][operation]['auth'] = ['smithy.api#noAuth']
       end
     end
+
+    smoke('DSQL') do |smoke|
+      test = smoke['testCases'].find do |test_case|
+        test_case['id'] == 'GetClusterNotFound'
+      end
+      test['input']['identifier'] = 'a' * 26
+    end
+
+    smoke('ElasticTranscoder') do |smoke|
+      # discontinued service
+      smoke['testCases'] = []
+    end
+
+    smoke('NetworkFlowMonitor') do |smoke|
+      test = smoke['testCases'].find do |test_case|
+        test_case['id'] == 'GetMonitorSuccess'
+      end
+      test['expectation'] = { 'failure' => {} }
+    end
+
+    smoke('ObservabilityAdmin') do |smoke|
+      test = smoke['testCases'].find do |test_case|
+        test_case['id'] == 'GetTelemetryEvaluationStatusForOrganization'
+      end
+      test['expectation'] = { 'failure' => { 'errorId' => 'ValidationException' } }
+      test = smoke['testCases'].find do |test_case|
+        test_case['id'] == 'GetTelemetryEvaluationStatus'
+      end
+      test['expectation'] = { 'success' => {} }
+    end
   end
 end

gems/aws-sdk-dsql/features/smoke.feature

@@ -15,7 +15,7 @@ Feature: Smoke tests for DSQL
       """
     When I call the operation 'get_cluster' with params:
       """
-{"identifier":"someIdentifier"}
+{"identifier":"aaaaaaaaaaaaaaaaaaaaaaaaaa"}
       """
     Then I expect a 'Aws::DSQL::Errors::ResourceNotFoundException' was raised
 

gems/aws-sdk-elastictranscoder/features/smoke.feature

@@ -6,15 +6,3 @@
 # WARNING ABOUT GENERATED CODE
 
 Feature: Smoke tests for ElasticTranscoder
-
-  @elastictranscoder @smoke
-  Scenario: ListPresetsSuccess
-    Given I create a 'Aws::ElasticTranscoder' client with config:
-      """
-{"region":"us-west-2"}
-      """
-    When I call the operation 'list_presets' with params:
-      """
-{}
-      """
-    Then I expect an error was not raised

gems/aws-sdk-networkflowmonitor/features/smoke.feature

@@ -17,4 +17,4 @@ Feature: Smoke tests for NetworkFlowMonitor
       """
 {"monitor_name":"SmokeTestMonitor"}
       """
-    Then I expect an error was not raised
+    Then I expect an error was raised

gems/aws-sdk-observabilityadmin/features/smoke.feature

@@ -17,7 +17,7 @@ Feature: Smoke tests for ObservabilityAdmin
       """
 {}
       """
-    Then I expect a 'Aws::ObservabilityAdmin::Errors::AccessDeniedException' was raised
+    Then I expect a 'Aws::ObservabilityAdmin::Errors::ValidationException' was raised
 
   @observabilityadmin @smoke
   Scenario: GetTelemetryEvaluationStatus
@@ -29,4 +29,4 @@ Feature: Smoke tests for ObservabilityAdmin
       """
 {}
       """
-    Then I expect a 'Aws::ObservabilityAdmin::Errors::AccessDeniedException' was raised
+    Then I expect an error was not raised