Skip to content

Commit 353ba40

Browse files
authored
Check regressions (#3115)
1 parent af86b47 commit 353ba40

File tree

3 files changed

+18
-3
lines changed

3 files changed

+18
-3
lines changed

.github/workflows/benchmark.yml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ on:
1212
permissions:
1313
id-token: write # required for OIDC
1414
contents: read
15+
pull-requests: write
1516

1617
jobs:
1718
benchmark:
@@ -65,3 +66,16 @@ jobs:
6566
- name: Put benchmark metrics
6667
if: ${{ env.AWS_ACCESS_KEY_ID != '' }}
6768
run: bundle exec rake benchmark:put-metrics
69+
70+
- name: Check for Performance Regressions
71+
if: ${{ env.AWS_ACCESS_KEY_ID != '' }}
72+
id: regressions
73+
run: bundle exec rake benchmark:check-regressions
74+
75+
- name: Comment on PR
76+
if: ${{ steps.regressions.outputs.message }}
77+
uses: thollander/actions-comment-pull-request@main
78+
with:
79+
message: ${{ steps.regressions.outputs.message }}
80+
comment_tag: performance-regression
81+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Gemfile

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,9 @@ group :benchmark do
3030
gem 'memory_profiler'
3131

3232
# required for uploading report/putting metrics
33-
gem 'aws-sdk-cloudwatch'
34-
gem 'aws-sdk-s3'
33+
gem 'aws-sdk-cloudwatch', require: false
34+
gem 'aws-sdk-s3', require: false
35+
gem 'aws-sdk-lambda', require: false
3536
end
3637

3738
group :build do

0 commit comments

Comments
 (0)