[V2] Ruby2.7 warns on Proc.new with no block (#2061)

* Ruby2.7 warns on Proc.new with no block
* [ci skip] changelog

Author: cjyclaire

CHANGELOG.md

@@ -1,6 +1,8 @@
 Unreleased Changes
 ------------------
 
+* Issue - Mirgate Proc.new without a block usage #2058.
+
 2.11.285 (2019-05-30)
 ------------------
 

aws-sdk-core/lib/aws-sdk-core.rb

@@ -555,7 +555,7 @@ def sub_modules(options = {})
     # each new service added after the callback is registered.
     # @api private
     def service_added(&block)
-      callback = Proc.new
+      callback = block if block_given?
       @services.each do |svc_name, (svc_module, options)|
         yield(svc_name, svc_module, options)
       end

aws-sdk-core/lib/aws-sdk-core/waiters/waiter.rb

@@ -49,7 +49,7 @@ def initialize(options = {})
       #
       # @yieldparam [Integer] attempts The number of attempts made.
       def before_attempt(&block)
-        @before_attempt << Proc.new
+        @before_attempt << block if block_given?
       end
 
       # Register a callback that is invoked after an attempt but before
@@ -80,7 +80,7 @@ def before_attempt(&block)
       # @yieldparam [Seahorse::Client::Response] response The response from
       #   the previous polling attempts.
       def before_wait(&block)
-        @before_wait << Proc.new
+        @before_wait << block if block_given?
       end
 
       # @option options [Client] :client

aws-sdk-core/lib/seahorse/client/configuration.rb

@@ -104,7 +104,7 @@ def initialize
       #
       # @return [self]
       def add_option(name, default = nil, &block)
-        default = DynamicDefault.new(Proc.new) if block_given?
+        default = DynamicDefault.new(block) if block_given?
         @defaults[name.to_sym] << default
         self
       end

aws-sdk-core/lib/seahorse/client/events.rb

@@ -9,7 +9,7 @@ def initialize(*args)
 
       def emit(event_name, *args, &block)
         @listeners[event_name] ||= []
-        @listeners[event_name] << Proc.new
+        @listeners[event_name] << block if block_given?
       end
 
       def signal(event, *args)

aws-sdk-core/lib/seahorse/client/http/response.rb

@@ -117,15 +117,15 @@ def signal_error(networking_error)
         end
 
         def on_headers(status_code_range = nil, &block)
-          @listeners[:headers] << listener(status_code_range, Proc.new)
+          @listeners[:headers] << listener(status_code_range, block)
         end
 
         def on_data(&callback)
-          @listeners[:data] << Proc.new
+          @listeners[:data] << callback
         end
 
         def on_done(status_code_range = nil, &callback)
-          listener = listener(status_code_range, Proc.new)
+          listener = listener(status_code_range, callback)
           if @done
             listener.call
           else

aws-sdk-core/lib/seahorse/client/plugin.rb

@@ -40,7 +40,7 @@ class << self
 
         def option(name, default = nil, &block)
           if block_given?
-            options << [[name], Proc.new]
+            options << [[name], block]
           else
             options << [[name, default]]
           end

aws-sdk-resources/lib/aws-sdk-resources/services/sqs/queue_poller.rb

@@ -253,7 +253,7 @@ def initialize(queue_url, options = {})
       #
       # @return [void]
       def before_request(&block)
-        @default_config = @default_config.with(before_request: Proc.new)
+        @default_config = @default_config.with(before_request: block) if block_given?
       end
 
       # Polls the queue, yielded a message, or an array of messages.