Remove event stream max payload size and headers length checks (#3188)

* Remove event stream max payload size and headers length checks

* Add changelog entry

* Remove unused error classes

Author: richardwang1124

gems/aws-eventstream/CHANGELOG.md

@@ -1,6 +1,8 @@
 Unreleased Changes
 ------------------
 
+* Issue - Remove event stream max payload size and headers length checks.
+
 1.3.0 (2023-11-22)
 ------------------
 

gems/aws-eventstream/lib/aws-eventstream/encoder.rb

@@ -41,12 +41,6 @@ class Encoder
       # and 4 bytes total message crc checksum
       OVERHEAD_LENGTH = 16
 
-      # Maximum header length allowed (after encode) 128kb
-      MAX_HEADERS_LENGTH = 131072
-
-      # Maximum payload length allowed (after encode) 16mb
-      MAX_PAYLOAD_LENGTH = 16777216
-
       # Encodes Aws::EventStream::Message to output IO when
       #   provided, else return the encoded binary string
       #
@@ -81,9 +75,6 @@ def encode_message(message)
         encoded_header = encode_headers(message)
         header_length = encoded_header.bytesize
         # encode payload
-        if message.payload.length > MAX_PAYLOAD_LENGTH
-          raise Aws::EventStream::Errors::EventPayloadLengthExceedError.new
-        end
         encoded_payload = message.payload.read
         total_length = header_length + encoded_payload.bytesize + OVERHEAD_LENGTH
 
@@ -124,10 +115,7 @@ def encode_headers(message)
             pattern ? [value.value].pack(pattern) : value.value,
           ].pack('a*a*a*')
         end
-        header_entries.join.tap do |encoded_header|
-          break encoded_header if encoded_header.bytesize <= MAX_HEADERS_LENGTH
-          raise Aws::EventStream::Errors::EventHeadersLengthExceedError.new
-        end
+        header_entries.join
       end
 
       private

gems/aws-eventstream/lib/aws-eventstream/errors.rb

@@ -32,18 +32,6 @@ def initialize(*args)
         end
       end
 
-      class EventPayloadLengthExceedError < RuntimeError
-        def initialize(*args)
-          super("Payload length of a message should be under 16mb.")
-        end
-      end
-
-      class EventHeadersLengthExceedError < RuntimeError
-        def initialize(*args)
-          super("Encoded headers length of a message should be under 128kb.")
-        end
-      end
-
     end
   end
 end

gems/aws-eventstream/spec/encoder_spec.rb

@@ -25,33 +25,25 @@ module EventStream
             expect(test_io.string.freeze).to eq(expectation)
           end
         end
-      end
-
-      describe '#encode error' do
 
-        it 'raises an error when payload exceeds' do
-          payload = double('payload', :length => 16777217)
+        it 'encodes large payloads' do
           message = Aws::EventStream::Message.new(
             headers: {},
-            payload: payload
+            payload: StringIO.new('.' * 24 * 1024 * 1024)
           )
-          expect {
-            Encoder.new.encode(message)
-          }.to raise_error(Aws::EventStream::Errors::EventPayloadLengthExceedError)
+          Encoder.new.encode(message)
         end
 
-        it 'raises an error when encoded headers exceeds' do
+        it 'encodes long headers' do
           headers = {}
           headers['foo'] = Aws::EventStream::HeaderValue.new(
-            value: '*' * 131073, type: 'string'
+            value: '*' * 131_073, type: 'string'
           )
           message = Aws::EventStream::Message.new(
             headers: headers,
             payload: StringIO.new
           )
-          expect {
-            Encoder.new.encode(message)
-          }.to raise_error(Aws::EventStream::Errors::EventHeadersLengthExceedError)
+          Encoder.new.encode(message)
 
         end