Add smoke test customizations and delete SMS/MTurk (#2843)

Co-authored-by: Matt Muller <[email protected]>

Author: alextwoods

build_tools/customizations.rb

@@ -6,6 +6,7 @@ module Customizations
     @api_customizations = {}
     @doc_customizations = {}
     @example_customizations = {}
+    @smoke_customizations = {}
 
     class << self
 
@@ -21,6 +22,10 @@ def example(svc_name, &block)
         @example_customizations[svc_name] = block
       end
 
+      def smoke(svc_name, &block)
+        @smoke_customizations[svc_name] = block
+      end
+
       def apply_api_customizations(svc_name, api)
         @api_customizations[svc_name].call(api) if @api_customizations[svc_name]
       end
@@ -33,6 +38,10 @@ def apply_example_customizations(svc_name, examples)
         @example_customizations[svc_name].call(examples) if @example_customizations[svc_name]
       end
 
+      def apply_smoke_customizations(svc_name, smoke)
+        @smoke_customizations[svc_name].call(smoke) if @smoke_customizations[svc_name]
+      end
+
       private
 
       def dynamodb_example_deep_transform(subsegment, keys)
@@ -104,7 +113,6 @@ def dynamodb_example_deep_transform(subsegment, keys)
     end
 
     %w(Lambda LambdaPreview).each do |svc_name|
-
       api(svc_name) do |api|
         api['shapes']['Timestamp']['type'] = 'timestamp'
       end
@@ -113,7 +121,10 @@ def dynamodb_example_deep_transform(subsegment, keys)
         docs['shapes']['Blob']['refs']['UpdateFunctionCodeRequest$ZipFile'] =
           "<p>.zip file containing your packaged source code.</p>"
       end
+    end
 
+    smoke('MTurk') do |smoke|
+      smoke['testCases'] = []
     end
 
     # Cross Region Copying
@@ -201,6 +212,10 @@ def dynamodb_example_deep_transform(subsegment, keys)
       end
     end
 
+    smoke('SMS') do |smoke|
+      smoke['testCases'] = []
+    end
+
     api('SQS') do |api|
       api['metadata']['errorPrefix'] = 'AWS.SimpleQueueService.'
       api['shapes']['StringList']['flattened'] = true

build_tools/services.rb

@@ -63,7 +63,7 @@ def build_service(svc_name, config)
         waiters: model_path('waiters-2.json', config['models']),
         resources: model_path('resources-1.json', config['models']),
         examples: load_examples(svc_name, config['models']),
-        smoke_tests: model_path('smoke.json', config['models']),
+        smoke_tests: load_smoke(svc_name, config['models']),
         legacy_endpoints: config.fetch('legacyEndpoints', false),
         endpoint_rules: model_path('endpoint-rule-set-1.json', config['models']),
         endpoint_tests: model_path('endpoint-tests-1.json', config['models']),
@@ -96,6 +96,17 @@ def load_examples(svc_name, models_dir)
       end
     end
 
+    def load_smoke(svc_name, models_dir)
+      path = model_path('smoke.json', models_dir)
+      if path
+        smoke = JSON.load(File.read(path))
+        BuildTools::Customizations.apply_smoke_customizations(svc_name, smoke)
+        smoke
+      else
+        nil
+      end
+    end
+
     def add_plugins(api, plugins)
       plugins << EVENTSTREAM_PLUGIN if eventstream?(api)
       plugins.inject({}) do |hash, plugin|

gems/aws-sdk-mturk/features/smoke.feature

@@ -9,11 +9,3 @@ Feature: Smoke tests for MTurk
 
 Background:
   Given I create a client in region 'us-east-1'
-
-  @mturk @smoke
-  Scenario: Call Aws::MTurk::Client#get_account_balance and expect it to succeed
-  When I call the operation 'get_account_balance' with params:
-    """
-{}
-    """
-  Then I expect an error was not raised

gems/aws-sdk-sms/features/smoke.feature

@@ -9,19 +9,3 @@ Feature: Smoke tests for SMS
 
 Background:
   Given I create a client in region 'us-west-2'
-
-  @sms @smoke
-  Scenario: Call Aws::SMS::Client#get_connectors and expect it to succeed
-  When I call the operation 'get_connectors' with params:
-    """
-{}
-    """
-  Then I expect an error was not raised
-
-  @sms @smoke
-  Scenario: Call Aws::Aws::SMS::Client#delete_replication_job and expect it to fail
-  When I call the operation 'delete_replication_job' with params:
-    """
-{"replication_job_id":"invalidId"}
-    """
-  Then I expect an error was raised

tasks/test.rake

@@ -47,17 +47,15 @@ end
 
 rule /^test:features:.+$/ do |task|
   dir = "gems/#{task.name.split(':').last}/features"
-  # skip mturk because it requires account setup
-  tags = "-t 'not @veryslow' -t 'not @mturk'"
+  tags = "-t 'not @veryslow'"
   sh("bundle exec cucumber --retry 3 #{tags} -r #{dir} #{dir} --publish-quiet")
 end
 
 desc 'Executes integration tests.'
 task 'test:features' do
   failures = []
   Dir.glob('gems/*/features').each do |dir|
-    # skip mturk because it requires account setup
-    tags = "-t 'not @veryslow' -t 'not @mturk'"
+    tags = "-t 'not @veryslow'"
     sh("bundle exec cucumber --retry 3 #{tags} -r #{dir} #{dir} --publish-quiet") do |ok, _|
       failures << File.basename(File.dirname(dir)) unless ok
     end