Fix thread interruptions (#2954)

Author: jterapin

gems/aws-sdk-s3/CHANGELOG.md

@@ -1,6 +1,8 @@
 Unreleased Changes
 ------------------
 
+* Issue - Fix thread interruptions in multipart `download_file`, `file_uploader` and `stream_uploader` (#2944).
+
 1.139.0 (2023-11-22)
 ------------------
 

gems/aws-sdk-s3/lib/aws-sdk-s3/file_downloader.rb

@@ -190,7 +190,6 @@ def download_in_threads(pending, total_size)
               raise error
             end
           end
-          thread.abort_on_exception = true
           threads << thread
         end
         threads.map(&:value).compact

gems/aws-sdk-s3/lib/aws-sdk-s3/multipart_file_uploader.rb

@@ -175,7 +175,6 @@ def upload_in_threads(pending, completed, options)
               error
             end
           end
-          thread.abort_on_exception = true
           threads << thread
         end
         threads.map(&:value).compact

gems/aws-sdk-s3/lib/aws-sdk-s3/multipart_stream_uploader.rb

@@ -192,7 +192,6 @@ def upload_in_threads(read_pipe, completed, options, thread_errors)
               error
             end
           end
-          thread.abort_on_exception = true
           thread
         end
       end

gems/aws-sdk-s3/spec/object/download_file_spec.rb

@@ -221,10 +221,9 @@ module S3
         end
 
         it 'raises an error when checksum validation fails on multipart' do
-          client.stub_responses(:get_object, {body: 'body', checksum_sha1: 'invalid'})
+          client.stub_responses(:get_object, { body: 'body', checksum_sha1: 'invalid' })
 
           thread = double(value: nil)
-          allow(thread).to receive(:abort_on_exception=)
           expect(Thread).to receive(:new).and_yield.and_return(thread)
 
           expect do

gems/aws-sdk-s3/spec/object/upload_file_spec.rb

@@ -170,7 +170,6 @@ module S3
 
           it 'reports progress for multipart uploads' do
             thread = double(value: nil)
-            allow(thread).to receive(:abort_on_exception=)
             allow(Thread).to receive(:new).and_yield.and_return(thread)
 
             client.stub_responses(:create_multipart_upload, upload_id: 'id')