Skip to content

Commit 9c3c784

Browse files
authored
Consider sigv4a supported without crt check (#3089)
1 parent 9a32e0c commit 9c3c784

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

gems/aws-sdk-core/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
Unreleased Changes
22
------------------
33

4+
* Issue - Allow legacy/undocumented `sigv4_signer` configuration to override resolved signer.
5+
* Issue - Consider sigv4a supported without crt check.
6+
47
3.201.4 (2024-08-08)
58
------------------
69

gems/aws-sdk-core/aws-sdk-core.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ Gem::Specification.new do |spec|
1414

1515
spec.add_dependency('jmespath', '~> 1', '>= 1.6.1') # necessary for secure jmespath JSON parsing
1616
spec.add_dependency('aws-partitions', '~> 1', '>= 1.651.0') # necessary for new endpoint resolution
17-
spec.add_dependency('aws-sigv4', '~> 1.8') # necessary for s3 express auth
17+
spec.add_dependency('aws-sigv4', '~> 1.9') # necessary for s3 express auth/native sigv4a support
1818
spec.add_dependency('aws-eventstream', '~> 1', '>= 1.3.0') # necessary for binary eventstream
1919

2020
spec.metadata = {

gems/aws-sdk-core/lib/aws-sdk-core/plugins/sign.rb

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@ class Sign < Seahorse::Client::Plugin
1313
option(:sigv4_region)
1414
option(:unsigned_operations, default: [])
1515

16-
supported_auth_types = %w[sigv4 bearer sigv4-s3express none]
17-
supported_auth_types += ['sigv4a'] if Aws::Sigv4::Signer.use_crt?
16+
supported_auth_types = %w[sigv4 bearer sigv4-s3express sigv4a none]
1817
SUPPORTED_AUTH_TYPES = supported_auth_types.freeze
1918

2019
def add_handlers(handlers, cfg)
@@ -107,7 +106,7 @@ def initialize(auth_scheme, config, sigv4_overrides = {})
107106
auth_scheme['signingRegion']
108107
end
109108
begin
110-
@signer = Aws::Sigv4::Signer.new(
109+
@signer = config.sigv4_signer || Aws::Sigv4::Signer.new(
111110
service: config.sigv4_name || auth_scheme['signingName'],
112111
region: sigv4_overrides[:region] || config.sigv4_region || region,
113112
credentials_provider: sigv4_overrides[:credentials] || config.credentials,

0 commit comments

Comments
 (0)