Drop Ruby 2.4 and 2.5 (#2951)

mullermp · web-flow · commit dca0f171a863 · 2023-11-22T13:32:36.000-05:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -18,16 +18,8 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: [2.3, 2.4, 2.5, 2.6, 2.7, '3.0', 3.1, 3.2, jruby-9.1, jruby-9.2, jruby-9.3, jruby-9.4]
+        ruby: [2.5, 2.6, 2.7, '3.0', 3.1, 3.2, jruby-9.2, jruby-9.3, jruby-9.4]
         env: [KITCHEN_SINK, CRT]
-        exclude:
-          # CRT supports Ruby >= 2.5
-          - ruby: 2.3
-            env: CRT
-          - ruby: 2.4
-            env: CRT
-          - ruby: jruby-9.1
-            env: CRT
 
     steps:
       - name: Setup Ruby
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -1,2 +1,2 @@
 AllCops:
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.5
diff --git a/Gemfile b/Gemfile
@@ -51,7 +51,7 @@ group :repl do
 end
 
 group :development do
-  gem 'rubocop', '0.81.0'
+  gem 'rubocop', '1.28.0'
 end
 
 group :benchmark do
diff --git a/build_tools/aws-sdk-code-generator/templates/gemspec.mustache b/build_tools/aws-sdk-code-generator/templates/gemspec.mustache
@@ -27,7 +27,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency('{{gem}}', '{{&version}}')
   {{/dependencies}}
 
-  spec.required_ruby_version = '>= 2.3'
+  spec.required_ruby_version = '>= 2.5'
   {{#deprecated?}}
   spec.post_install_message = '*** {{gem_name}} is deprecated ***'
   {{/deprecated?}}
diff --git a/build_tools/services.rb b/build_tools/services.rb
@@ -10,10 +10,10 @@ class ServiceEnumerator
     MANIFEST_PATH = File.expand_path('../../services.json', __FILE__)
 
     # Minimum `aws-sdk-core` version for new gem builds
-    MINIMUM_CORE_VERSION = "3.184.0"
+    MINIMUM_CORE_VERSION = "3.188.0"
 
     # Minimum `aws-sdk-core` version for new S3 gem builds
-    MINIMUM_CORE_VERSION_S3 = "3.181.0"
+    MINIMUM_CORE_VERSION_S3 = "3.188.0"
 
     EVENTSTREAM_PLUGIN = "Aws::Plugins::EventStreamConfiguration"
 
diff --git a/gems/aws-eventstream/CHANGELOG.md b/gems/aws-eventstream/CHANGELOG.md
@@ -1,6 +1,8 @@
 Unreleased Changes
 ------------------
 
+* Feature - AWS SDK for Ruby no longer supports Ruby runtime versions 2.3 and 2.4.
+
 1.2.0 (2021-09-01)
 ------------------
 
diff --git a/gems/aws-eventstream/aws-eventstream.gemspec b/gems/aws-eventstream/aws-eventstream.gemspec
@@ -15,5 +15,5 @@ Gem::Specification.new do |spec|
     'changelog_uri'   => 'https://github.com/aws/aws-sdk-ruby/tree/version-3/gems/aws-eventstream/CHANGELOG.md'
   }
 
-  spec.required_ruby_version = '>= 2.3'
+  spec.required_ruby_version = '>= 2.5'
 end
diff --git a/gems/aws-partitions/CHANGELOG.md b/gems/aws-partitions/CHANGELOG.md
@@ -1,6 +1,8 @@
 Unreleased Changes
 ------------------
 
+* Feature - AWS SDK for Ruby no longer supports Ruby runtime versions 2.3 and 2.4.
+
 1.855.0 (2023-11-21)
 ------------------
 
diff --git a/gems/aws-partitions/aws-partitions.gemspec b/gems/aws-partitions/aws-partitions.gemspec
@@ -15,5 +15,5 @@ Gem::Specification.new do |spec|
     'changelog_uri'   => 'https://github.com/aws/aws-sdk-ruby/tree/version-3/gems/aws-partitions/CHANGELOG.md',
   }
 
-  spec.required_ruby_version = '>= 2.3'
+  spec.required_ruby_version = '>= 2.5'
 end
diff --git a/gems/aws-sdk-core/CHANGELOG.md b/gems/aws-sdk-core/CHANGELOG.md
@@ -1,6 +1,8 @@
 Unreleased Changes
 ------------------
 
+* Feature - AWS SDK for Ruby no longer supports Ruby runtime versions 2.3 and 2.4.
+
 * Feature - Support `AWS_CONTAINER_AUTHORIZATION_TOKEN_FILE` in `ECSCredentials` and also allow for ECS and EKS link-local http addresses.
 
 3.187.1 (2023-11-20)
diff --git a/gems/aws-sdk-core/aws-sdk-core.gemspec b/gems/aws-sdk-core/aws-sdk-core.gemspec
@@ -22,5 +22,5 @@ Gem::Specification.new do |spec|
     'changelog_uri'   => 'https://github.com/aws/aws-sdk-ruby/tree/version-3/gems/aws-sdk-core/CHANGELOG.md'
   }
 
-  spec.required_ruby_version = '>= 2.3'
+  spec.required_ruby_version = '>= 2.5'
 end
diff --git a/gems/aws-sdk-core/lib/aws-sdk-sts/presigner.rb b/gems/aws-sdk-core/lib/aws-sdk-sts/presigner.rb
@@ -35,7 +35,7 @@ def initialize(options = {})
       #   )
       #
       # This can be easily converted to a token used by the EKS service:
-      # {https://ruby-doc.org/stdlib-2.3.1/libdoc/base64/rdoc/Base64.html#method-i-encode64}
+      # {https://docs.ruby-lang.org/en/3.2/Base64.html#method-i-encode64}
       # "k8s-aws-v1." + Base64.urlsafe_encode64(url).chomp("==")
       def get_caller_identity_presigned_url(options = {})
         req = @client.build_request(:get_caller_identity, {})
diff --git a/gems/aws-sdk-core/lib/seahorse/client/net_http/patches.rb b/gems/aws-sdk-core/lib/seahorse/client/net_http/patches.rb
@@ -12,12 +12,9 @@ module Patches
 
         def self.apply!
           Net::HTTPGenericRequest.prepend(PatchDefaultContentType)
-          return unless RUBY_VERSION < '2.5'
-
-          Net::HTTP::IDEMPOTENT_METHODS_.clear
         end
 
-        # For requests with bodys, Net::HTTP sets a default content type of:
+        # For requests with bodies, Net::HTTP sets a default content type of:
         #   'application/x-www-form-urlencoded'
         # There are cases where we should not send content type at all.
         # Even when no body is supplied, Net::HTTP uses a default empty body
diff --git a/gems/aws-sdk-core/lib/seahorse/client/plugins/h2.rb b/gems/aws-sdk-core/lib/seahorse/client/plugins/h2.rb
@@ -54,9 +54,9 @@ class H2 < Plugin
         DOCS
 
         option(:enable_alpn, default: false, doc_type: 'Boolean', docstring: <<-DOCS)
-Setting to `true` to enable ALPN in HTTP2 over TLS, requires Ruby version >= 2.3 and
-Openssl version >= 1.0.2. Defaults to false. Note: not all service HTTP2 operations
-supports ALPN on server side, please refer to service documentation.
+Set to `true` to enable ALPN in HTTP2 over TLS. Requires Openssl version >= 1.0.2.
+Defaults to false. Note: not all service HTTP2 operations supports ALPN on server
+side, please refer to service documentation.
         DOCS
 
         option(:logger)
diff --git a/gems/aws-sdk-resources/CHANGELOG.md b/gems/aws-sdk-resources/CHANGELOG.md
@@ -1,6 +1,8 @@
 Unreleased Changes
 ------------------
 
+* Feature - AWS SDK for Ruby no longer supports Ruby runtime versions 2.3 and 2.4.
+
 3.176.0 (2023-11-21)
 ------------------
 
diff --git a/gems/aws-sdk-resources/aws-sdk-resources.gemspec b/gems/aws-sdk-resources/aws-sdk-resources.gemspec
@@ -381,5 +381,5 @@ Gem::Specification.new do |spec|
     'changelog_uri'   => 'https://github.com/aws/aws-sdk-ruby/tree/version-3/gems/aws-sdk-resources/CHANGELOG.md'
   }
 
-  spec.required_ruby_version = '>= 2.3'
+  spec.required_ruby_version = '>= 2.5'
 end
diff --git a/gems/aws-sdk-sso/CHANGELOG.md b/gems/aws-sdk-sso/CHANGELOG.md
@@ -1,6 +1,8 @@
 Unreleased Changes
 ------------------
 
+* Feature - AWS SDK for Ruby no longer supports Ruby runtime versions 2.3 and 2.4.
+
 1.11.0 (2022-08-30)
 ------------------
 
diff --git a/gems/aws-sdk-sso/aws-sdk-sso.gemspec b/gems/aws-sdk-sso/aws-sdk-sso.gemspec
@@ -28,5 +28,5 @@ Gem::Specification.new do |spec|
   spec.add_dependency('aws-sdk-core', '~> 3', '>= 3.105.0')
   spec.add_dependency('aws-sigv4', '~> 1.1')
 
-  spec.required_ruby_version = '>= 2.3'
+  spec.required_ruby_version = '>= 2.5'
 end
diff --git a/gems/aws-sdk-ssooidc/CHANGELOG.md b/gems/aws-sdk-ssooidc/CHANGELOG.md
@@ -1,6 +1,8 @@
 Unreleased Changes
 ------------------
 
+* Feature - AWS SDK for Ruby no longer supports Ruby runtime versions 2.3 and 2.4.
+
 1.23.0 (2022-09-30)
 ------------------
 
diff --git a/gems/aws-sdk-ssooidc/aws-sdk-ssooidc.gemspec b/gems/aws-sdk-ssooidc/aws-sdk-ssooidc.gemspec
@@ -28,5 +28,5 @@ Gem::Specification.new do |spec|
   spec.add_dependency('aws-sdk-core', '~> 3', '>= 3.131.0')
   spec.add_dependency('aws-sigv4', '~> 1.1')
 
-  spec.required_ruby_version = '>= 2.3'
+  spec.required_ruby_version = '>= 2.5'
 end
diff --git a/gems/aws-sdk-sts/CHANGELOG.md b/gems/aws-sdk-sts/CHANGELOG.md
@@ -1,6 +1,8 @@
 Unreleased Changes
 ------------------
 
+* Feature - AWS SDK for Ruby no longer supports Ruby runtime versions 2.3 and 2.4.
+
 1.10.0 (2023-05-08)
 ------------------
 
diff --git a/gems/aws-sdk-sts/aws-sdk-sts.gemspec b/gems/aws-sdk-sts/aws-sdk-sts.gemspec
@@ -28,5 +28,5 @@ Gem::Specification.new do |spec|
   spec.add_dependency('aws-sdk-core', '~> 3', '>= 3.110.0')
   spec.add_dependency('aws-sigv4', '~> 1.1')
 
-  spec.required_ruby_version = '>= 2.3'
+  spec.required_ruby_version = '>= 2.5'
 end
diff --git a/gems/aws-sdk/CHANGELOG.md b/gems/aws-sdk/CHANGELOG.md
@@ -1,6 +1,8 @@
 Unreleased Changes
 ------------------
 
+* Feature - AWS SDK for Ruby no longer supports Ruby runtime versions 2.3 and 2.4.
+
 3.1.0 (2021-09-01)
 ------------------
 
diff --git a/gems/aws-sdk/aws-sdk.gemspec b/gems/aws-sdk/aws-sdk.gemspec
@@ -21,5 +21,5 @@ Gem::Specification.new do |spec|
     'changelog_uri'   => 'https://github.com/aws/aws-sdk-ruby/tree/version-3/gems/aws-sdk/CHANGELOG.md'
   }
 
-  spec.required_ruby_version = '>= 2.3'
+  spec.required_ruby_version = '>= 2.5'
 end
diff --git a/gems/aws-sigv2/CHANGELOG.md b/gems/aws-sigv2/CHANGELOG.md
@@ -1,6 +1,8 @@
 Unreleased Changes
 ------------------
 
+* Feature - AWS SDK for Ruby no longer supports Ruby runtime versions 2.3 and 2.4.
+
 1.1.0 (2021-09-01)
 ------------------
 
diff --git a/gems/aws-sigv2/aws-sigv2.gemspec b/gems/aws-sigv2/aws-sigv2.gemspec
@@ -15,5 +15,5 @@ Gem::Specification.new do |spec|
     'changelog_uri'   => 'https://github.com/aws/aws-sdk-ruby/tree/version-3/gems/aws-sigv2/CHANGELOG.md'
   }
 
-  spec.required_ruby_version = '>= 2.3'
+  spec.required_ruby_version = '>= 2.5'
 end
diff --git a/gems/aws-sigv4/CHANGELOG.md b/gems/aws-sigv4/CHANGELOG.md
@@ -1,6 +1,8 @@
 Unreleased Changes
 ------------------
 
+* Feature - AWS SDK for Ruby no longer supports Ruby runtime versions 2.3 and 2.4.
+
 1.6.1 (2023-10-25)
 ------------------
 
diff --git a/gems/aws-sigv4/aws-sigv4.gemspec b/gems/aws-sigv4/aws-sigv4.gemspec
@@ -17,5 +17,5 @@ Gem::Specification.new do |spec|
     'changelog_uri'   => 'https://github.com/aws/aws-sdk-ruby/tree/version-3/gems/aws-sigv4/CHANGELOG.md'
   }
 
-  spec.required_ruby_version = '>= 2.3'
+  spec.required_ruby_version = '>= 2.5'
 end

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`	`1`	`AllCops:`
`2`		`- TargetRubyVersion: 2.3`
	`2`	`+ TargetRubyVersion: 2.5`
Original file line number	Diff line number	Diff line change
`@@ -15,5 +15,5 @@ Gem::Specification.new do \|spec\|`
`15`	`15`	`'changelog_uri' => 'https://github.com/aws/aws-sdk-ruby/tree/version-3/gems/aws-eventstream/CHANGELOG.md'`
`16`	`16`	`}`
`17`	`17`
`18`		`- spec.required_ruby_version = '>= 2.3'`
	`18`	`+ spec.required_ruby_version = '>= 2.5'`
`19`	`19`	`end`