Fix typo in recursion detection - use AMZN instead of AMZ (#2740)

Author: alextwoods

gems/aws-sdk-core/CHANGELOG.md

@@ -1,6 +1,8 @@
 Unreleased Changes
 ------------------
 
+* Issue - Fix typo in `RecursionDetection`, change amz to amzn in header and env name.
+
 3.131.5 (2022-07-28)
 ------------------
 

gems/aws-sdk-core/lib/aws-sdk-core/plugins/recursion_detection.rb

@@ -9,10 +9,10 @@ class RecursionDetection < Seahorse::Client::Plugin
       class Handler < Seahorse::Client::Handler
         def call(context)
 
-          unless context.http_request.headers.key?('x-amz-trace-id')
+          unless context.http_request.headers.key?('x-amzn-trace-id')
             if ENV['AWS_LAMBDA_FUNCTION_NAME'] &&
-              (trace_id = ENV['_X_AMZ_TRACE_ID'])
-              context.http_request.headers['x-amz-trace-id'] = trace_id
+              (trace_id = ENV['_X_AMZN_TRACE_ID'])
+              context.http_request.headers['x-amzn-trace-id'] = trace_id
             end
           end
           @handler.call(context)

gems/aws-sdk-core/spec/aws/plugins/recursion_detection_spec.rb

@@ -28,7 +28,7 @@ module Plugins
                 'TraceId' => {
                   'shape' => 'String',
                   'location' => "header",
-                  'locationName' => "x-amz-trace-id"
+                  'locationName' => "x-amzn-trace-id"
                 }
               }
             },
@@ -47,21 +47,21 @@ module Plugins
       context 'no ENV variables set' do
         it 'does not set the header when ENV is not set' do
           resp = client.operation_with_trace_id
-          expect(resp.context.http_request.headers.key?('x-amz-trace-id')).to be_falsey
+          expect(resp.context.http_request.headers.key?('x-amzn-trace-id')).to be_falsey
         end
       end
 
       context 'AWS_LAMBDA_FUNCTION_NAME is not set' do
         let(:env_trace_id) { 'Root=1-5759e988-bd862e3fe1be46a994272793;Parent=53995c3f42cd8ad8;Sampled=1;lineage=a87bd80c:0,68fd508a:5,c512fbe3:2' }
         before do
           allow(ENV).to receive(:[]).and_return(nil)
-          allow(ENV).to receive(:[]).with('_X_AMZ_TRACE_ID')
+          allow(ENV).to receive(:[]).with('_X_AMZN_TRACE_ID')
                                     .and_return(env_trace_id)
         end
 
         it 'does not set the header' do
           resp = client.operation_with_trace_id
-          expect(resp.context.http_request.headers.key?('x-amz-trace-id')).to be_falsey
+          expect(resp.context.http_request.headers.key?('x-amzn-trace-id')).to be_falsey
 
         end
 
@@ -73,19 +73,19 @@ module Plugins
           allow(ENV).to receive(:[]).and_return(nil)
           allow(ENV).to receive(:[]).with('AWS_LAMBDA_FUNCTION_NAME')
                                     .and_return(lambda_function_name)
-          allow(ENV).to receive(:[]).with('_X_AMZ_TRACE_ID')
+          allow(ENV).to receive(:[]).with('_X_AMZN_TRACE_ID')
                                     .and_return(env_trace_id)
         end
 
         it 'sets the header' do
           resp = client.operation_with_trace_id
-          expect(resp.context.http_request.headers['x-amz-trace-id']).to eq(env_trace_id)
+          expect(resp.context.http_request.headers['x-amzn-trace-id']).to eq(env_trace_id)
         end
 
         it 'does not override the header when the value is already set' do
           user_trace_id = "user_trace_id"
           resp = client.operation_with_trace_id(trace_id: user_trace_id)
-          expect(resp.context.http_request.headers['x-amz-trace-id']).to eq(user_trace_id)
+          expect(resp.context.http_request.headers['x-amzn-trace-id']).to eq(user_trace_id)
         end
       end
     end