Skip to content

Commit e5aeae2

Browse files
authored
Add ruby 3.4 to CI (#3177)
1 parent c0676b0 commit e5aeae2

File tree

6 files changed

+17
-12
lines changed

6 files changed

+17
-12
lines changed

.github/workflows/benchmark.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
fail-fast: false
2727
matrix:
2828
# Supported ruby versions (except 2.5 - benchmarks missing)
29-
ruby: [2.6, 2.7, '3.0', 3.1, 3.2, 3.3, jruby-9.3, jruby-9.4]
29+
ruby: [2.6, 2.7, '3.0', 3.1, 3.2, 3.3, 3.4, jruby-9.3, jruby-9.4]
3030

3131
steps:
3232
- name: Setup Ruby

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949
fail-fast: false
5050
matrix:
5151
# Supported ruby versions
52-
ruby: [2.5, 2.6, 2.7, '3.0', 3.1, 3.2, 3.3, jruby-9.2, jruby-9.3, jruby-9.4]
52+
ruby: [2.5, 2.6, 2.7, '3.0', 3.1, 3.2, 3.3, 3.4, jruby-9.2, jruby-9.3, jruby-9.4]
5353
env: [KITCHEN_SINK, CRT]
5454

5555
steps:

Gemfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ gem 'rake', require: false
66
# SDK feature dependencies
77
gem 'aws-crt' if ENV['CRT']
88
gem 'base64'
9+
gem 'bigdecimal'
910
gem 'http-2'
1011
gem 'jmespath'
1112
if defined?(JRUBY_VERSION)

gems/aws-sdk-core/spec/aws/log/formatter_spec.rb

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,9 @@ def format(pattern, options = {})
104104
end
105105

106106
it 'provides a :http_request_headers replacement' do
107-
response.context.http_request.headers = { 'foo' => 'bar' }
108-
expect(format(':http_request_headers')).to eq('{"foo"=>"bar"}')
107+
req = response.context.http_request
108+
req.headers = { 'foo' => 'bar' }
109+
expect(format(':http_request_headers')).to eq(req.headers.inspect)
109110
end
110111

111112
it 'provides a :http_request_body replacement' do
@@ -122,8 +123,9 @@ def format(pattern, options = {})
122123
end
123124

124125
it 'provides a :http_response_headers replacement' do
125-
response.context.http_response.headers['foo'] = 'bar'
126-
expect(format(':http_response_headers')).to include('"foo"=>"bar"')
126+
resp = response.context.http_response
127+
resp.headers['foo'] = 'bar'
128+
expect(format(':http_response_headers')).to include(resp.headers.inspect)
127129
end
128130

129131
it 'provides a :http_response_body replacement' do

gems/aws-sdk-core/spec/aws/structure_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ module Aws
99
expect(Structure.new(:abc).new).to be_kind_of(Struct)
1010
end
1111

12-
it 'accpets positional members' do
12+
it 'accepts positional members' do
1313
expect(Structure.new(:abc, :xyz).members).to eq([:abc, :xyz])
1414
end
1515

@@ -85,7 +85,7 @@ class Type < Structure.new(
8585
include Aws::Structure
8686
end
8787
struct = Type.new(trait: 'trait', access_token: 'secret')
88-
expect(struct.to_s).to eq("{:trait=>\"trait\", :access_token=>\"[FILTERED]\"}")
88+
expect(struct.to_s).to include('"[FILTERED]"')
8989
end
9090
end
9191

gems/aws-sdk-core/spec/seahorse/client/logging/formatter_spec.rb

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,9 @@ def format(pattern, options = {})
8888
end
8989

9090
it 'provides a :http_request_headers replacement' do
91-
response.context.http_request.headers = { 'foo' => 'bar' }
92-
expect(format(':http_request_headers')).to eq('{"foo"=>"bar"}')
91+
req = response.context.http_request
92+
req.headers = { 'foo' => 'bar' }
93+
expect(format(':http_request_headers')).to eq(req.headers.inspect)
9394
end
9495

9596
it 'provides a :http_request_body replacement' do
@@ -106,8 +107,9 @@ def format(pattern, options = {})
106107
end
107108

108109
it 'provides a :http_response_headers replacement' do
109-
response.context.http_response.headers['foo'] = 'bar'
110-
expect(format(':http_response_headers')).to eq('{"foo"=>"bar"}')
110+
resp = response.context.http_response
111+
resp.headers['foo'] = 'bar'
112+
expect(format(':http_response_headers')).to eq(resp.headers.inspect)
111113
end
112114

113115
it 'provides a :http_response_body replacement' do

0 commit comments

Comments
 (0)