Skip to content

Commit 0b0e456

Browse files
authored
Merge branch 'main' into caching-tests-clean
Signed-off-by: Simon Marty <martysi@amazon.com>
2 parents 3f073a4 + 6cea869 commit 0b0e456

File tree

2 files changed

+18
-4
lines changed

2 files changed

+18
-4
lines changed

.github/workflows/integration-tests.yml

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,16 +24,26 @@ jobs:
2424
permissions:
2525
id-token: write
2626
contents: read
27+
issues: write
2728
pull-requests: write
29+
30+
env:
31+
LABEL_NAME: safe-to-test
32+
REPO: ${{ github.event.pull_request.base.repo.full_name }}
33+
PR_NUMBER: ${{ github.event.pull_request.number }}
2834

2935
steps:
30-
- name: Remove safe-to-test label after use
31-
if: github.event_name == 'pull_request_target' && contains(github.event.pull_request.labels.*.name, 'safe-to-test')
36+
- name: Remove label
3237
run: |
33-
gh api repos/${{ github.repository }}/issues/${{ github.event.pull_request.number }}/labels/safe-to-test -X DELETE || true
38+
echo "Removing label '$LABEL_NAME' from PR #$PR_NUMBER on repo $REPO"
39+
gh_status=$(gh api "repos/$OWNER/$REPO/issues/$PR_NUMBER/labels/$LABEL_NAME" -X DELETE | jq ".status" --raw-output)
40+
case $gh_status in
41+
200) echo "Label removed" ;;
42+
404) echo "Label not found — ignoring" ;;
43+
*) echo "unexpected HTTP $gh_status" && exit 1 ;;
44+
esac
3445
env:
3546
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
36-
3747
- name: Checkout
3848
uses: actions/checkout@v5
3949
with:

README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,10 @@ To build the Secrets Manager Agent binary natively, you need the standard develo
4141

4242
------
4343

44+
**NOTE:** To ensure a stable experience, use a specific git tag when building from source code. You can find a list of version tags [here](https://github.com/aws/aws-secretsmanager-agent/tags). Tags are in the pattern `/v\d+\.\d+\.\d+/` and follow [SemVer 2.0.0](https://semver.org/spec/v2.0.0.html).
45+
46+
Example: `git clone --branch <git tag> https://github.com/aws/aws-secretsmanager-agent.git`
47+
4448
**NOTE:** Building the agent with the `fips` feature enabled on macOS currently requires the following workaround:
4549

4650
- Create an environment variable called `SDKROOT` which is set to the result of running `xcrun --show-sdk-path`

0 commit comments

Comments
 (0)